From nobody@FreeBSD.org  Sat Apr 25 20:44:20 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BDF0A106567D
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 25 Apr 2009 20:44:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id AB6F68FC24
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 25 Apr 2009 20:44:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3PKiKCF036485
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 25 Apr 2009 20:44:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n3PKiKZw036484;
	Sat, 25 Apr 2009 20:44:20 GMT
	(envelope-from nobody)
Message-Id: <200904252044.n3PKiKZw036484@www.freebsd.org>
Date: Sat, 25 Apr 2009 20:44:20 GMT
From: Volker Theile <votdev@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Unload console screensaver kernel modules if saver is disabled in rc.conf
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         134006
>Category:       conf
>Synopsis:       [patch] Unload console screensaver kernel modules if saver is disabled in rc.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-rc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 25 20:50:03 UTC 2009
>Closed-Date:    Fri Nov 02 13:33:01 UTC 2012
>Last-Modified:  Fri Nov 02 13:33:01 UTC 2012
>Originator:     Volker Theile
>Release:        
>Organization:
FreeNAS
>Environment:
FreeBSD vmbsd72i386 7.2-RC2 FreeBSD 7.2-RC2 #0: Thu Apr 23 22:07:24 UTC 2009     root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
If a console screensaver kernel module is loaded and active and i remove the 'saver="xxx"' rc.conf variable or set it to 'saver=""' the saver kernel module is not unloaded when i execute '/etc/rc.d/syscons restart'. With the attached patch this will be done.

>How-To-Repeat:
1. Configure a console saver in rc.conf:
saver="green"

2. Start it
# /etc/rc.d/syscons start
# kldstat
Id Refs Address    Size     Name
 1    5 0xc0400000 9fab28   kernel
 2    1 0xc0dfb000 6a45c    acpi.ko
 3    1 0xc2e8b000 2000     green_saver.ko

3. Remove or unset console saver in rc.conf:
saver=""

4. Restart syscons
# /etc/rc.d/syscons restart
# kldstat
Id Refs Address    Size     Name
 1    5 0xc0400000 9fab28   kernel
 2    1 0xc0dfb000 6a45c    acpi.ko
 3    1 0xc2e8b000 2000     green_saver.ko

5. Apply patch and restart syscons
# /etc/rc.d/syscons restart
# kldstat
Id Refs Address    Size     Name
 1    3 0xc0400000 9fab28   kernel
 2    1 0xc0dfb000 6a45c    acpi.ko

>Fix:
--- syscons.orig	2009-04-23 20:16:16.000000000 +0000
+++ syscons	2009-04-25 19:30:35.000000000 +0000
@@ -205,14 +205,14 @@
 
 	# screen saver
 	#
+	for i in `kldstat | awk '$5 ~ "_saver\.ko$" { print $5 }'`; do
+		kldunload ${i}
+	done
 	case ${saver} in
 	[Nn][Oo] | '')
 		;;
 	*)
 		echo -n ' screensaver'
-		for i in `kldstat | awk '$5 ~ "_saver\.ko$" { print $5 }'`; do
-			kldunload ${i}
-		done
 		load_kld -e _saver ${saver}_saver
 		;;
 	esac


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat May 2 21:59:34 UTC 2009 
Responsible-Changed-Why:  
patch against rc.conf. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134006 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Fri Nov 2 13:33:01 UTC 2012 
State-Changed-Why:  
You should set saver=NO, not saver="", then you will get the behaviour 
you want. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134006 
>Unformatted:
