From nobody@FreeBSD.org  Sat Jul 12 21:52:41 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAED8106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 21:52:40 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BD4F18FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 21:52:40 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6CLqc0O031484
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jul 2008 21:52:38 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6CLqcB6031483;
	Sat, 12 Jul 2008 21:52:38 GMT
	(envelope-from nobody)
Message-Id: <200807122152.m6CLqcB6031483@www.freebsd.org>
Date: Sat, 12 Jul 2008 21:52:38 GMT
From: Igor Mozolevsky <igor@hybrid-lab.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] building WLAN userland should be optional
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125551
>Category:       conf
>Synopsis:       [patch] building WLAN userland should be optional
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 12 22:00:07 UTC 2008
>Closed-Date:    Fri Aug 06 17:59:47 UTC 2010
>Last-Modified:  Fri Aug 06 17:59:47 UTC 2010
>Originator:     Igor Mozolevsky
>Release:        RELENG_7
>Organization:
>Environment:
>Description:
FreeBSD builds unnecessary WLAN userland utilities by default. There should be an option to switch that behaviour off.
>How-To-Repeat:
cd /usr/src && make world
>Fix:
Add WITHOUT_WLAN to src.conf to prevent WPA stuff (hostapd and wpa_supplicant) and wlandebug from being built. Patch attached.

There are probably other things that shouldn't be built if WLAN support is not required, if someone points them out to me I'll add them to the patch.

Patch attached with submission follows:

--- share/mk/bsd.own.mk.old	2008-07-12 19:37:55.000000000 +0100
+++ share/mk/bsd.own.mk	2008-07-12 19:38:32.000000000 +0100
@@ -358,6 +358,7 @@
     TCSH \
     TOOLCHAIN \
     USB \
+    WLAN \
     WPA_SUPPLICANT_EAPOL \
     ZONEINFO \
     ZFS
--- usr.sbin/Makefile.old	2008-07-12 19:39:17.000000000 +0100
+++ usr.sbin/Makefile	2008-07-12 19:42:36.000000000 +0100
@@ -184,9 +184,9 @@
 	vipw \
 	watch \
 	watchdogd \
-	wlandebug \
+	${_wlandebug} \
 	${_wlconfig} \
-	wpa \
+	${_wpa} \
 	${_ypbind} \
 	${_yp_mkdb} \
 	${_yppoll} \
@@ -296,6 +296,11 @@
 _usbdevs=	usbdevs
 .endif
 
+.if ${MK_WLAN} != "no"
+_wldebug= wlandebug
+_wpa= wpa
+.endif
+
 .if ${MACHINE_ARCH} == "arm"
 _kgmon=		kgmon
 .endif


>Release-Note:
>Audit-Trail:

From: AT Matik <asstec@matik.com.br>
To: freebsd-bugs@freebsd.org
Cc: Igor Mozolevsky <igor@hybrid-lab.co.uk>, freebsd-gnats-submit@freebsd.org
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Sat, 12 Jul 2008 19:15:03 -0300

 > Add WITHOUT_WLAN to src.conf to prevent WPA stuff (hostapd and
 > wpa_supplicant) and wlandebug from being built. Patch attached.
 
 If doing so I suggest you better seperate them because you might not need w=
 pa=20
 but need wlandebug or any other combination
 
 Jo=E3o
 
 
 Atenciosamente, J.M.
 Respons=E1vel Plant=E3o Site Support Matik
 Infomatik Internet Technology
 (18)3551.8155 =A0(18)8112.7007
 http://info.matik.com.br
 
 A mensagem foi scaneada pelo sistema de e-mail e pode ser considerada segura.
 Service fornecido pelo Datacenter Matik  https://datacenter.matik.com.br

From: "Igor Mozolevsky" <igor@hybrid-lab.co.uk>
To: "AT Matik" <asstec@matik.com.br>
Cc: freebsd-bugs@freebsd.org, freebsd-gnats-submit@freebsd.org
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Sat, 12 Jul 2008 23:24:45 +0100

 2008/7/12 AT Matik <asstec@matik.com.br>:
 > On Saturday 12 July 2008 18:52:38 Igor Mozolevsky wrote:
 
 >> Add WITHOUT_WLAN to src.conf to prevent WPA stuff (hostapd and
 >> wpa_supplicant) and wlandebug from being built. Patch attached.
 >>
 >
 > If doing so I suggest you better seperate them because you might not need wpa
 > but need wlandebug or any other combination
 
 Ok, how about WITHOUT_WLAN => WITHOUT_WLANDEBUG (do not build
 wlandebug) + WITHOUT_WPA (neither hostapd nor wpa_supplicant are
 built)? Are there any other userland WLAN things that may need
 disabling?

From: AT Matik <asstec@matik.com.br>
To: freebsd-bugs@freebsd.org
Cc: "Igor Mozolevsky" <igor@hybrid-lab.co.uk>,
        freebsd-gnats-submit@freebsd.org
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Sat, 12 Jul 2008 20:50:42 -0300

 On Saturday 12 July 2008 19:24:45 Igor Mozolevsky wrote:
 > 2008/7/12 AT Matik <asstec@matik.com.br>:
 > > On Saturday 12 July 2008 18:52:38 Igor Mozolevsky wrote:
 > >> Add WITHOUT_WLAN to src.conf to prevent WPA stuff (hostapd and
 > >> wpa_supplicant) and wlandebug from being built. Patch attached.
 > >
 > > If doing so I suggest you better seperate them because you might not ne=
 ed
 > > wpa but need wlandebug or any other combination
 >
 > Ok, how about WITHOUT_WLAN =3D> WITHOUT_WLANDEBUG (do not build
 > wlandebug) + WITHOUT_WPA (neither hostapd nor wpa_supplicant are
 > built)? Are there any other userland WLAN things that may need
 > disabling?
 
 looks ok to me
 I believe other wlan options are kernel dependent =20
 
 Jo=E3o
 
 
 =2D-=20
 
 Atenciosamente, J.M.
 Respons=E1vel Plant=E3o Site Support Matik
 Infomatik Internet Technology
 (18)3551.8155 =A0(18)8112.7007
 http://info.matik.com.br
 
 
 
 
 
 
 
 A mensagem foi scaneada pelo sistema de e-mail e pode ser considerada segura.
 Service fornecido pelo Datacenter Matik  https://datacenter.matik.com.br

From: "Igor Mozolevsky" <igor@hybrid-lab.co.uk>
To: freebsd-bugs@freebsd.org
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Thu, 24 Jul 2008 23:57:21 +0100

 ------=_Part_41657_27429661.1216940241276
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 2008/7/13 AT Matik <asstec@matik.com.br>:
 > On Saturday 12 July 2008 19:24:45 Igor Mozolevsky wrote
 >
 >> Ok, how about WITHOUT_WLAN => WITHOUT_WLANDEBUG (do not build
 >> wlandebug) + WITHOUT_WPA (neither hostapd nor wpa_supplicant are
 >> built)? Are there any other userland WLAN things that may need
 >> disabling?
 >
 > looks ok to me
 
 
 
 patch attached for RELENG_7
 
 ------=_Part_41657_27429661.1216940241276
 Content-Type: text/plain; name=without-wlan-patch-releng7.txt
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fj1yrz0c0
 Content-Disposition: attachment; filename=without-wlan-patch-releng7.txt
 
 LS0tIHNoYXJlL21rL2JzZC5vd24ubWsub3JpZwkyMDA4LTA3LTI0IDIzOjA2OjA5LjAwMDAwMDAw
 MCArMDEwMAorKysgc2hhcmUvbWsvYnNkLm93bi5tawkyMDA4LTA3LTI0IDIzOjQyOjMzLjAwMDAw
 MDAwMCArMDEwMApAQCAtMzU4LDYgKzM1OCw5IEBACiAgICAgVENTSCBcCiAgICAgVE9PTENIQUlO
 IFwKICAgICBVU0IgXAorICAgIFdMQU4gXAorICAgIFdMQU5ERUJVRyBcCisgICAgV1BBIFwKICAg
 ICBXUEFfU1VQUExJQ0FOVF9FQVBPTCBcCiAgICAgWk9ORUlORk8gXAogICAgIFpGUwpAQCAtNDQ4
 LDYgKzQ1MSwxMSBAQAogTUtfR0RCOj0Jbm8KIC5lbmRpZgogCisuaWYgJHtNS19XTEFOfSA9PSAi
 bm8iCitNS19XUEE6PQlubworTUtfV0xBTkRFQlVHOj0Jbm8KKy5lbmRpZgorCiAjCiAjIFNldCBk
 ZWZhdWx0cyBmb3IgdGhlIE1LXypfU1VQUE9SVCB2YXJpYWJsZXMuCiAjCi0tLSB1c3Iuc2Jpbi9N
 YWtlZmlsZS5vcmlnCTIwMDgtMDctMjQgMDI6MTc6MTYuMDAwMDAwMDAwICswMTAwCisrKyB1c3Iu
 c2Jpbi9NYWtlZmlsZQkyMDA4LTA3LTI0IDIzOjQ1OjQ4LjAwMDAwMDAwMCArMDEwMApAQCAtMTg1
 LDkgKzE4NSw5IEBACiAJdmlwdyBcCiAJd2F0Y2ggXAogCXdhdGNoZG9nZCBcCi0Jd2xhbmRlYnVn
 IFwKKwkke193bGFuZGVidWd9IFwKIAkke193bGNvbmZpZ30gXAotCXdwYSBcCisJJHtfd3BhfSBc
 CiAJJHtfeXBiaW5kfSBcCiAJJHtfeXBfbWtkYn0gXAogCSR7X3lwcG9sbH0gXApAQCAtMjk3LDYg
 KzI5NywxNCBAQAogX3VzYmRldnM9CXVzYmRldnMKIC5lbmRpZgogCisuaWYgJHtNS19XTEFOREVC
 VUd9ICE9ICJubyIKK193bGFuZGVidWc9CXdsYW5kZWJ1ZworLmVuZGlmCisKKy5pZiAke01LX1dQ
 QX0gIT0gIm5vIgorX3dwYT0JCXdwYQorLmVuZGlmCisKIC5pZiAke01BQ0hJTkVfQVJDSH0gPT0g
 ImFybSIKIF9rZ21vbj0JCWtnbW9uCiAuZW5kaWYKLS0tIC9kZXYvbnVsbAkyMDA4LTA3LTI0IDIz
 OjQ0OjAwLjAwMDAwMDAwMCArMDEwMAorKysgdG9vbHMvYnVpbGQvb3B0aW9ucy9XSVRIT1VUX1dM
 QU4JMjAwOC0wNy0yNCAyMzozNTozNi4wMDAwMDAwMDAgKzAxMDAKQEAgLTAsMCArMSBAQAorVGhp
 cyBvcHRpb24gd2lsbCBwcmV2ZW50IGFsbCB1c2VybGFuZCBXTEFOIHV0aWxpdGllcyBmcm9tIGJl
 aW5nIGJ1aWx0LgotLS0gL2Rldi9udWxsCTIwMDgtMDctMjQgMjM6NDQ6MDAuMDAwMDAwMDAwICsw
 MTAwCisrKyB0b29scy9idWlsZC9vcHRpb25zL1dJVEhPVVRfV0xBTkRFQlVHCTIwMDgtMDctMjQg
 MjM6MzU6NTEuMDAwMDAwMDAwICswMTAwCkBAIC0wLDAgKzEsMyBAQAorU2V0dGluZyB0aGlzIHZh
 cmlhYmxlIHdpbGwgcHJldmVudAorLlhyIHdsYW5kZWJ1ZyA4Citmcm9tIGJlaW5nIGJ1aWx0Lgot
 LS0gL2Rldi9udWxsCTIwMDgtMDctMjQgMjM6NDQ6MDAuMDAwMDAwMDAwICswMTAwCisrKyB0b29s
 cy9idWlsZC9vcHRpb25zL1dJVEhPVVRfV1BBCTIwMDgtMDctMjQgMjM6MzU6NTguMDAwMDAwMDAw
 ICswMTAwCkBAIC0wLDAgKzEsNSBAQAorU2V0dGluZyB0aGlzIHZhcmlhYmxlIHdpbGwgcHJldmVu
 dAorLlhyIGhvc3RhcGQgOAorYW5kCisuWHIgd3BhX3N1cHBsaWNhbnQgOAorZnJvbSBiZWluZyBi
 dWlsdC4K
 ------=_Part_41657_27429661.1216940241276--

From: "Igor Mozolevsky" <igor@hybrid-lab.co.uk>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Mon, 28 Jul 2008 01:45:23 +0100

 ------=_Part_12281_27514072.1217205923099
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 2008/7/24 Igor Mozolevsky <igor@hybrid-lab.co.uk>:
 
 > patch attached for RELENG_7
 
 Seems gnats is having issues with base64 encoded attachments...
 
 ------=_Part_12281_27514072.1217205923099
 Content-Type: application/octet-stream; name=wlan.patch
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fj6cxuv71
 Content-Disposition: attachment; filename=wlan.patch
 
 LS0tIHNoYXJlL21rL2JzZC5vd24ubWsub2xkCTIwMDgtMDctMTIgMTk6Mzc6NTUuMDAwMDAwMDAw
 ICswMTAwCisrKyBzaGFyZS9tay9ic2Qub3duLm1rCTIwMDgtMDctMTIgMTk6Mzg6MzIuMDAwMDAw
 MDAwICswMTAwCkBAIC0zNTgsNiArMzU4LDcgQEAKICAgICBUQ1NIIFwKICAgICBUT09MQ0hBSU4g
 XAogICAgIFVTQiBcCisgICAgV0xBTiBcCiAgICAgV1BBX1NVUFBMSUNBTlRfRUFQT0wgXAogICAg
 IFpPTkVJTkZPIFwKICAgICBaRlMKLS0tIHVzci5zYmluL01ha2VmaWxlLm9sZAkyMDA4LTA3LTEy
 IDE5OjM5OjE3LjAwMDAwMDAwMCArMDEwMAorKysgdXNyLnNiaW4vTWFrZWZpbGUJMjAwOC0wNy0x
 MiAxOTo0MjozNi4wMDAwMDAwMDAgKzAxMDAKQEAgLTE4NCw5ICsxODQsOSBAQAogCXZpcHcgXAog
 CXdhdGNoIFwKIAl3YXRjaGRvZ2QgXAotCXdsYW5kZWJ1ZyBcCisJJHtfd2xhbmRlYnVnfSBcCiAJ
 JHtfd2xjb25maWd9IFwKLQl3cGEgXAorCSR7X3dwYX0gXAogCSR7X3lwYmluZH0gXAogCSR7X3lw
 X21rZGJ9IFwKIAkke195cHBvbGx9IFwKQEAgLTI5Niw2ICsyOTYsMTEgQEAKIF91c2JkZXZzPQl1
 c2JkZXZzCiAuZW5kaWYKIAorLmlmICR7TUtfV0xBTn0gIT0gIm5vIgorX3dsZGVidWc9IHdsYW5k
 ZWJ1ZworX3dwYT0gd3BhCisuZW5kaWYKKwogLmlmICR7TUFDSElORV9BUkNIfSA9PSAiYXJtIgog
 X2tnbW9uPQkJa2dtb24KIC5lbmRpZgo=
 ------=_Part_12281_27514072.1217205923099--

From: "Igor Mozolevsky" <igor@hybrid-lab.co.uk>
To: freebsd-gnats-submit@freebsd.org
Cc: freebsd-bugs@freebsd.org
Subject: Re: conf/125551: [PATCH] building WLAN userland should be optional
Date: Mon, 28 Jul 2008 13:04:37 +0100

 Ok,
 take three:
 
 --- share/mk/bsd.own.mk.orig	2008-07-24 23:06:09.000000000 +0100
 +++ share/mk/bsd.own.mk	2008-07-24 23:42:33.000000000 +0100
 @@ -358,6 +358,9 @@
      TCSH \
      TOOLCHAIN \
      USB \
 +    WLAN \
 +    WLANDEBUG \
 +    WPA \
      WPA_SUPPLICANT_EAPOL \
      ZONEINFO \
      ZFS
 @@ -448,6 +451,11 @@
  MK_GDB:=	no
  .endif
 
 +.if ${MK_WLAN} == "no"
 +MK_WPA:=	no
 +MK_WLANDEBUG:=	no
 +.endif
 +
  #
  # Set defaults for the MK_*_SUPPORT variables.
  #
 --- usr.sbin/Makefile.orig	2008-07-24 02:17:16.000000000 +0100
 +++ usr.sbin/Makefile	2008-07-24 23:45:48.000000000 +0100
 @@ -185,9 +185,9 @@
  	vipw \
  	watch \
  	watchdogd \
 -	wlandebug \
 +	${_wlandebug} \
  	${_wlconfig} \
 -	wpa \
 +	${_wpa} \
  	${_ypbind} \
  	${_yp_mkdb} \
  	${_yppoll} \
 @@ -297,6 +297,14 @@
  _usbdevs=	usbdevs
  .endif
 
 +.if ${MK_WLANDEBUG} != "no"
 +_wlandebug=	wlandebug
 +.endif
 +
 +.if ${MK_WPA} != "no"
 +_wpa=		wpa
 +.endif
 +
  .if ${MACHINE_ARCH} == "arm"
  _kgmon=		kgmon
  .endif
 --- /dev/null	2008-07-24 23:44:00.000000000 +0100
 +++ tools/build/options/WITHOUT_WLAN	2008-07-24 23:35:36.000000000 +0100
 @@ -0,0 +1 @@
 +This option will prevent all userland WLAN utilities from being built.
 --- /dev/null	2008-07-24 23:44:00.000000000 +0100
 +++ tools/build/options/WITHOUT_WLANDEBUG	2008-07-24 23:35:51.000000000 +0100
 @@ -0,0 +1,3 @@
 +Setting this variable will prevent
 +.Xr wlandebug 8
 +from being built.
 --- /dev/null	2008-07-24 23:44:00.000000000 +0100
 +++ tools/build/options/WITHOUT_WPA	2008-07-24 23:35:58.000000000 +0100
 @@ -0,0 +1,5 @@
 +Setting this variable will prevent
 +.Xr hostapd 8
 +and
 +.Xr wpa_supplicant 8
 +from being built.
State-Changed-From-To: open->closed 
State-Changed-By: bschmidt 
State-Changed-When: Fri Aug 6 17:56:41 UTC 2010 
State-Changed-Why:  
A similar feature has been commited with revision 183242, with 
the WITHOUT_WIRELESS knob in src.conf the installation of WPA tools 
can be omitted. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125551 
>Unformatted:
