From doug@dt054n86.san.rr.com Tue Jun 29 22:58:47 1999
Return-Path: <doug@dt054n86.san.rr.com>
Received: from dt054n86.san.rr.com (dt054n86.san.rr.com [24.30.152.134])
	by hub.freebsd.org (Postfix) with ESMTP id 86A5614E12
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Jun 1999 22:58:35 -0700 (PDT)
	(envelope-from doug@dt054n86.san.rr.com)
Received: (from root@localhost)
	by dt054n86.san.rr.com (8.8.8/8.8.8) id WAA25040;
	Tue, 29 Jun 1999 22:58:32 -0700 (PDT)
	(envelope-from doug)
Message-Id: <199906300558.WAA25040@dt054n86.san.rr.com>
Date: Tue, 29 Jun 1999 22:58:32 -0700 (PDT)
From: Doug@gorean.org
Sender: doug@dt054n86.san.rr.com
Reply-To: Doug@gorean.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: [Patch] 2 files not included by /usr/src/etc/Makefile
X-Send-Pr-Version: 3.2

>Number:         12458
>Category:       conf
>Synopsis:       [Patch] 2 files not included by /usr/src/etc/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 29 23:00:01 PDT 1999
>Closed-Date:    Thu Jul 8 22:30:52 PDT 1999
>Last-Modified:  Thu Jul  8 22:50:02 PDT 1999
>Originator:     Doug
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
AAAG
>Environment:

	-Current, probably -Stable too

>Description:

	The files rc.sysctl and dhclient.conf in /usr/src/etc are not included
in the Makefile, so they don't get installed. 

>How-To-Repeat:

	Use /usr/src/etc/Makefile to install files (ala mergemaster).

>Fix:
	
	Apply the following patch, which also re-alphabetizes the file names
(which will probably be very unpopular :).


--- Makefile.Dist	Thu Jun 24 17:19:36 1999
+++ Makefile	Tue Jun 29 22:05:39 1999
@@ -3,13 +3,14 @@
 
 SUBDIR=	sendmail
 
-BIN1=   aliases amd.map crontab csh.cshrc csh.login csh.logout dm.conf \
-	fbtab ftpusers gettytab group hosts hosts.allow host.conf hosts.equiv \
-	hosts.lpd inetd.conf auth.conf login.conf login.access motd modems \
-	networks newsyslog.conf pam.conf phones pccard.conf.sample \
-	printcap profile protocols \
-	rc rc.atm rc.devfs rc.firewall rc.isdn rc.network rc.pccard \
-	rc.serial rc.shutdown rc.diskless1 rc.diskless2 \
+BIN1=   aliases amd.map auth.conf crontab csh.cshrc csh.login csh.logout\
+	dhclient.conf dm.conf fbtab ftpusers gettytab group \
+	hosts hosts.allow host.conf hosts.equiv hosts.lpd \
+	inetd.conf login.access login.conf \
+	motd modems networks newsyslog.conf pam.conf pccard.conf.sample \
+	phones printcap profile protocols \
+	rc rc.atm rc.devfs rc.diskless1 rc.diskless2 rc.firewall rc.isdn \
+	rc.network rc.pccard  rc.serial rc.shutdown rc.sysctl \
 	etc.${MACHINE_ARCH}/rc.${MACHINE_ARCH} \
 	remote security services shells syslog.conf \
 	etc.${MACHINE_ARCH}/ttys etc.${MACHINE_ARCH}/disktab rpc make.conf \

Enjoy,

Doug

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: sheldonh 
State-Changed-When: Wed Jun 30 14:55:01 PDT 1999 
State-Changed-Why:  
I worry that you haven't tested your changes, since you've clearly 
overlooked the fact that we don't install a sysctl.conf, making your 
rc.sysctl a no-op. What are you hoping to achieve by adding these 
two files to the target? 

From: Doug <Doug@gorean.org>
To: sheldonh@FreeBSD.org
Cc: freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile
Date: Wed, 30 Jun 1999 15:58:06 -0700 (PDT)

 On Wed, 30 Jun 1999 sheldonh@FreeBSD.org wrote:
 
 > Synopsis: [Patch] 2 files not included by /usr/src/etc/Makefile
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: sheldonh
 > State-Changed-When: Wed Jun 30 14:55:01 PDT 1999
 > State-Changed-Why: 
 > I worry that you haven't tested your changes,
 
 	I have definitely tested my changes, and they definitely do what I
 intended them to do. 
 
 > since you've clearly
 > overlooked the fact that we don't install a sysctl.conf, making your
 > rc.sysctl a no-op.
 
 	There are several files in /etc/ already that are no-op's unless
 you activate the features that use them. In fact I dare say that half the
 files in there are things I have never used, until recently when I started
 using NFS. Now it's down to 1/3 of the files in /etc/ that I've never
 used. 
 
 > What are you hoping to achieve by adding these
 > two files to the target?
 
 	I think that the question you should ask is, "Why are these files
 in /usr/src/etc/ if we're not going to install them?" At the same time,
 what I hope to achieve is a complete update of the system configuration
 files with mergemaster. I am more concerned about dhclient.conf
 personally, but when I noticed that it wasn't getting installed I checked
 the rest of the files in the directory and noticed the rc.sysctl file.
 Personally I learned a lot about freebsd and what's available by reading
 through the stuff in /etc as a new user, so as long as we are going to
 provide that functionality in rc then we ought to slap the rc.sysctl file
 in there to let people know about it. 
 
 	Now that I've allayed your fears regarding my thought process, if
 you're not comfortable with committing the patch, assign the PR to either
 imp or obrien since they are the ones responsible for those two files.
 
 Thanks,
 
 Doug
 
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Doug <Doug@gorean.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile 
Date: Thu, 01 Jul 1999 01:02:43 +0200

 On Wed, 30 Jun 1999 15:58:06 MST, Doug wrote:
 
 > 	I think that the question you should ask is, "Why are these files
 > in /usr/src/etc/ if we're not going to install them?"
 
 Work in progress? :-)
 
 > I am more concerned about dhclient.conf personally, but when I noticed
 > that it wasn't getting installed I checked the rest of the files in
 > the directory and noticed the rc.sysctl file.
 
 And having dhclient.conf in /etc/ doesn't "magically" turn something on?
 This is my point, really.
 
 > 	Now that I've allayed your fears regarding my thought process, if
 > you're not comfortable with committing the patch, assign the PR to either
 > imp or obrien since they are the ones responsible for those two files.
 
 "Almost allayed". And I certainly won't be sorting BIN1. ;-)
 
 Ciao,
 Sheldon.
 

From: Doug <Doug@gorean.org>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile
Date: Wed, 30 Jun 1999 16:37:30 -0700 (PDT)

 On Thu, 1 Jul 1999, Sheldon Hearn wrote:
 
 > On Wed, 30 Jun 1999 15:58:06 MST, Doug wrote:
 > 
 > > 	I think that the question you should ask is, "Why are these files
 > > in /usr/src/etc/ if we're not going to install them?"
 > 
 > Work in progress? :-)
 
 	As Nik stated so succintly, "bollocks."
 
 > > I am more concerned about dhclient.conf personally, but when I noticed
 > > that it wasn't getting installed I checked the rest of the files in
 > > the directory and noticed the rc.sysctl file.
 > 
 > And having dhclient.conf in /etc/ doesn't "magically" turn something on?
 > This is my point, really.
 
 	No, it doesn't turn anything on. If you looked at the file you
 would see that it's nothing but comments. OTOH, users who try to start
 dhclient without a conf file somtimes run into trouble. And do me a favor
 in the future please. You and I seem to have some kind of communications
 problem, so please try to state your "real" point more clearly in the
 future so that we can both save some time. 
 
 > > 	Now that I've allayed your fears regarding my thought process, if
 > > you're not comfortable with committing the patch, assign the PR to either
 > > imp or obrien since they are the ones responsible for those two files.
 > 
 > "Almost allayed".
 
 	Like I said, if you don't understand/aren't comfortable with the
 issues involved, assign the PR to someone who is. 
 
 > And I certainly won't be sorting BIN1. ;-)
 
 	You don't have to, I already did. :) But seriously folks, I can't
 think of a reason not to re-alphabetize it, since the entries that are
 there are currently almost right anyway. However as I indicated in my PR
 adding the two files is the important point here. 
 
 Doug
 -- 
 On account of being a democracy and run by the people, we are the only
 nation in the world that has to keep a government four years, no matter
 what it does.
                 -- Will Rogers
 
 
State-Changed-From-To: feedback->open 
State-Changed-By: sheldonh 
State-Changed-When: Wed Jun 30 16:40:21 PDT 1999 
State-Changed-Why:  
I shouldn't have gotten involved. :-) 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: imp@village.org, obrien@nuxi.com
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile 
Date: Thu, 01 Jul 1999 01:51:58 +0200

 Hi gents,
 
 Please note that there's a PR open (12458) for two files that are not
 included in the BIN1 list for installation from src/etc/ . The files are
 
 	rc.sysctl	- Warner, you said you weren't adding it to the
 			  Makefile until you got more feedback.
 
 	dhclient.conf	- David, not sure whether you had a reason for
 			  leaving this out of the install.
 
 Thanks,
 Sheldon.
 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Thu Jul 8 22:30:52 PDT 1999 
State-Changed-Why:  
dhclient.conf now installed.  I could not find that we still/ever had a real 
rc.sysctl in src/etc/ 
 

From: Doug <Doug@gorean.org>
To: obrien@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile
Date: Thu, 08 Jul 1999 22:43:52 -0700

 obrien@FreeBSD.org wrote:
 
 > dhclient.conf now installed. 
 
 	Gracias. :) This was the one I was concerned about.
 
 > I could not find that we still/ever had a real
 > rc.sysctl in src/etc/
 
 	http://www.freebsd.org/cgi/cvsweb.cgi/src/etc/rc.sysctl has a note that
 imp doesn't plan to put it into the makefile "until I get more feedback." I
 should have checked that first, my bad.
 
 Thanks again,
 
 Doug
 
>Unformatted:
