From nobody@FreeBSD.org  Tue Mar 25 14:58:55 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7275106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Mar 2008 14:58:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E14608FC29
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Mar 2008 14:58:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2PEwh4m005107
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Mar 2008 14:58:43 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m2PEwhME005106;
	Tue, 25 Mar 2008 14:58:43 GMT
	(envelope-from nobody)
Message-Id: <200803251458.m2PEwhME005106@www.freebsd.org>
Date: Tue, 25 Mar 2008 14:58:43 GMT
From: Taku <taku@tekipaki.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: /etc/periodic/security/410.logincheck doesn't work
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122069
>Category:       conf
>Synopsis:       /etc/periodic/security/410.logincheck doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 25 15:00:03 UTC 2008
>Closed-Date:    Fri Mar 28 22:26:31 UTC 2008
>Last-Modified:  Fri Mar 28 22:26:31 UTC 2008
>Originator:     Taku
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
>Environment:
FreeBSD FreeBSD7 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008     root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
src/etc/periodic/security/410.logincheck contains syntax error.
Semi-colon is missing in line 42.

% sh -n /etc/periodic/security/410.logincheck 
/etc/periodic/security/410.logincheck: 44: Syntax error: "else" unexpected (expecting "then")

>How-To-Repeat:
sh -n /etc/periodic/security/410.logincheck
>Fix:
Following is a patch.
--- /etc/periodic/security/410.logincheck	2008-02-25 02:53:19.000000000 +0900
+++ /tmp/410.logincheck	2008-03-26 08:44:33.000000000 +0900
@@ -39,7 +39,7 @@
     [Yy][Ee][Ss])
 	echo ""
 	echo 'Checking login.conf permissions:'
-	if [ -G /etc/login.conf -a -O /etc/login.conf ] then
+	if [ -G /etc/login.conf -a -O /etc/login.conf ]; then
 	    n=0
 	else
 	    echo "Bad ownership of /etc/login.conf"


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue Mar 25 15:16:30 UTC 2008 
Responsible-Changed-Why:  
MFC reminder 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122069 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/122069: commit references a PR
Date: Tue, 25 Mar 2008 15:16:28 +0000 (UTC)

 remko       2008-03-25 15:16:19 UTC
 
   FreeBSD src repository
 
   Modified files:
     etc/periodic/security 410.logincheck 
   Log:
   Add a missing ;.
   
   PR:             misc/122069
   Submitted by:   taku@tekipaki.jp
   MFC after:      3 days
   Approved by:    imp (mentor, implicit trivial change).
   
   Revision  Changes    Path
   1.2       +1 -1      src/etc/periodic/security/410.logincheck
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/122069: commit references a PR
Date: Fri, 28 Mar 2008 20:59:51 +0000 (UTC)

 remko       2008-03-28 20:59:45 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     etc/periodic/security 410.logincheck 
   Log:
   MFC rev 1.2 410.logincheck
   
     Add a missing ;.
   
     PR:             misc/122069
     Submitted by:   taku@tekipaki.jp
     MFC after:      3 days
     Approved by:    imp (mentor, implicit trivial change).
   
   Approved by:    imp (mentor, implicit)
   
   Revision  Changes    Path
   1.1.2.1   +1 -1      src/etc/periodic/security/410.logincheck
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: remko 
State-Changed-When: Fri Mar 28 22:26:30 UTC 2008 
State-Changed-Why:  
MFC'ed to all relevant branches 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122069 
>Unformatted:
