From nobody@FreeBSD.org  Thu Mar  6 22:52:49 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0FD80106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 22:52:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id F35AE8FC22
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 22:52:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m26MnihI045358
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Mar 2008 22:49:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m26Mni7I045357;
	Thu, 6 Mar 2008 22:49:44 GMT
	(envelope-from nobody)
Message-Id: <200803062249.m26Mni7I045357@www.freebsd.org>
Date: Thu, 6 Mar 2008 22:49:44 GMT
From: Manfred Usselmann <usselmann.m@icg-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: /etc/rc.d/ppp not working as expected
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         121452
>Category:       conf
>Synopsis:       [patch] /etc/rc.d/ppp not working as expected
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brooks
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 23:00:01 UTC 2008
>Closed-Date:    Fri Mar 28 08:00:00 UTC 2008
>Last-Modified:  Tue Apr 29 20:40:01 UTC 2008
>Originator:     Manfred Usselmann
>Release:        6.3 STABLE
>Organization:
ICG IT Consulting GmbH
>Environment:
FreeBSD icg-pc211.hofheim.icg-online.de 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #4: Wed Dec 26 13:38:10 CET 2007     manfred@icg-pc211.hofheim.icg-online.de:/usr/obj/usr/src/sys/ICG-PC211-RELENG-6-I4B  i386

>Description:
ppp_mode in rc.conf is set to 'ddial', but the start script /etc/rc.d/ppp sets it to 'auto'.

The following part 

        eval _ppp_mode=\$ppp_${_ppp_profile}_mode
        if [ -z "$_ppp_mode" ]; then
                _ppp_mode=$ppp_mode
        fi

sets _ppp_mode  to '-dsl_mode' instead of 'ddial'. This is invalid and therefore set to 'auto' later on.

My settings in rc.conf are:

ppp_enable="YES"
ppp_mode="ddial"
ppp_nat="NO"
ppp_profile="t-dsl"   # name of service provider
>How-To-Repeat:
Set rc.conf to:

ppp_enable="YES"
ppp_mode="ddial"
ppp_nat="NO"
ppp_profile="t-dsl"   # name of service provider

>Fix:
I'm not an expert in shell programming unfortunately...

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Fri Mar 7 11:32:42 UTC 2008 
Responsible-Changed-Why:  
Over to freebsd-rc mailing list 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 
State-Changed-From-To: open->feedback 
State-Changed-By: vwe 
State-Changed-When: Fri Mar 7 14:29:55 UTC 2008 
State-Changed-Why:  

Manfred, 
I'm wondering if you can remove the dash of your ppp profile name? 
Rename it to "tdsl" and see, if you're still experiencing the same? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 
Responsible-Changed-From-To: freebsd-rc->brooks 
Responsible-Changed-By: brooks 
Responsible-Changed-When: Fri Mar 7 15:50:13 UTC 2008 
Responsible-Changed-Why:  
I've proposed a patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 

From: Manfred Usselmann <usselmann.m@icg-online.de>
To: vwe@FreeBSD.org
Cc: freebsd-rc@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected
Date: Sat, 8 Mar 2008 10:29:49 +0100

 vwe@FreeBSD.org schrieb am Fri, 7 Mar 2008 14:31:00 GMT:
 
 > Synopsis: /etc/rc.d/ppp not working as expected
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: vwe
 > State-Changed-When: Fri Mar 7 14:29:55 UTC 2008
 > State-Changed-Why: 
 > 
 > Manfred,
 > I'm wondering if you can remove the dash of your ppp profile name?
 > Rename it to "tdsl" and see, if you're still experiencing the same?
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=121452
 
 By renaming the profile from t-dsl to tdsl the problem disappears.
 
 Manfred
 
 
 -- 
 ________________________________________________________________________
  Manfred Usselmann                            usselmann.m@icg-online.de

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/121452: commit references a PR
Date: Wed, 26 Mar 2008 21:54:54 +0000 (UTC)

 brooks      2008-03-26 21:54:48 UTC
 
   FreeBSD src repository
 
   Modified files:
     etc/rc.d             ppp 
     share/man/man5       rc.conf.5 
   Log:
   Allow the characters .-+/ to appear in ppp profile names by folding them
   to _ when evaluating ppp_<profile>_nat and ppp_<profile>_mode.  Document
   the per-profile variables.
   
   PR:             conf/121452, conf/122127 (partial)
   MFC after:      1 week
   
   Revision  Changes    Path
   1.17      +7 -2      src/etc/rc.d/ppp
   1.336     +24 -3     src/share/man/man5/rc.conf.5
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->patched 
State-Changed-By: brooks 
State-Changed-When: Wed Mar 26 22:11:53 UTC 2008 
State-Changed-Why:  
Applied a patch to head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 
State-Changed-From-To: patched->closed 
State-Changed-By: brooks 
State-Changed-When: Fri Mar 28 07:58:47 UTC 2008 
State-Changed-Why:  
PR conf/122127 convers this issue and another so I'll use it to track the MFC 
of this issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/121452: commit references a PR
Date: Tue, 15 Apr 2008 22:37:47 +0000 (UTC)

 brooks      2008-04-15 22:37:43 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     etc/rc.d             ppp 
   Log:
   MFC revs 1.17-1.20, the functional components of which are:
   
   1.17:
   Allow the characters .-+/ to appear in ppp profile names by folding them
   to _ when evaluating ppp_<profile>_nat and ppp_<profile>_mode.  Document
   the per-profile variables.
   
   1.18:
   Add support for hardwiring ppp sessions to particular devices with new
   per-profile variables of the form ppp_<profile>_unit.  No ppp_unit
   variable is supported since tying the same unit to more than one profile
   won't work.
   
   PR:             conf/121452, conf/122127
   
   Revision  Changes    Path
   1.11.2.5  +16 -3     src/etc/rc.d/ppp
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/121452: commit references a PR
Date: Tue, 29 Apr 2008 20:17:53 +0000 (UTC)

 brooks      2008-04-29 20:17:46 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     share/man/man5       rc.conf.5 
   Log:
   MFC per ppp profile variable documentation (revs 1.336 and 1.337)
   
   PR:             conf/121452, conf/122127
   
   Revision   Changes    Path
   1.327.2.5  +32 -3     src/share/man/man5/rc.conf.5
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/121452: commit references a PR
Date: Tue, 29 Apr 2008 20:34:37 +0000 (UTC)

 brooks      2008-04-29 20:34:31 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     share/man/man5       rc.conf.5 
   Log:
   MFC per ppp profile variable documentation (revs 1.336 and 1.337)
   
   PR:             conf/121452, conf/122127
   
   Revision    Changes    Path
   1.256.2.38  +32 -3     src/share/man/man5/rc.conf.5
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
