From tataz@tataz.chchile.org  Mon Feb 26 13:19:18 2007
Return-Path: <tataz@tataz.chchile.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8FF7D16A400
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Feb 2007 13:19:18 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from postfix1-g20.free.fr (postfix1-g20.free.fr [212.27.60.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 3120D13C47E
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Feb 2007 13:19:18 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35])
	by postfix1-g20.free.fr (Postfix) with ESMTP id 1293FA9AE5B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Feb 2007 13:56:43 +0100 (CET)
Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98])
	by smtp5-g19.free.fr (Postfix) with ESMTP id 54B8235BCE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Feb 2007 13:56:42 +0100 (CET)
Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25])
	by tatooine.tataz.chchile.org (Postfix) with ESMTP id 86D469BF12
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Feb 2007 12:58:33 +0000 (UTC)
Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000)
	id 787CC405B; Mon, 26 Feb 2007 13:58:33 +0100 (CET)
Message-Id: <20070226125833.787CC405B@obiwan.tataz.chchile.org>
Date: Mon, 26 Feb 2007 13:58:33 +0100 (CET)
From: Jeremie Le Hen <jeremie@le-hen.org>
Reply-To: Jeremie Le Hen <jeremie@le-hen.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [rc.d] [patch] Make rc.d/devfs usable from command-line
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         109562
>Category:       conf
>Synopsis:       [rc.d] [patch] [request] Make rc.d/devfs usable from command-line
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 26 13:20:06 GMT 2007
>Closed-Date:    Wed Feb 08 09:23:48 UTC 2012
>Last-Modified:  Wed Feb 08 09:23:48 UTC 2012
>Originator:     Jeremie Le Hen <jeremie@le-hen.org>
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
FreeBSD jarjarbinks 7.0-CURRENT FreeBSD 7.0-CURRENT #23: Sun Feb 25 20:01:52 UTC 2007     root@jarjarbinks/usr/obj/usr/src/sys/JARJARBINKS  i386

>Description:
	The attached patch allows to provide arguments to rc.d/devfs with
	the same syntax as $devfs_set_rulesets.  This is then easier to mount
	manually devfs inside a directory and apply some predefined rulesets
	on it.  Before this patch you had to manually apply rules to the
	devfs mount point, provided pre-configured rulesets had been loaded
	into the kernel (with rc.subr's devfs_init_rulesets()).

	Example:
	% mount_devfs none /space/chroot/dev
	% /etc/rc.d/devfs start /space/chroot/dev=devfsrules_jail

>How-To-Repeat:
>Fix:

--- rc.d_devfs.patch begins here ---
Index: devfs
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/devfs,v
retrieving revision 1.12
diff -u -p -r1.12 devfs
--- devfs	21 Jan 2006 14:31:45 -0000	1.12
+++ devfs	22 Feb 2007 08:04:16 -0000
@@ -14,8 +14,27 @@ name="devfs"
 start_cmd='devfs_start'
 stop_cmd=':'
 
+set_rulesets()
+{
+	local _dir_set
+	local _dir
+	local _set
+	for _dir_set in "$@"; do
+		_dir=${_dir_set%=*}
+		_set=${_dir_set#*=}
+		devfs_set_ruleset $_set $_dir
+		devfs_apply_ruleset $_set $_dir
+	done
+}
+
 devfs_start()
 {
+	if [ $# -gt 0 ]; then
+		devfs_init_rulesets
+		set_rulesets "$@"
+		return
+	fi
+
 	if [ -n "$devfs_system_ruleset" -o -n "$devfs_set_rulesets" ]; then
 		devfs_init_rulesets
 		if [ -n "$devfs_system_ruleset" ]; then
@@ -23,15 +42,7 @@ devfs_start()
 			devfs_apply_ruleset $devfs_system_ruleset /dev
 		fi
 		if [ -n "$devfs_set_rulesets" ]; then
-			local _dir_set
-			local _dir
-			local _set
-			for _dir_set in $devfs_set_rulesets; do
-				_dir=${_dir_set%=*}
-				_set=${_dir_set#*=}
-				devfs_set_ruleset $_set $_dir
-				devfs_apply_ruleset $_set $_dir
-			done
+			set_rulesets "$devfs_set_rulesets"
 		fi
 	fi
 	read_devfs_conf
@@ -67,4 +78,4 @@ read_devfs_conf()
 }
 
 load_rc_config $name
-run_rc_command "$1"
+run_rc_command "$@"
--- rc.d_devfs.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: yar 
Responsible-Changed-When: Fri Aug 17 09:03:32 UTC 2007 
Responsible-Changed-Why:  
Over to the rc list for consideration. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=109562 
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Wed Feb 8 09:22:37 UTC 2012 
State-Changed-Why:  

No one has expressed interest in this solution for 6 years, 
and setting the rc.conf variable is not that egregious. 


Responsible-Changed-From-To: freebsd-rc->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Wed Feb 8 09:22:37 UTC 2012 
Responsible-Changed-Why:  

I'm closing this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=109562 
>Unformatted:
