From citrin@hius.citrin.ru  Mon Jun 12 16:49:58 2006
Return-Path: <citrin@hius.citrin.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2F49216A41A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Jun 2006 16:49:58 +0000 (UTC)
	(envelope-from citrin@hius.citrin.ru)
Received: from mail.classis.ru (classis.ru [213.248.60.120])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BBF9F43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Jun 2006 16:49:57 +0000 (GMT)
	(envelope-from citrin@hius.citrin.ru)
Received: from hius.citrin.ru (ppp83-237-204-225.pppoe.mtu-net.ru [83.237.204.225])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.classis.ru (Postfix) with ESMTP id 564CC1224830
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Jun 2006 20:49:55 +0400 (MSD)
Received: by hius.citrin.ru (Postfix, from userid 1001)
	id 61672575EBF; Mon, 12 Jun 2006 20:49:44 +0400 (MSD)
Message-Id: <20060612164944.61672575EBF@hius.citrin.ru>
Date: Mon, 12 Jun 2006 20:49:44 +0400 (MSD)
From: Anton Yuzhaninov <citrin@rambler-co.ru>
Reply-To: Anton Yuzhaninov <citrin@rambler-co.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: mount_mfs don't allow create md without softupdates
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         98860
>Category:       bin
>Synopsis:       [patch] mount_mfs(8): allow create md without softupdates
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 12 16:50:12 GMT 2006
>Closed-Date:    Sun Nov 19 12:31:31 GMT 2006
>Last-Modified:  Sun Nov 19 12:40:15 GMT 2006
>Originator:     Anton Yuzhaninov
>Release:        FreeBSD 6.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hius.citrin.ru 6.1-RELEASE FreeBSD 6.1-RELEASE #4: Wed May 24 10:37:01 MSD 2006 root@hius.citrin.ru:/data/usr/obj/data/usr/src/sys/NK i386

>Description:
When mdmfs run with name mount_mfs it work in compatibility mode.
flag -S not allowed in compatibility mode, but by default disk created
with soft-updates turned on.
>How-To-Repeat:
Try to create memory disk with soft-updates turned off from /etc/fstab.
>Fix:

I see two ways to fix this problem:

1. In compatibility mode turn off soft-updates
(In FreeBSD 4.X mount_mfs by default turn soft-updates off).

--- mdmfs.c.orig        Tue May 23 19:38:26 2006
+++ mdmfs.c     Tue May 23 19:43:42 2006
@@ -133,6 +133,7 @@
                        if (compat)
                                usage();
                        compat = true;
+                       softdep = false;
                        break;
                case 'c':
                        argappend(&newfs_arg, "-c %s", optarg);

2. In compatibility mode allow -S option

--- mdmfs.c.orig        Tue May 23 19:38:26 2006
+++ mdmfs.c     Tue May 23 19:45:02 2006
@@ -205,8 +205,6 @@
                        free(set);
                        break;
                case 'S':
-                       if (compat)
-                               usage();
                        softdep = false;
                        break;
                case 's':
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: ru 
State-Changed-When: Fri Nov 3 12:02:43 UTC 2006 
State-Changed-Why:  
I removed the -C option, making it possible to specify -S to disable 
soft updates. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Fri Nov 3 12:02:43 UTC 2006 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=98860 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/98860: commit references a PR
Date: Fri,  3 Nov 2006 12:02:44 +0000 (UTC)

 ru          2006-11-03 12:02:24 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/mdmfs           mdmfs.8 mdmfs.c 
   Log:
   Remove the -C option as it does more harm than good.  To be fully
   compatible, it would have to (at least):
   
   - support the "compat-compat" -T option,
   - *not* support the -l, -O, and -v options,
   - default to soft updates being disabled.
   
   Worse, the compatibility mode makes it impossible to mount_mfs(8)
   a file system from fstab(5) with soft updates disabled (-S).  [1]
   
   Now, the only difference when called as "mount_mfs" or "mfs" (as
   opposed to "mdmfs") is that the file mode of the mount point is
   set by default to 01777.  All options available to mdmfs(8) are
   also available to mount_mfs(8); the -C option is still recognized
   but ignored for backward compatibility.
   
   PR:             bin/98860 [1]
   MFC after:      2 weeks
   
   Revision  Changes    Path
   1.26      +7 -39     src/sbin/mdmfs/mdmfs.8
   1.28      +8 -41     src/sbin/mdmfs/mdmfs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ru 
State-Changed-When: Sun Nov 19 12:30:50 UTC 2006 
State-Changed-Why:  
Merged into RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=98860 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/98860: commit references a PR
Date: Sun, 19 Nov 2006 12:30:38 +0000 (UTC)

 ru          2006-11-19 12:30:31 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sbin/mdmfs           mdmfs.8 mdmfs.c 
   Log:
   MFC:
   
   Remove the -C option as it does more harm than good.  To be fully
   compatible, it would have to (at least):
   
   - support the "compat-compat" -T option,
   - *not* support the -l, -O, and -v options,
   - default to soft updates being disabled.
   
   Worse, the compatibility mode made it impossible to mount_mfs(8)
   a file system from fstab(5) with soft updates disabled (-S).  [1]
   
   Now, the only difference when called as "mount_mfs" or "mfs" (as
   opposed to "mdmfs") is that the file mode of the mount point is
   set by default to 01777.  All options available to mdmfs(8) are
   also available to mount_mfs(8); the -C option is still recognized
   but ignored for backward compatibility.
   
   PR:             bin/98860 [1]
   
   Revision  Changes    Path
   1.20.8.1  +7 -38     src/sbin/mdmfs/mdmfs.8
   1.23.2.2  +8 -39     src/sbin/mdmfs/mdmfs.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
