From peter.jeremy@auss2.alcatel.com.au  Thu Jan 14 21:27:11 1999
Received: from alcanet.com.au (border.alcanet.com.au [203.62.196.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA19249
          for <FreeBSD-gnats-submit@FreeBSD.ORG>; Thu, 14 Jan 1999 21:27:10 -0800 (PST)
          (envelope-from peter.jeremy@auss2.alcatel.com.au)
Received: by border.alcanet.com.au id <40330>; Fri, 15 Jan 1999 16:25:11 +1100
Message-Id: <99Jan15.162511est.40330@border.alcanet.com.au>
Date: Fri, 15 Jan 1999 16:25:48 +1100
From: Peter Jeremy <peter.jeremy@auss2.alcatel.com.au>
Reply-To: peter.jeremy@alcatel.com.au
To: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: cron(8) is not Y2K compliant
X-Send-Pr-Version: 3.2

>Number:         9506
>Category:       bin
>Synopsis:       cron(8) is not Y2K compliant
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 14 21:30:03 PST 1999
>Closed-Date:    Fri Jan 15 17:59:18 PST 1999
>Last-Modified:  Fri Jan 15 17:59:51 PST 1999
>Originator:     Peter Jeremy
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
Alcatel Australia
>Environment:

	

>Description:

cron(8) uses a raw tm_year and will therefore display 100 for 2000.
Use snprintf to protect against excessively long timezone names.

>How-To-Repeat:

Code inspection

>Fix:
	
--- /3.0/src/usr.sbin/cron/lib/misc.c	Mon Sep 15 16:39:25 1997
+++ ./misc.c	Fri Jan 15 14:48:23 1999
@@ -619,9 +619,12 @@
 {
 	time_t t = clock ?*clock :time(0L);
 	struct tm *tm = localtime(&t);
-	static char ret[30];	/* zone name might be >3 chars */
+	static char ret[32];	/* zone name might be >3 chars */
 
-	(void) sprintf(ret, "%s, %2d %s %2d %02d:%02d:%02d %s",
+	if (tm->tm_year >= 100)
+		tm->tm_year += 1900;
+
+	(void) snprintf(ret, sizeof(ret), "%s, %2d %s %2d %02d:%02d:%02d %s",
 		       DowNames[tm->tm_wday],
 		       tm->tm_mday,
 		       MonthNames[tm->tm_mon],
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: danny 
State-Changed-When: Fri Jan 15 17:59:18 PST 1999 
State-Changed-Why:  
Patch applied.  Thanks 
>Unformatted:
