From rmh@io.debian.net  Sat Feb 11 09:47:55 2006
Return-Path: <rmh@io.debian.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A5E9C16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Feb 2006 09:47:55 +0000 (GMT)
	(envelope-from rmh@io.debian.net)
Received: from io.debian.net (io.ethz.ch [129.132.80.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3DF7B43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Feb 2006 09:47:55 +0000 (GMT)
	(envelope-from rmh@io.debian.net)
Received: from rmh by io.debian.net with local (Exim 4.60)
	(envelope-from <rmh@io.debian.net>)
	id 1F7rM9-000P9D-P4
	for FreeBSD-gnats-submit@freebsd.org; Sat, 11 Feb 2006 10:47:53 +0100
Message-Id: <E1F7rM9-000P9D-P4@io.debian.net>
Date: Sat, 11 Feb 2006 10:47:53 +0100
From: Robert Millan <rmh@aybabtu.com>
Reply-To: Robert Millan <rmh@aybabtu.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] uintXX_t style(9) updates
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         93172
>Category:       bin
>Synopsis:       [patch] cksum(1): uintXX_t style(9) updates
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brooks
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 11 09:50:02 GMT 2006
>Closed-Date:    Thu Jun 05 22:36:50 UTC 2008
>Last-Modified:  Fri Jun  6 00:10:04 UTC 2008
>Originator:     Robert Millan
>Release:        
>Organization:
>Environment:
System: GNU/kFreeBSD io.debian.net 5.4-1-586 #0 Mon Dec 5 19:45:10 CET 2005 i586 i386 AMD-K6(tm) 3D processor GNU/kFreeBSD
Architecture: i586

	
>Description:
	Please could you update the following files to use the new uintXX_t types ?

	src/sys/dev/isp/isp.c src/sys/dev/isp/ispvar.h src/usr.bin/cksum/cksum.c

>How-To-Repeat:
	
>Fix:
for i in \
 src/sys/dev/isp/isp.c \
 src/sys/dev/isp/ispvar.h \
 src/usr.bin/cksum/cksum.c \
 ; do
   sed -i $i -e "s/u_int\([0-9]*\)_t/uint\1_t/g"
done
>Release-Note:
>Audit-Trail:

From: Volker <volker@vwsoft.com>
To: bug-followup@FreeBSD.org, rmh@aybabtu.com
Cc:  
Subject: Re: kern/93172: [isp] [patch] uintXX_t style(9) updates
Date: Wed, 13 Feb 2008 23:45:23 +0100

 This is a multi-part message in MIME format.
 --------------000509000404090303030307
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Robert,
 
 I checked the status of your PR and found src/sys/dev/isp/isp* does
 not use types u_int* anymore. History outdated your PR...
 
 But in src/usr.bin/cksum/cksum.c I found a discrepancy:
 
 there's a function pointer declared:
 void (*pfncn)(char *, u_int32_t, off_t);
 
 which will later be pointed to either psum1 or pcrc. These are defined as:
 
 void	psum1(char *, uint32_t, off_t);
 void	pcrc(char *, uint32_t, off_t);
 
 The function pointer declaration differs from function declaration
 (slightly and not causing trouble but it's awful).
 
 patch attached
 
 --------------000509000404090303030307
 Content-Type: text/x-patch;
  name="cksum.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="cksum.c.diff"
 
 --- usr.bin/cksum/cksum.c.orig	2008-02-13 23:37:31.000000000 +0100
 +++ usr.bin/cksum/cksum.c	2008-02-13 23:37:48.000000000 +0100
 @@ -70,7 +70,7 @@
  	off_t len;
  	char *fn, *p;
  	int (*cfncn)(int, uint32_t *, off_t *);
 -	void (*pfncn)(char *, u_int32_t, off_t);
 +	void (*pfncn)(char *, uint32_t, off_t);
  
  	if ((p = rindex(argv[0], '/')) == NULL)
  		p = argv[0];
 
 --------------000509000404090303030307--
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Thu Feb 14 06:27:56 UTC 2008 
State-Changed-Why:  
To submitter: does the patch in the followup fix your problem? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93172 

Adding to audit trail manually by linimon:
 
 Volker Werth noted in the followup that the part of the original
 patch that affected isp(4) is now OBE.  However, the problem with
 cksum(1) still remains (and he supplied an updated patch).  Thus,
 I've changed the Synopsis accordingly.
State-Changed-From-To: feedback->analyzed 
State-Changed-By: vwe 
State-Changed-When: Thu May 8 21:50:12 UTC 2008 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=93172 
State-Changed-From-To: analyzed->patched 
State-Changed-By: brooks 
State-Changed-When: Thu May 15 20:05:24 UTC 2008 
State-Changed-Why:  
Committed to HEAD 


Responsible-Changed-From-To: freebsd-bugs->brooks 
Responsible-Changed-By: brooks 
Responsible-Changed-When: Thu May 15 20:05:24 UTC 2008 
Responsible-Changed-Why:  
Committed to HEAD 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93172 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/93172: commit references a PR
Date: Thu, 15 May 2008 20:04:59 +0000 (UTC)

 brooks      2008-05-15 20:04:37 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/cksum        cksum.c 
   Log:
   Change a use of u_int32_t to uint32_t.
   
   PR:             bin/93172
   Submitted by:   Robert Millan <rmh at aybabtu dot com>
   MFC after:      1 week
   
   Revision  Changes    Path
   1.18      +1 -1      src/usr.bin/cksum/cksum.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brooks 
State-Changed-When: Thu Jun 5 22:36:31 UTC 2008 
State-Changed-Why:  
MFC to 6 and 7 

http://www.freebsd.org/cgi/query-pr.cgi?pr=93172 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/93172: commit references a PR
Date: Fri,  6 Jun 2008 00:06:53 +0000 (UTC)

 brooks      2008-06-05 22:35:58 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     usr.bin/cksum        cksum.c 
   Log:
   SVN rev 179584 on 2008-06-05 22:35:58Z by brooks
   
   MFC r179024: Change a use of u_int32_t to uint32_t.
   
   PR:             bin/93172
   
   Revision   Changes    Path
   1.17.12.1  +1 -1      src/usr.bin/cksum/cksum.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/93172: commit references a PR
Date: Fri,  6 Jun 2008 00:06:53 +0000 (UTC)

 brooks      2008-06-05 22:35:07 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     usr.bin/cksum        cksum.c 
   Log:
   SVN rev 179583 on 2008-06-05 22:35:07Z by brooks
   
   MFC r179024: Change a use of u_int32_t to uint32_t.
   
   PR:             bin/93172
   
   Revision   Changes    Path
   1.17.22.1  +1 -1      src/usr.bin/cksum/cksum.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
