From nobody@FreeBSD.org  Mon Jan 23 07:45:09 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8EA5016A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 23 Jan 2006 07:45:09 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 59FCA43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 23 Jan 2006 07:45:09 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0N7j82q026856
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 23 Jan 2006 07:45:09 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k0N7j8vl026855;
	Mon, 23 Jan 2006 07:45:08 GMT
	(envelope-from nobody)
Message-Id: <200601230745.k0N7j8vl026855@www.freebsd.org>
Date: Mon, 23 Jan 2006 07:45:08 GMT
From: "Shin'ya Kumabuchi" <kumabu@t3.rim.or.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dhclient-script(8) doesn't configure interface when $reason is TIMEOUT
X-Send-Pr-Version: www-2.3

>Number:         92187
>Category:       bin
>Synopsis:       [patch] dhclient-script(8) doesn't configure interface when $reason is TIMEOUT
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brooks
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 23 07:50:03 GMT 2006
>Closed-Date:    Sat May 13 03:26:31 GMT 2006
>Last-Modified:  Sat May 13 03:26:31 GMT 2006
>Originator:     Shin'ya Kumabuchi
>Release:        6.0-STABLE
>Organization:
>Environment:
FreeBSD hoge 6.0-STABLE FreeBSD 6.0-STABLE #1: Mon Jan 23 05:39:57 JST 2006     root@hoge:/usr/local/obj/usr/src/sys/KUMA  i386
>Description:
dhclient-script is executed by dhclient for configuring interface.
After configuring the interface with ifconfig, dhclient-script checks the interface's sanity with ping command when $reason is TIMEOUT.
And back out preceding ifconfig operation, if ping command fails.

But dhclient-script uses ping command with '-w' option that isn't valid for FreeBSD's ping command.
So ping command always fails, and the interface remains unconfigured.
>How-To-Repeat:
              
>Fix:
--- /usr/src/sbin/dhclient/dhclient-script      Sun Sep 11 02:01:16 2005
+++ /sbin/dhclient-script       Mon Jan 23 16:37:24 2006
@@ -272,7 +272,7 @@
        if [ -n "$new_routers" ]; then
                $LOGGER "New Routers ($interface): $new_routers"
                set "$new_routers"
-               if ping -q -c 1 -w 1 "$1"; then
+               if ping -q -c 1 -t 1 "$1"; then
                        if [ "$new_ip_address" != "$alias_ip_address" ]; then
                                add_new_alias
                        fi

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brooks 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Mon Jan 23 08:57:49 UTC 2006 
Responsible-Changed-Why:  
The patch looks correct. Pass the PR to Brooks, since he is maintainer of dhclient. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92187 
State-Changed-From-To: open->patched 
State-Changed-By: brooks 
State-Changed-When: Tue Jan 24 06:19:05 UTC 2006 
State-Changed-Why:  
Committed to HEAD, will MFC before release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92187 
State-Changed-From-To: patched->closed 
State-Changed-By: brooks 
State-Changed-When: Sat May 13 03:25:58 UTC 2006 
State-Changed-Why:  
Merged to RELENG_6.  Sorry for not getting it in in time for 6.1. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92187 
>Unformatted:
