From phk@critter.freebsd.dk  Tue Dec 20 12:21:45 2005
Return-Path: <phk@critter.freebsd.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33AF016A44B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 20 Dec 2005 12:21:45 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C07C143D62
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 20 Dec 2005 12:21:43 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 180B3BC66;
	Tue, 20 Dec 2005 12:21:41 +0000 (UTC)
Message-Id: <9718.1135081301@critter.freebsd.dk>
Date: Tue, 20 Dec 2005 13:21:41 +0100
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
Sender: phk@critter.freebsd.dk
To: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
Cc: FreeBSD-gnats-submit@freebsd.org
In-Reply-To: Your message of "Wed, 14 Dec 2005 14:20:32 GMT."
             <200512141420.jBEEKWi9007375@945testbox.york.ac.uk> 
Subject: Re: [patch] Remove debug printfs from routed 

>Number:         90679
>Category:       bin
>Synopsis:       Re: [patch] Remove debug printfs from routed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 20 12:30:03 GMT 2005
>Closed-Date:    Tue Dec 20 16:58:17 GMT 2005
>Last-Modified:  Tue Dec 20 16:58:17 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 In message <200512141420.jBEEKWi9007375@945testbox.york.ac.uk>, Gavin Atkinson 
 writes:
 
 >As far as I can tell, the "loop" line serves no purpose, and initially concerned me as
 >I initially thought something had gone wrong (due to ther terseness). I suspect the code
 >was left in accidentally as part of the changes in revision 1.14 of src/sbin/routed/if.c
 >by phk.  I propose we remove them, or if it's decided they should stay, make them a little
 >more verbose.  The attached patch removes them.
 
 That's a long time ago indeed.
 
 I belive the problem was that routed checked the wrong bit to find
 loopback interfaces and therefore classified some other interfaces
 (point2point ?) as uninteresting.
 
 I don't think the printf serves any particular cause any more.
 
 -- 
 Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
 phk@FreeBSD.ORG         | TCP/IP since RFC 956
 FreeBSD committer       | BSD since 4.3-tahoe    
 Never attribute to malice what can adequately be explained by incompetence.
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Dec 20 16:57:51 UTC 2005 
State-Changed-Why:  
Misfiled followup to bin/90389; content migrated. 


Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Dec 20 16:57:51 UTC 2005 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=90679 
>Unformatted:
