From placej@ibm.net  Sat Nov 28 12:00:06 1998
Received: from ibm.net. (slip166-72-224-176.pa.us.ibm.net [166.72.224.176])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08968
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Nov 1998 12:00:03 -0800 (PST)
          (envelope-from placej@ibm.net)
Received: (from placej@localhost)
	by ibm.net. (8.8.8/8.8.8) id PAA00675;
	Sat, 28 Nov 1998 15:00:27 -0500 (EST)
	(envelope-from placej)
Message-Id: <199811282000.PAA00675@ibm.net.>
Date: Sat, 28 Nov 1998 15:00:27 -0500 (EST)
From: jcplace@ibm.net
Reply-To: jcplace@ibm.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: cp missing verbose switch
X-Send-Pr-Version: 3.2

>Number:         8880
>Category:       bin
>Synopsis:       cp missing verbose switch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    billf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 28 12:10:01 PST 1998
>Closed-Date:    Sat Aug 28 02:57:44 PDT 1999
>Last-Modified:  Sat Aug 28 02:58:49 PDT 1999
>Originator:     John C. Place
>Release:        FreeBSD 2.2.7-RELEASE i386
>Organization:
>Environment:

	

>Description:
Something I miss is verbose option (-v) on cp,mv,rm to let me see what
is hapening.  


>How-To-Repeat:

	

>Fix:
	Small changes to cp.c and utils.c

--- cp.org	Wed Nov 25 04:08:44 1998
+++ cp.c	Wed Nov 25 04:48:53 1998
@@ -86,7 +86,7 @@
 PATH_T to = { to.p_path, "" };
 
 uid_t myuid;
-int Rflag, iflag, pflag, rflag, fflag;
+int Rflag, iflag, pflag, rflag, vflag, fflag;
 int myumask;
 
 enum op { FILE_TO_FILE, FILE_TO_DIR, DIR_TO_DNE };
@@ -105,7 +105,7 @@
 	char *target;
 
 	Hflag = Lflag = Pflag = 0;
-	while ((ch = getopt(argc, argv, "HLPRfipr")) != -1)
+	while ((ch = getopt(argc, argv, "HLPRfiprv")) != -1)
 		switch (ch) {
 		case 'H':
 			Hflag = 1;
@@ -135,6 +135,9 @@
 			break;
 		case 'r':
 			rflag = 1;
+			break;
+		case 'v':
+			vflag = 1;
 			break;
 		default:
 			usage();


--- utils.org	Wed Nov 25 04:44:01 1998
+++ utils.c	Sat Nov 28 10:03:40 1998
@@ -115,6 +115,10 @@
 		return (1);;
 	}
 
+	if (vflag) { 
+		(void)fprintf(stderr,"Copying %s to %s\n", entp->fts_path, to.p_path);
+	}
+
 	rval = 0;
 
 	/*
@@ -319,7 +323,7 @@
 usage()
 {
 	(void)fprintf(stderr, "%s\n%s\n",
-"usage: cp [-R [-H | -L | -P]] [-f | -i] [-p] src target",
-"       cp [-R [-H | -L | -P]] [-f | -i] [-p] src1 ... srcN directory");
+"usage: cp [-R [-H | -L | -P]] [-f | -i] [-p] [-v] src target",
+"       cp [-R [-H | -L | -P]] [-f | -i] [-p] [-v] src1 ... srcN directory");
 	exit(1);
 }
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->billf 
Responsible-Changed-By: billf 
Responsible-Changed-When: Sun Dec 13 17:12:26 PST 1998 
Responsible-Changed-Why:  
I will look into this. 

From: Steve Horan <sjhoran@syd.lucid.net.au>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: bin/8880
Date: Sun, 11 Apr 1999 15:24:06 +1000 (EST)

 After applying the patch to give the cp command verbosity as found in pr
 bin/8880, cp doesn't compile. (under 3.1-STABLE)
 
 This was fixed easily with this patch.
 
 Regards,
 
 Steve Horan.
 
 
 --- utils.c.old Sun Apr 11 15:17:24 1999
 +++ utils.c     Sun Apr 11 15:02:50 1999
 @@ -54,6 +54,8 @@
 
  #include "extern.h"
 
 +int Rflag, iflag, pflag, rflag, vflag, fflag;
 +
  int
  copy_file(entp, dne)
         FTSENT *entp;
 
 

From: "John C. Place" <placej@ctcdist.com>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: bin/8880: cp missing verbose switch
Date: Wed, 5 May 1999 14:02:01 -0400

 Here is a patch for this that patches/compiles clean on 3.1-RELEASE sources. 
 
 Sorry about not following up and the fact it did not work on 3.1 version.
 
 Thanks
 John
 
 John C. Place
 
 --- cp.org	Wed May  5 11:58:04 1999
 +++ cp.c	Wed May  5 12:11:09 1999
 @@ -82,7 +82,7 @@
  PATH_T to = { to.p_path, "" };
  
  uid_t myuid;
 -int Rflag, iflag, pflag, rflag, fflag;
 +int Rflag, iflag, pflag, rflag, fflag, vflag;
  int myumask;
  
  enum op { FILE_TO_FILE, FILE_TO_DIR, DIR_TO_DNE };
 @@ -101,7 +101,7 @@
  	char *target;
  
  	Hflag = Lflag = Pflag = 0;
 -	while ((ch = getopt(argc, argv, "HLPRfipr")) != -1)
 +	while ((ch = getopt(argc, argv, "HLPRfiprv")) != -1)
  		switch (ch) {
  		case 'H':
  			Hflag = 1;
 @@ -131,6 +131,9 @@
  			break;
  		case 'r':
  			rflag = 1;
 +			break;
 +		case 'v':
 +			vflag = 1;
  			break;
  		default:
  			usage();
 
 
 
 --- utils.org	Wed May  5 11:58:46 1999
 +++ utils.c	Wed May  5 12:24:16 1999
 @@ -54,6 +54,8 @@
  
  #include "extern.h"
  
 +int Rflag, iflag, pflag, rflag, vflag, fflag;
 +
  int
  copy_file(entp, dne)
  	FTSENT *entp;
 @@ -72,6 +74,10 @@
  		return (1);
  	}
  
 +	if (vflag) {
 +		(void)fprintf(stderr,"Copying %s to %s\n", entp->fts_path, to.p_path);
 +	}	
 +
  	fs = entp->fts_statp;
  
  	/*
 @@ -320,7 +326,7 @@
  usage()
  {
  	(void)fprintf(stderr, "%s\n%s\n",
 -"usage: cp [-R [-H | -L | -P]] [-f | -i] [-p] src target",
 -"       cp [-R [-H | -L | -P]] [-f | -i] [-p] src1 ... srcN directory");
 +"usage: cp [-R [-H | -L | -P]] [-f | -i] [-p] [-v] src target",
 +"       cp [-R [-H | -L | -P]] [-f | -i] [-p] [-v] src1 ... srcN directory");
  	exit(1);
  }
 
 
 
State-Changed-From-To: open->closed 
State-Changed-By: mharo 
State-Changed-When: Sat Aug 28 02:57:44 PDT 1999 
State-Changed-Why:  
verbose flag added to cp 
>Unformatted:
