From jonc@chen.org.nz  Sun Nov  6 00:49:33 2005
Return-Path: <jonc@chen.org.nz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 320C016A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  6 Nov 2005 00:49:33 +0000 (GMT)
	(envelope-from jonc@chen.org.nz)
Received: from chen.org.nz (chen.org.nz [210.54.19.51])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CFF0543D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  6 Nov 2005 00:49:32 +0000 (GMT)
	(envelope-from jonc@chen.org.nz)
Received: by chen.org.nz (Postfix, from userid 1000)
	id 277F65641F; Sun,  6 Nov 2005 13:49:31 +1300 (NZDT)
Message-Id: <20051106004931.277F65641F@chen.org.nz>
Date: Sun,  6 Nov 2005 13:49:31 +1300 (NZDT)
From: Jonathan Chen <jonc@chen.org.nz>
Reply-To: Jonathan Chen <jonc@chen.org.nz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: tcsh ls-F spacing incorrect.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         88538
>Category:       bin
>Synopsis:       [patch] tcsh(1) ls-F spacing incorrect.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 06 00:50:14 GMT 2005
>Closed-Date:    Fri Mar 02 03:26:18 UTC 2012
>Last-Modified:  Fri Mar 02 03:26:18 UTC 2012
>Originator:     Jonathan Chen
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD osiris.chen.org.nz 6.0-STABLE FreeBSD 6.0-STABLE #0: Sat Nov 5 19:04:46 NZDT 2005 root@osiris.chen.org.nz:/usr/obj/usr/src/sys/GENERIC i386
>Description:
6-STABLE tcsh's internal ls-F spacing between file names is calculated
incorrectly, resulting in non-pretty overflowing lines on 80-coloumn.

This does not happen on 5-STABLE.
>How-To-Repeat:

	[login on console]
	% tcsh
	% mkdir c
	% cd c
	% touch a2345678.90 b2345678.90 c2345678.90
	% touch d2345678.90 e2345678.90 f2345678.90
	% ls-F
	[output overflows on one line]
	% ls -F
	a2345678.90     c2345678.90     e2345678.90
	b2345678.90     d2345678.90     f2345678.90

>Fix:
>Release-Note:
>Audit-Trail:

From: Jonathan Chen <jonc@chen.org.nz>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/88538: tcsh(1) ls-F spacing incorrect.
Date: Sat, 26 Nov 2005 22:06:09 +1300

 Hi,
 
 Here's a patch to fix the problem, obtained from tcsh-bugs mailing list.
 
 Cheers.
 -- 
 Jonathan Chen <jonc@chen.org.nz>
 ----------------------------------------------------------------------
           "You can get farther with a kind word and a gun
                       than you can with a kind word alone" - Al Capone
 
 --- tw.parse.c.old	Sat Nov 26 22:01:35 2005
 +++ tw.parse.c	Sat Nov 26 22:01:47 2005
 @@ -2088,6 +2088,7 @@
  		    Char f = items[i][w - 1];
  		    items[i][w - 1] = 0;
  		    print_with_color(items[i], w - 1, f);
 +		    wx++;
  		}
  		else {
  		    /* Print filename followed by '/' or '*' or ' ' */
State-Changed-From-To: open->analyzed 
State-Changed-By: ceri 
State-Changed-When: Fri Dec 30 18:28:56 UTC 2005 
State-Changed-Why:  
It's probably unlikely that we will want to pull this off the vendor 
branch for such an issue, but leave this open until the next import. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88538 

From: Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp>
To: bug-followup@FreeBSD.org, jonc@chen.org.nz
Cc:  
Subject: Re: bin/88538: [patch] tcsh(1) ls-F spacing incorrect.
Date: Fri, 17 Mar 2006 17:39:40 +0900

 Hello,
 
 I also send-pr-ed about a bug caused by the same origin,
 but it was declined (PR bin/94477).
 Fix about this bug is already tested in snapshot releases of tcsh (6.14.01 - 6.14.05),
 and I hope the fix be adopted asap.
 
 I also notice that another way of fix is used in tcsh-6.14.05:
 add
 	items[i][w - 1] = f;
 instead of adding
 	wx++;
 .
 
 Sincerely,
 
 ---
 Tsurutani Naoki
 turutani@scphys.kyoto-u.ac.jp

From: Jonathan Chen <jonc@chen.org.nz>
To: bug-followup@FreeBSD.org, jonc@chen.org.nz
Cc:  
Subject: Re: bin/88538: [patch] tcsh(1) ls-F spacing incorrect.
Date: Fri, 2 Mar 2012 11:36:22 +1300

 Time to close this, it's been 6 years and it doesn't appear to be a
 problem in STABLE-9.
 -- 
 Jonathan Chen <jonc@chen.org.nz>
State-Changed-From-To: analyzed->closed 
State-Changed-By: eadler 
State-Changed-When: Fri Mar 2 03:26:17 UTC 2012 
State-Changed-Why:  
fixed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88538 
>Unformatted:
