From flz@xbsd.org  Wed Oct  5 11:12:42 2005
Return-Path: <flz@xbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8B59516A41F;
	Wed,  5 Oct 2005 11:12:42 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 253AC43D46;
	Wed,  5 Oct 2005 11:12:41 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id B5D7011769;
	Wed,  5 Oct 2005 13:12:39 +0200 (CEST)
Received: from smtp.xbsd.org ([127.0.0.1])
 by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 18315-10; Wed,  5 Oct 2005 13:12:27 +0200 (CEST)
Received: by smtp.xbsd.org (Postfix, from userid 2001)
	id 42F9E11598; Wed,  5 Oct 2005 13:12:26 +0200 (CEST)
Message-Id: <20051005111226.42F9E11598@smtp.xbsd.org>
Date: Wed,  5 Oct 2005 13:12:26 +0200 (CEST)
From: Florent Thoumie <flz@xbsd.org>
Reply-To: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: des@FreeBSD.org
Subject: src/usr.bin/fetch - fix mirror mode (-m)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         86940
>Category:       bin
>Synopsis:       src/usr.bin/fetch - fix mirror mode (-m)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 05 11:20:17 GMT 2005
>Closed-Date:    Fri Jan 13 13:40:35 GMT 2006
>Last-Modified:  Fri Jan 13 13:40:35 GMT 2006
>Originator:     Florent Thoumie
>Release:        FreeBSD 5.3-RELEASE i386
>Organization:
Xbsd.org
>Environment:
System: FreeBSD srv1.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386

>Description:

	Mirror mode is actually not working because the size of local file
	is always set to -1.

	Spotted by: Antonin Bonte <antonin.bonte@ejake.org>

	Maintainer (des@) CC'ed.

>How-To-Repeat:

	Fetch one file, then try to re-fetch it with -am option.

>Fix:

--- fetch.c.diff begins here ---
Index: fetch.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/fetch/fetch.c,v
retrieving revision 1.75
diff -u -r1.75 fetch.c
--- fetch.c	18 Nov 2004 12:01:30 -0000	1.75
+++ fetch.c	5 Oct 2005 11:04:10 -0000
@@ -418,7 +418,7 @@
 	sb.st_size = -1;
 	if (!o_stdout) {
 		r = stat(path, &sb);
-		if (r == 0 && r_flag && S_ISREG(sb.st_mode)) {
+		if (r == 0 && (r_flag || m_flag) && S_ISREG(sb.st_mode)) {
 			url->offset = sb.st_size;
 		} else {
 			/*
--- fetch.c.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: flz 
Responsible-Changed-When: Wed Oct 5 11:20:40 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86940 
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Fri Jan 13 13:40:31 UTC 2006 
State-Changed-Why:  
fixed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86940 
>Unformatted:
