From nobody@FreeBSD.org  Wed Jun  8 13:04:57 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 062EF16A41C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 Jun 2005 13:04:57 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB64343D53
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 Jun 2005 13:04:56 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j58D4uec067652
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 8 Jun 2005 13:04:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j58D4u5O067650;
	Wed, 8 Jun 2005 13:04:56 GMT
	(envelope-from nobody)
Message-Id: <200506081304.j58D4u5O067650@www.freebsd.org>
Date: Wed, 8 Jun 2005 13:04:56 GMT
From: Philippe Laquet <stom@free.fr>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Choosing an alternate default MTA
X-Send-Pr-Version: www-2.3

>Number:         82030
>Category:       bin
>Synopsis:       [sysinstall] Choosing an alternate default MTA
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    simon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 08 13:10:06 GMT 2005
>Closed-Date:    Sat Mar 04 10:04:24 GMT 2006
>Last-Modified:  Sat Mar 04 10:04:24 GMT 2006
>Originator:     Philippe Laquet
>Release:        5.4
>Organization:
>Environment:
>Description:
During sysinstall for a 5.4 on an i386 - When performing post-install configuration and selection of the Mail activated at startup. Unable to choose the Postfix MTA as default. Seems to look for a package named postfix-2.1* and the postfix version included on 5.4 is postfix-2.2*
>How-To-Repeat:
Simply perform a 5.4 installation on a i386 platform, install additionnals packages, including postfix and its dependencies - And after installation, under post-install configuration, try to select Postfix as default MTA.
>Fix:
      
>Release-Note:
>Audit-Trail:

From: Matteo Riondato <rionda@gufi.org>
To: bug-followup@FreeBSD.org, stom@free.fr, re@freebsd.org
Cc:  
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Mon, 13 Jun 2005 23:26:50 +0200

 This is a serious bug and should be solved altough we're now in a code
 freeze, that's why I'm CC'ing re@. A patch for this bug follows
 (the problem resides in src/usr.sbin/sysinstall/config.c) and
 should be ok until postfix2 will become postfix3.
 
 Please note that this bug is not properly i386 specific.
 
 Patch: (can be found at http://www.riondabsd.net/diff/config.c.diff )
 
 --- config.c.old	Tue Jun  7 23:01:41 2005
 +++ config.c	Mon Jun 13 23:17:26 2005
 @@ -990,7 +990,7 @@
  	msgError("Error setting the enviroment variable POSTFIX_DEFAULT_MTA: %s (%u)",
  		 strerror(errno), errno);
  
 -    ret = package_add("postfix-2.1");
 +    ret = package_add("postfix-2");
      unsetenv("POSTFIX_DEFAULT_MTA");
  
      if(DITEM_STATUS(ret) == DITEM_FAILURE) {
 
 Best Regards	 
 -- 
 Rionda aka Matteo Riondato
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)

From: "Simon L. Nielsen" <simon@nitro.dk>
To: Matteo Riondato <rionda@gufi.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Mon, 13 Jun 2005 23:54:07 +0200

 --fWddYNRDgTk9wQGZ
 Content-Type: multipart/mixed; boundary="Qrgsu6vtpU/OV/zm"
 Content-Disposition: inline
 
 
 --Qrgsu6vtpU/OV/zm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2005.06.13 21:30:26 +0000, Matteo Riondato wrote:
 
 >  This is a serious bug and should be solved altough we're now in a code
 >  freeze, that's why I'm CC'ing re@. A patch for this bug follows
 >  (the problem resides in src/usr.sbin/sysinstall/config.c) and
 >  should be ok until postfix2 will become postfix3.
 > =20
 >  Please note that this bug is not properly i386 specific.
 > =20
 >  Patch: (can be found at http://www.riondabsd.net/diff/config.c.diff )
 > =20
 >  --- config.c.old	Tue Jun  7 23:01:41 2005
 >  +++ config.c	Mon Jun 13 23:17:26 2005
 >  @@ -990,7 +990,7 @@
 >   	msgError("Error setting the enviroment variable POSTFIX_DEFAULT_MTA: %=
 s (%u)",
 >   		 strerror(errno), errno);
 >  =20
 >  -    ret =3D package_add("postfix-2.1");
 >  +    ret =3D package_add("postfix-2");
 >       unsetenv("POSTFIX_DEFAULT_MTA");
 >  =20
 >       if(DITEM_STATUS(ret) =3D=3D DITEM_FAILURE) {
 
 This does not fix the problem since it will now pick up the wrong
 postfix version when you install from a complete FTP mirror (see the
 CVS log for the commit that added the -2.1 part as to why).
 
 I made the simple attached patch some time ago, I just forgot about it
 again since I needed to test that it actually did work as expected
 before committing... :-/ - I will try to get around to it soon, unless
 somebody else beats me to it.
 
 --=20
 Simon L. Nielsen
 
 --Qrgsu6vtpU/OV/zm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="sysinstall-postfix22.patch"
 Content-Transfer-Encoding: quoted-printable
 
 Index: config.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/config.c,v
 retrieving revision 1.231
 diff -u -d -r1.231 config.c
 --- config.c	16 Nov 2004 21:59:00 -0000	1.231
 +++ config.c	4 Apr 2005 21:39:29 -0000
 @@ -990,7 +990,7 @@
  	msgError("Error setting the enviroment variable POSTFIX_DEFAULT_MTA: %s (=
 %u)",
  		 strerror(errno), errno);
 =20
 -    ret =3D package_add("postfix-2.1");
 +    ret =3D package_add("postfix-2.2");
      unsetenv("POSTFIX_DEFAULT_MTA");
 =20
      if(DITEM_STATUS(ret) =3D=3D DITEM_FAILURE) {
 
 --Qrgsu6vtpU/OV/zm--
 
 --fWddYNRDgTk9wQGZ
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (FreeBSD)
 
 iD8DBQFCrgB/h9pcDSc1mlERArecAJ9IG0GiuL7i1ygZhPzJ+XO5wCui4QCfRD6a
 wd8+LMJWAIBHkTAZ9q4hmqg=
 =pK5F
 -----END PGP SIGNATURE-----
 
 --fWddYNRDgTk9wQGZ--

From: Matteo Riondato <rionda@gufi.org>
To: "Simon L. Nielsen" <simon@nitro.dk>, freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Tue, 14 Jun 2005 08:35:46 +0200

 On Mon, Jun 13, 2005 at 11:54:07PM +0200, Simon L. Nielsen wrote:
 > On 2005.06.13 21:30:26 +0000, Matteo Riondato wrote:
 > 
 > >  This is a serious bug and should be solved altough we're now in a code
 > >  freeze, that's why I'm CC'ing re@. A patch for this bug follows
 
 > This does not fix the problem since it will now pick up the wrong
 > postfix version when you install from a complete FTP mirror (see the
 > CVS log for the commit that added the -2.1 part as to why).
 
 You're right, I forgot about network installs, sorry.
 
 > I made the simple attached patch some time ago, I just forgot about it
 > again since I needed to test that it actually did work as expected
 > before committing... :-/ - I will try to get around to it soon, unless
 > somebody else beats me to it.
 
 I think your patch will be ok, but the problem will present again
 once we have postfix-2.3 . I'm looking for a more permanent solution
 but it's not so easy as it would involve some cut'n'paste that I don't
 absolutely like.
 Best Regards
 -- 
 Rionda aka Matteo Riondato
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)

From: "Simon L. Nielsen" <simon@FreeBSD.org>
To: Matteo Riondato <rionda@gufi.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Tue, 14 Jun 2005 23:50:07 +0200

 --DrWhICOqskFTAXiy
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2005.06.14 08:35:46 +0200, Matteo Riondato wrote:
 > On Mon, Jun 13, 2005 at 11:54:07PM +0200, Simon L. Nielsen wrote:
 > > On 2005.06.13 21:30:26 +0000, Matteo Riondato wrote:
 > >=20
 > > >  This is a serious bug and should be solved altough we're now in a co=
 de
 > > >  freeze, that's why I'm CC'ing re@. A patch for this bug follows
 >=20
 > > This does not fix the problem since it will now pick up the wrong
 > > postfix version when you install from a complete FTP mirror (see the
 > > CVS log for the commit that added the -2.1 part as to why).
 >=20
 > You're right, I forgot about network installs, sorry.
 >=20
 > > I made the simple attached patch some time ago, I just forgot about it
 > > again since I needed to test that it actually did work as expected
 > > before committing... :-/ - I will try to get around to it soon, unless
 > > somebody else beats me to it.
 >=20
 > I think your patch will be ok, but the problem will present again
 > once we have postfix-2.3 . I'm looking for a more permanent solution
 > but it's not so easy as it would involve some cut'n'paste that I don't
 > absolutely like.
 
 Indeed it would be very nice to fix it "correctly", but as I noted in
 the commit that added the -2.1 part (or was it in the related PR, I
 can't remember) it's non-trivial due to the way the sysinstall package
 handling works.
 
 --=20
 Simon L. Nielsen
 
 --DrWhICOqskFTAXiy
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (FreeBSD)
 
 iD8DBQFCr1EOh9pcDSc1mlERAqk8AKCwGArnFPhAGZa0yAKyJVqfrRULbgCcDUgP
 mm+YxFW9tqMJrYBc2wA4Hhg=
 =Vg8c
 -----END PGP SIGNATURE-----
 
 --DrWhICOqskFTAXiy--

From: Doug White <dwhite@gumbysoft.com>
To: Matteo Riondato <rionda@gufi.org>
Cc: bug-followup@FreeBSD.org, stom@free.fr, re@freebsd.org
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Tue, 14 Jun 2005 18:46:57 -0700 (PDT)

 On Mon, 13 Jun 2005, Matteo Riondato wrote:
 
 > This is a serious bug and should be solved altough we're now in a code
 > freeze, that's why I'm CC'ing re@. A patch for this bug follows
 > (the problem resides in src/usr.sbin/sysinstall/config.c) and
 > should be ok until postfix2 will become postfix3.
 >
 > Please note that this bug is not properly i386 specific.
 >
 > Patch: (can be found at http://www.riondabsd.net/diff/config.c.diff )
 
 Matteo: Can you file a PR for this please? Thanks!
 
 If a committer wants to pick this up: Because we're in freeze you'll need
 to submit a request to re@ before committing.  However I have no
 objections to the patch so approval should be swift :)
 
 >
 > --- config.c.old	Tue Jun  7 23:01:41 2005
 > +++ config.c	Mon Jun 13 23:17:26 2005
 > @@ -990,7 +990,7 @@
 >  	msgError("Error setting the enviroment variable POSTFIX_DEFAULT_MTA: %s (%u)",
 >  		 strerror(errno), errno);
 >
 > -    ret = package_add("postfix-2.1");
 > +    ret = package_add("postfix-2");
 >      unsetenv("POSTFIX_DEFAULT_MTA");
 >
 >      if(DITEM_STATUS(ret) == DITEM_FAILURE) {
 >
 > Best Regards
 >
 
 -- 
 Doug White                    |  FreeBSD: The Power to Serve
 dwhite@gumbysoft.com          |  www.FreeBSD.org

From: Matteo Riondato <rionda@gufi.org>
To: Doug White <dwhite@gumbysoft.com>, bug-followup@FreeBSD.org,
	stom@free.fr, re@freebsd.org
Cc:  
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Wed, 15 Jun 2005 08:00:04 +0200

 On Tue, Jun 14, 2005 at 06:46:57PM -0700, Doug White wrote:
 > On Mon, 13 Jun 2005, Matteo Riondato wrote:
 > 
 > > This is a serious bug and should be solved altough we're now in a code
 > > freeze, that's why I'm CC'ing re@. A patch for this bug follows
 > > (the problem resides in src/usr.sbin/sysinstall/config.c) and
 > > should be ok until postfix2 will become postfix3.
 > >
 > > Please note that this bug is not properly i386 specific.
 > >
 > > Patch: (can be found at http://www.riondabsd.net/diff/config.c.diff )
 > 
 > Matteo: Can you file a PR for this please? Thanks!
 
 This already is a followup to  PR i386/82030. :)
 
 > If a committer wants to pick this up: Because we're in freeze you'll need
 > to submit a request to re@ before committing.  However I have no
 > objections to the patch so approval should be swift :)
 
 Actually Samuel L. Nielsen said that the patch will not solve the
 problem "forever" nor "for some time", because it will install the
 wrong version of postfix during an ftp-install. See the commit message
 for src/usr.sbin/sysinstall/config.c revision 1.224 .
 IMHO Samuel is right: it's not easy to fix this issue, so hardcoding
 the version number is the only solution I can see at the moment.
 Thank you for your attention.
 Best Regards.
 -- 
 Rionda aka Matteo Riondato
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)

From: Matteo Riondato <rionda@gufi.org>
To: "Simon L. Nielsen" <simon@FreeBSD.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: i386/82030: Choosing an alternate default MTA
Date: Wed, 15 Jun 2005 08:04:14 +0200

 On Tue, Jun 14, 2005 at 11:50:07PM +0200, Simon L. Nielsen wrote:
 > > I think your patch will be ok, but the problem will present again
 > > once we have postfix-2.3 . I'm looking for a more permanent solution
 > > but it's not so easy as it would involve some cut'n'paste that I don't
 > > absolutely like.
 > 
 > Indeed it would be very nice to fix it "correctly", but as I noted in
 > the commit that added the -2.1 part (or was it in the related PR, I
 > can't remember) it's non-trivial due to the way the sysinstall package
 > handling works.
 
 Yes, you're right. Having major and minor version numbers harcoded in
 the srcs is a pity, but I cannot see a trivial fix to this.
 I hope your patch will be committed soon, if it work (but it should,
 as is similar to the fix committed in revision 1.224 of
 src/usr.sbin/sysinstall/config.c ). 
 Thank you for your attention.
 Best Regards
 -- 
 Rionda aka Matteo Riondato
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)
Responsible-Changed-From-To: freebsd-i386->simon 
Responsible-Changed-By: simon 
Responsible-Changed-When: Sun Jul 3 21:04:08 GMT 2005 
Responsible-Changed-Why:  
I will get this fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82030 
State-Changed-From-To: open->patched 
State-Changed-By: simon 
State-Changed-When: Sat Jul 30 14:43:05 GMT 2005 
State-Changed-Why:  
This was (hopefully) fixed a while ago in 
src/usr.sbin/sysinstall/config.c v. 1.233.  I will MFC after 6.0-Beta2 
where I should be able to test this fully.  Thanks for the report. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82030 
State-Changed-From-To: patched->closed 
State-Changed-By: matteo 
State-Changed-When: Sat Mar 4 10:03:58 UTC 2006 
State-Changed-Why:  
This was fixed a while ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82030 
>Unformatted:
