From nobody@FreeBSD.org  Tue May 31 16:39:50 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B0C3C16A41C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2005 16:39:50 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8EF0643D1F
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2005 16:39:50 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j4VGdols009209
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 May 2005 16:39:50 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j4VGdoBW009208;
	Tue, 31 May 2005 16:39:50 GMT
	(envelope-from nobody)
Message-Id: <200505311639.j4VGdoBW009208@www.freebsd.org>
Date: Tue, 31 May 2005 16:39:50 GMT
From: Denis Grudkin <denis41@icape.nw.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: A typo in tftpd.c
X-Send-Pr-Version: www-2.3

>Number:         81732
>Category:       bin
>Synopsis:       [patch] typo in tftpd.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 31 16:40:02 GMT 2005
>Closed-Date:    Mon Jun 13 12:20:50 GMT 2005
>Last-Modified:  Mon Jun 13 12:20:50 GMT 2005
>Originator:     Denis Grudkin
>Release:        FreeBSD 5.4-STABLE
>Organization:
ROKSON network
>Environment:
FreeBSD 5.4-STABLE i386
>Description:
tftpd server in FreeBSD 5.4-STABLE has an option -U to specify umask for newly created files. But then I tried to use this option I got segmentaion fault error. As I can see, the problem is in missed colon in getopt call in tftpd.c
Revision of my tftpd.c is 1.34
>How-To-Repeat:
Run tftpd server with -U option set.      
>Fix:
Looks like all we need is to insert missing colon in tftpd.c

$ diff -u /usr/src/libexec/tftpd/tftpd.c ./tftpd.c 
--- /usr/src/libexec/tftpd/tftpd.c	Mon Aug 16 19:45:24 2004
+++ ./tftpd.c	Tue May 31 20:07:42 2005
@@ -135,7 +135,7 @@
 	tzset();			/* syslog in localtime */
 
 	openlog("tftpd", LOG_PID | LOG_NDELAY, LOG_FTP);
-	while ((ch = getopt(argc, argv, "cClns:u:Uw")) != -1) {
+	while ((ch = getopt(argc, argv, "cClns:u:U:w")) != -1) {
 		switch (ch) {
 		case 'c':
 			ipchroot = 1;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Tue May 31 17:23:10 GMT 2005 
State-Changed-Why:  
Fixed in HEAD, thanks! 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue May 31 17:23:10 GMT 2005 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81732 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 13 12:20:27 GMT 2005 
State-Changed-Why:  
Fixed in RELENG_5 as well, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81732 
>Unformatted:
