From karl@Codebase.mcs.net  Thu Sep 24 09:12:28 1998
Received: from Kitten.mcs.com (Kitten.mcs.com [192.160.127.90])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA22380
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 Sep 1998 09:12:27 -0700 (PDT)
          (envelope-from karl@Codebase.mcs.net)
Received: from Codebase.mcs.net (codebase.mcs.net [192.160.127.89]) by Kitten.mcs.com (8.8.7/8.8.2) with ESMTP id LAA06218 for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 Sep 1998 11:12:23 -0500 (CDT)
Received: (from root@localhost) by Codebase.mcs.net (8.8.8/8.8.2) id LAA21705; Thu, 24 Sep 1998 11:12:22 -0500 (CDT)
Message-Id: <199809241612.LAA21705@Codebase.mcs.net>
Date: Thu, 24 Sep 1998 11:12:22 -0500 (CDT)
From: karl@denninger.net
Reply-To: karl@denninger.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: libskey Makefile correction - long, long open problem
X-Send-Pr-Version: 3.2

>Number:         8040
>Category:       bin
>Synopsis:       Makefile has had "-Werror" for a long time, kills "make world"
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 24 09:20:01 PDT 1998
>Closed-Date:    Wed Dec 9 17:44:59 PST 1998
>Last-Modified:  Wed Dec  9 17:45:57 PST 1998
>Originator:     Karl Denninger
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
Karl's Sushi and Packet Smashers
>Environment:

	All -CURRENT extracts for the last year

>Description:

	The Makefile for "libskey" has had the "-Werror" flag for the last
	six to eight months.  There are macros in some of the included files
	which are not used; this generates warnings, and -Werror causes 
	the build to fail

>How-To-Repeat:

	Grab current, type "make world", watch it stop at libskey.

>Fix:

The following patch comments out the "-Werror" for i386 machines.  When the
authors of libskey do a better fix, this can be backed out.

PLEASE COMMIT THIS!  I've been carping about this problem for months.

	
Index: Makefile
===================================================================
RCS file: /usr/cvs/src/lib/libskey/Makefile,v
retrieving revision 1.13
diff -r1.13 Makefile
14,16c14,17
< .if ${MACHINE_ARCH} == "i386"
< CFLAGS+=-Werror
< .endif
---
> CFLAGS+=-W -Wall
> #.if ${MACHINE_ARCH} == "i386"
> #CFLAGS+=-Werror
> #.endif


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Wed Dec 9 17:44:59 PST 1998 
State-Changed-Why:  
Works for me with a -current just hours old.  Check out some more recent 
and see if the problem still exists. 
>Unformatted:
