From nobody@FreeBSD.org  Mon Apr 18 10:30:38 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A364216A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Apr 2005 10:30:38 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8A14243D1D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Apr 2005 10:30:38 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j3IAUbeJ093628
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Apr 2005 10:30:37 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j3IAUbYF093625;
	Mon, 18 Apr 2005 10:30:37 GMT
	(envelope-from nobody)
Message-Id: <200504181030.j3IAUbYF093625@www.freebsd.org>
Date: Mon, 18 Apr 2005 10:30:37 GMT
From: Hans Meyer <ss@matik.com.br>
To: freebsd-gnats-submit@FreeBSD.org
Subject: adduser -f exits silently if file has empty line or line starting with #
X-Send-Pr-Version: www-2.3

>Number:         80058
>Category:       bin
>Synopsis:       adduser -f exits silently if file has empty line or line starting with #
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 18 10:40:16 GMT 2005
>Closed-Date:    Thu May 29 12:52:14 UTC 2008
>Last-Modified:  Thu May 29 12:52:14 UTC 2008
>Originator:     Hans Meyer
>Release:        5.3-R
>Organization:
Infomatik
>Environment:
FreeBSD msrv.matik.com.br 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Sun Feb 13 01:35:32 BRST 2005     hmm@msrw.matik.com.br:/usr/src/sys/i386/compile/msrv  i386
>Description:
adduser -f file exits without any advice or error when the named file has an empty line or a line starting with # without adding any user

manpage tells in the FORMAT section:
All empty lines or lines beginning with a `#' will be ignored.

file example
_emptyline_
usr1::nobody:::::::password1
usr2::nobody:::::::password2
EOF

adduser.conf
defaultLgroup=nobody
defaultclass=
defaultgroups=
passwdtype=yes
homeprefix=/home
defaultshell=/bin/sh
udotdir=/usr/share/skel
msgfile=/etc/mail/bemvindo_novusr
disableflag=

>How-To-Repeat:
executing adduser -f file
>Fix:
      eliminating empty lines
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: robert 
State-Changed-When: Thu Apr 28 15:38:59 GMT 2005 
State-Changed-Why:  
A fix has been committed to -CURRENT. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80058 

From: Matteo Riondato <matteo@freebsd.org>
To: bug-followup@FreeBSD.org, robert@freebsd.org
Cc:  
Subject: Re: bin/80058: adduser -f exits silently if file has empty line or line starting with #
Date: Sat, 30 Jul 2005 16:29:13 +0200

 This change was never merged to RELENG_5. Can you please take care of
 this?
 Thanks.
 Best Regards
 -- 
 Matteo Riondato
 FreeBSD Volunteer (http://freebsd.org)
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)

Adding to audit trail from misfiled PR bin/115047:

Date: Mon, 30 Jul 2007 17:03:45 +0100
From: Gavin Atkinson <gavin@FreeBSD.org>

 The originally committed code in 1.26 was wrong, so this still needs an
 MFC to both 6.x and 5.x of src/usr.sbin/adduser/adduser.sh 1.29.
State-Changed-From-To: patched->closed 
State-Changed-By: mtm 
State-Changed-When: Sun Jan 27 08:21:35 UTC 2008 
State-Changed-Why:  
The incorrect patch was fixed in rev. 1.29 on 2007/04/12 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80058 
State-Changed-From-To: closed->patched 
State-Changed-By: gavin 
State-Changed-When: Thu May 29 12:43:14 UTC 2008 
State-Changed-Why:  
Reopen, this still requires an MFC of src/usr.sbin/adduser/adduser.sh 1.29 
to RELENG_6 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80058 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Thu May 29 12:50:25 UTC 2008 
State-Changed-Why:  
Close again, this was actually fixed in 1.26.2.3, but cvsweb doesn't 
show that revision. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80058 
>Unformatted:
