From dougdougdougdoug@dt053nb4.san.rr.com  Fri Sep 18 12:50:56 1998
Received: from dt053nb4.san.rr.com (dt053nb4.san.rr.com [204.210.34.180])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA17486
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 18 Sep 1998 12:50:53 -0700 (PDT)
          (envelope-from dougdougdougdoug@dt053nb4.san.rr.com)
Received: (from root@localhost)
	by dt053nb4.san.rr.com (8.8.8/8.8.8) id MAA01993;
	Fri, 18 Sep 1998 12:50:28 -0700 (PDT)
	(envelope-from dougdougdougdoug)
Message-Id: <199809181950.MAA01993@dt053nb4.san.rr.com>
Date: Fri, 18 Sep 1998 12:50:28 -0700 (PDT)
From: Studded@dal.net
Reply-To: Studded@dal.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: Problems in -Stable login.c
X-Send-Pr-Version: 3.2

>Number:         7979
>Category:       bin
>Synopsis:       Typo and one odd thing in -Stable login.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 18 13:00:00 PDT 1998
>Closed-Date:    Sat Jan 2 12:26:55 PST 1999
>Last-Modified:  Sat Jan  2 12:27:44 PST 1999
>Originator:     Doug
>Release:        FreeBSD 2.2.7-STABLE-0918 i386
>Organization:
AAAG
>Environment:

	-Stable system

>Description:

	There is a typo in login.c,v 1.12.2.12, the most recent -Stable version
(approvp for approvep). Also, a change from -Current re AUTH_NONE (which isn't
defined in any include file which is included in login.c) was not included. 

>How-To-Repeat:

	DNA

>Fix:
	
	Apply the following patch.

diff -u -r1.12.2.12 -r1.38
--- login.c     1998/08/31 03:27:28     1.12.2.12
+++ login.c     1998/08/17 03:25:07     1.38
@@ -409,7 +414,7 @@
                }
 
                if (!rval) {
-                       char * approvp;
+                       char * approvep;
                    
                        /*
                         * If authentication succeeds, run any approval
@@ -427,7 +432,7 @@
                                /*
                                 * See what the authorize program says
                                 */
-                               if (r != AUTH_NONE) {
+                               if (r != 0) {
                                        rval = 0;
 
                                        if (!rootok && (r & AUTH_ROOTOKAY))

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: billf 
State-Changed-When: Sat Jan 2 12:26:55 PST 1999 
State-Changed-Why:  
Updated in rev 1.12.2.13 to src/usr.bin/login/login.c 
Sat Jan 2 20:24:58 1999 UTC by billf (RELENG_2_2) 
>Unformatted:
