From nobody@FreeBSD.org  Fri Mar 25 16:10:19 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A8DC16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Mar 2005 16:10:19 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1193843D41
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Mar 2005 16:10:19 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2PGAIGE048838
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Mar 2005 16:10:18 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j2PGAIKt048837;
	Fri, 25 Mar 2005 16:10:18 GMT
	(envelope-from nobody)
Message-Id: <200503251610.j2PGAIKt048837@www.freebsd.org>
Date: Fri, 25 Mar 2005 16:10:18 GMT
From: RIck van der Zwet <rick@wzoeterwoude.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Wrong Makefile path at /usr/src/sbin/ifconfig/Makefile
X-Send-Pr-Version: www-2.3

>Number:         79229
>Category:       bin
>Synopsis:       Wrong Makefile path at /usr/src/sbin/ifconfig/Makefile
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    brooks
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 25 16:20:02 GMT 2005
>Closed-Date:    Sun Aug 21 00:44:35 GMT 2005
>Last-Modified:  Sun Aug 21 00:44:35 GMT 2005
>Originator:     RIck van der Zwet
>Release:        FreeBSD 5.3-STABLE
>Organization:
Stichting Wireless Leiden
>Environment:
FreeBSD rickzoekt.wzoeterwoude.net 5.3-STABLE FreeBSD 5.3-STABLE #0: Thu Mar 17 15:54:51 CET 2005     rick@rickzoekt.wzoeterwoude.net:/usr/src/sys/i386/compile/RICKZOEKT  i386
>Description:

>How-To-Repeat:
cd /usr/src/sbin/ifconfig
make 
>Fix:
--- Makefile.old        Fri Mar 25 16:20:57 2005
+++ Makefile    Fri Mar 25 16:21:07 2005
@@ -41,7 +41,7 @@
 .endif

 CFLAGS+=-DNS -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings \
-       -Wnested-externs -I..
+       -Wnested-externs -I${.CURDIR}/../../sys
 WARNS?=        0

 .include <bsd.prog.mk>
>Release-Note:
>Audit-Trail:

From: Brooks Davis <brooks@one-eyed-alien.net>
To: RIck van der Zwet <rick@wzoeterwoude.net>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/79229: Wrong Makefile path at /usr/src/sbin/ifconfig/Makefile
Date: Fri, 25 Mar 2005 09:40:08 -0800

 We don't typically add refrences to the sys source prefering to pick up
 the system headers or to force the include paths elsewhere when doing a
 system upgrade.  The -I.. seems bogus, but I don't see any need to add
 the -I${.CURDIR}/../../sys refrence.
 
 -- Brooks
State-Changed-From-To: open->patched 
State-Changed-By: vs 
State-Changed-When: Fri Apr 8 14:37:11 GMT 2005 
State-Changed-Why:  
Brooks solved this in a different way in -HEAD; MFC due 


Responsible-Changed-From-To: freebsd-bugs->brooks 
Responsible-Changed-By: vs 
Responsible-Changed-When: Fri Apr 8 14:37:11 GMT 2005 
Responsible-Changed-Why:  
Brooks solved this in a different way in -HEAD; MFC due 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79229 
State-Changed-From-To: patched->closed 
State-Changed-By: brooks 
State-Changed-When: Sun Aug 21 00:43:34 GMT 2005 
State-Changed-Why:  
Merged to RELENG_5.  I don't see any point in merging to RELENG_4. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79229 
>Unformatted:
