From b.candler@pobox.com  Thu Feb  3 15:41:14 2005
Return-Path: <b.candler@pobox.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5FA0E16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Feb 2005 15:41:14 +0000 (GMT)
Received: from orb.pobox.com (orb.pobox.com [207.8.226.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 59AC943D53
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Feb 2005 15:41:12 +0000 (GMT)
	(envelope-from b.candler@pobox.com)
Received: from orb (localhost [127.0.0.1])
	by orb.pobox.com (Postfix) with ESMTP id 4A9F38F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Feb 2005 10:41:11 -0500 (EST)
Received: from billdog.local.linnet.org (dsl-80-44-135-135.access.as9105.com [80.44.135.135])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by orb.sasl.smtp.pobox.com (Postfix) with ESMTP id 1A99C8A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Feb 2005 10:41:11 -0500 (EST)
Received: from brian by billdog.local.linnet.org with local (Exim 4.43 (FreeBSD))
	id 1Cwj8F-0000MS-TP
	for FreeBSD-gnats-submit@freebsd.org; Thu, 03 Feb 2005 15:42:59 +0000
Message-Id: <E1Cwj8F-0000MS-TP@billdog.local.linnet.org>
Date: Thu, 03 Feb 2005 15:42:59 +0000
From: Brian Candler <B.Candler@pobox.com>
Reply-To: Brian Candler <B.Candler@pobox.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: /bin/sh premature termination when 'set -e' is active
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         77067
>Category:       bin
>Synopsis:       /bin/sh premature termination when 'set -e' is active
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    stefanf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 03 15:50:16 GMT 2005
>Closed-Date:    Mon Dec 26 18:17:41 GMT 2005
>Last-Modified:  Mon Dec 26 18:17:41 GMT 2005
>Originator:     Brian Candler
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD billdog.local.linnet.org 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Dec 27 12:24:34 GMT 2004 root@billdog.local.linnet.org:/usr/obj/usr/src/sys/BILLDOG i386


	
>Description:

Under certain circumstances, 'set -e' causes /bin/sh to exit when it should
not. From the manpage:

     -e errexit
             Exit immediately if any untested command fails in non-interactive
             mode.  The exit status of a command is considered to be explic-
             itly tested if the command is used to control an if, elif, while,
             or until; or if the command is the left hand operand of an `&&''
             or `||'' operator.

However, there are circumstances where even when a command status is
explicitly tested the script still terminates. I can replicate this using a
function call.

>How-To-Repeat:

This script demonstrates the problem:

------------------------------------------------------------
#!/bin/sh

set -e

foo ( ) {
  if test "x$1" != "xyes"; then
    return 1
  fi
  echo "OK!"   # this line causes the problem!
}

if foo yes; then echo "yes"; fi
if foo no; then echo "no"; fi
echo "Completed!"
------------------------------------------------------------

It fails to complete. However, if you remove the 'echo "OK!"' line it *does*
complete. (This line can be anything - for example, replacing it with
"return 0" also causes the problem).

The script runs correctly under 'bash', so I don't think my understanding of
-e semantics is broken.

>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->stefanf 
Responsible-Changed-By: stefanf 
Responsible-Changed-When: Sun Sep 4 19:34:03 GMT 2005 
Responsible-Changed-Why:  
Over to me. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77067 
State-Changed-From-To: open->patched 
State-Changed-By: stefanf 
State-Changed-When: Sat Sep 10 08:40:33 GMT 2005 
State-Changed-Why:  
Fixed in -current, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77067 
State-Changed-From-To: patched->closed 
State-Changed-By: stefanf 
State-Changed-When: Mon Dec 26 18:17:21 UTC 2005 
State-Changed-Why:  
Also fixed in RELENG_{5,6}. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77067 
>Unformatted:
