From nobody@FreeBSD.org  Wed Feb  2 18:48:56 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9F2A716A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Feb 2005 18:48:56 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8009743D3F
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Feb 2005 18:48:56 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j12ImuXc060953
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Feb 2005 18:48:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j12Imun5060952;
	Wed, 2 Feb 2005 18:48:56 GMT
	(envelope-from nobody)
Message-Id: <200502021848.j12Imun5060952@www.freebsd.org>
Date: Wed, 2 Feb 2005 18:48:56 GMT
From: fergus cameron <fergus@cameron-consulting.ie>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
X-Send-Pr-Version: www-2.3

>Number:         77031
>Category:       bin
>Synopsis:       [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 02 18:50:22 GMT 2005
>Closed-Date:    Sat Sep 04 07:54:18 UTC 2010
>Last-Modified:  Sat Sep 04 07:54:18 UTC 2010
>Originator:     fergus cameron
>Release:        FreeBSD rabbit.cobbled.net 5.3-STABLE FreeBSD 5.3-STABLE #3: Tue Dec  7 20:41:00 GMT 2004     root@rabbit.cobbled.net:/usr/cabinet/software/binary/FreeBSD/build/usr/cabinet/software/source/FreeBSD/RELENG_5/sys/RABBIT  i386
>Organization:
cameron-consulting.ie
>Environment:
FreeBSD rabbit.cobbled.net 5.3-STABLE FreeBSD 5.3-STABLE #3: Tue Dec  7 20:41:00 GMT 2004 root@rabbit.cobbled.net:/usr/cabinet/software/binary/FreeBSD/build/usr/cabinet/software/source/FreeBSD/RELENG_5/sys/RABBIT i386
>Description:
      comm(1) utility will incorrectly handle lines longer than 2048 characters.
>How-To-Repeat:
      create test files with lines of greater length than 2048 and run the utility against them.  note that due to the way lines are processed it 'appears' to work, however comparisons and line ouputs are incorrect.
>Fix:
      patch at

ftp://ftp.cameron-consulting.ie/comm.c-diff

anon access via "ftp@cameron-consulting.ie" user name

this is a large patch (for the size of the problem) and equates to almost a complete re-write of the utility.  the case insensitive option still needs re-implemented.

let me know of issues with the code and or style as it has changed greatly to suit personal (in-experienced) coding style.
>Release-Note:
>Audit-Trail:

From: Fergus Cameron <fergus@cobbled.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
Date: Thu, 3 Feb 2005 03:20:24 +0000

 patches have moved to
 
 	ftp://ftp.cameron-consulting.ie/code/freebsd/usr.bin/comm/comm.c-diff.1
 
 for the initial patch.  and
 
 	ftp://ftp.cameron-consulting.ie/code/freebsd/usr.bin/comm/comm.c-diff.2
 
 for the second patch implementing case option.
 
 both of these patches are against version
 
    __FBSDID("$FreeBSD: src/usr.bin/comm/comm.c,v 1.21 2004/07/02 \
 			22:48:29 tjr Exp $");
 
 of comm.c
 
 -- 
 : fergus cameron                : -cameron------------ :
 : ^^^^^^@cameron-consulting.ie  : ---------consulting- :
 :                               :                      :
 :                               :       Knock, Inverin :
 : tel: +353  91593373           :           Co. Galway :
 : mob: +353 851404269           :              Ireland :

From: fergus <fergus@cobbled.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
Date: Thu, 3 Feb 2005 10:33:23 +0000

 dogs breakfast anyone?
 
 here's another patch that adds the '-i' option back into the usage message.
 
 	ftp://ftp.cameron-consulting.ie/code/freebsd/comm/comm.c-diff.3
 
 it may even be in the correct format (looks more like other peoples patches).
 
 -- 
 : fergus cameron                :   [ .]        cobbled    :
 : ^^^^^^@cobbled.net            : [ ~][ ]             .net :

From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: fergus <fergus@cobbled.net>
Cc: bug-followup@freebsd.org
Subject: Re: bin/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
Date: Thu, 3 Feb 2005 12:52:33 +0200

 On 2005-02-03 10:40, fergus <fergus@cobbled.net> wrote:
 > here's another patch that adds the '-i' option back into the usage message.
 >
 > 	ftp://ftp.cameron-consulting.ie/code/freebsd/comm/comm.c-diff.3
 >
 > it may even be in the correct format (looks more like other peoples patches).
 
 It would be nice if it were accessible too :-(
 
 # % ftp ftp://ftp.cameron-consulting.ie/code/freebsd/comm/
 # Connected to ftp.cameron-consulting.ie.
 # 220-This computer system is for authorized users only. Individuals using this
 #  system without authority or in excess of their authority are subject to
 #  having all their activities on this system monitored and recorded or
 #  examined by any authorized person, including law enforcement, as system
 #  personnel deem appropriate. In the course of monitoring individuals
 #  improperly using the system or in the course of system maintenance, the
 #  activities of authorized users may also be monitored and recorded. Any
 #  material so recorded may be disclosed as appropriate. Anyone using this
 #  system consents to these terms.
 #
 #
 # 220 ProFTPD 1.2.10 Server (ProFTPD) [66.220.25.27]
 # 331 Anonymous login ok, send your complete email address as your password.
 # 530-Unable to set anonymous privileges.
 # 530 Login incorrect.
 # ftp: Login failed.
 # ftp: Can't connect or login to host `ftp.cameron-consulting.ie'
 # 221 Goodbye.
 # %
 

From: Fergus Cameron <fergus@cobbled.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
Date: Fri, 4 Feb 2005 09:22:32 +0000

 thanks to giorgos keramidas for posting the patch in a
 'hoop free' manner ;-)
 
 	http://people.freebsd.org/~keramida/fergus/comm.c-diff
 
 thank giorgos.
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Sun Dec 13 09:40:05 UTC 2009 
State-Changed-Why:  
Fixed by r179374 and MFC to stable/7 done as r181937. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77031 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Sat Sep 4 07:54:16 UTC 2010 
State-Changed-Why:  
Fixed in head, stable/8 and stable/7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77031 
>Unformatted:
