From nobody@FreeBSD.org  Wed Jan 12 16:25:28 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3E7C316A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jan 2005 16:25:28 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 26F9943D2F
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jan 2005 16:25:28 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j0CGPSHG004004
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Jan 2005 16:25:28 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j0CGPR7A003994;
	Wed, 12 Jan 2005 16:25:27 GMT
	(envelope-from nobody)
Message-Id: <200501121625.j0CGPR7A003994@www.freebsd.org>
Date: Wed, 12 Jan 2005 16:25:27 GMT
From: Jeffrey Katcher <jmkatcher@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Significant memory leak in libfetch (fix enclosed)
X-Send-Pr-Version: www-2.3

>Number:         76153
>Category:       bin
>Synopsis:       Significant memory leak in libfetch (fix enclosed)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 12 16:30:28 GMT 2005
>Closed-Date:    Sun Jul 31 12:10:22 GMT 2005
>Last-Modified:  Sun Jul 31 12:10:22 GMT 2005
>Originator:     Jeffrey Katcher
>Release:        5.3-STABLE
>Organization:
>Environment:
FreeBSD mammon.comcast.net 5.3-STABLE FreeBSD 5.3-STABLE #4: Fri Jan  7 14:02:42 PST 2005     katcher@mammon.comcast.net:/usr/src/sys/i386/compile/MAMMON  i386

>Description:
I was debugging a program with a libfetch back end under valgrind and found that libfetch was leaking about 1K/connection.  My program uses a lot of individual connections so growth was noticable during a long run.
>How-To-Repeat:
Run any libfetch linked binary under valgrind
>Fix:
It's an easy fix:
Conn is the connection structure, and though every conn is freed, the fact that conn has a malloced field is ignored.  The fix is simply to check for the existence of this field and freeing it immediately before freeing conn itself.  

Patch follows:
*** common.c.orig       Tue Jan 11 18:44:03 2005
--- common.c    Tue Jan 11 18:44:14 2005
***************
*** 605,610 ****
--- 605,615 ----
        if (--conn->ref > 0)
                return (0);
        ret = close(conn->sd);
+ 
+       if (conn->bufsize) {
+               free(conn->buf);
+       }
+ 
        free(conn);
        return (ret);
  }

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: brian 
Responsible-Changed-When: Wed Jan 12 16:42:36 GMT 2005 
Responsible-Changed-Why:  
Assign to des - this definitely looks good to me!! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76153 
State-Changed-From-To: open->patched 
State-Changed-By: des 
State-Changed-When: Wed Feb 16 12:50:40 GMT 2005 
State-Changed-Why:  
Fixed in -CURRENT, awaiting MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76153 
State-Changed-From-To: patched->closed 
State-Changed-By: matteo 
State-Changed-When: Sun Jul 31 12:10:07 GMT 2005 
State-Changed-Why:  
Fixed and MFCed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76153 
>Unformatted:
