From nobody@FreeBSD.org  Sat Jan  8 15:56:25 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 59A2E16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Jan 2005 15:56:25 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4760943D1F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  8 Jan 2005 15:56:25 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j08FuOqM090865
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 8 Jan 2005 15:56:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j08FuOfm090864;
	Sat, 8 Jan 2005 15:56:24 GMT
	(envelope-from nobody)
Message-Id: <200501081556.j08FuOfm090864@www.freebsd.org>
Date: Sat, 8 Jan 2005 15:56:24 GMT
From: Finn <zero@gddn.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: cosmetic typo in /etc/rc.subr: check_pidfile()
X-Send-Pr-Version: www-2.3

>Number:         75946
>Category:       bin
>Synopsis:       cosmetic typo in /etc/rc.subr: check_pidfile()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    keramida
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 08 16:00:52 GMT 2005
>Closed-Date:    Mon Jan 17 11:53:55 GMT 2005
>Last-Modified:  Mon Jan 17 11:53:55 GMT 2005
>Originator:     Finn
>Release:        CURRENT RELENG_5 RELENG_5_3
>Organization:
>Environment:
>Description:
In /etc/rc.subr there is a '(' vs. '{' typo in the function check_pidfile() line 206. Since it appears in a debug message in 
double quotes, it has no effect on functionality.

>How-To-Repeat:

>Fix:
--- etc/rc.subr,~
+++ etc/rc.subr
@@ -192,19 +192,19 @@
 check_pidfile()
 {
 	_pidfile=$1
 	_procname=$2
 	_interpreter=$3
 	if [ -z "$_pidfile" -o -z "$_procname" ]; then
 		err 3 'USAGE: check_pidfile pidfile procname [interpreter]'
 	fi
 	if [ ! -f $_pidfile ]; then
 		debug "pid file ($_pidfile): not readable."
 		return
 	fi
 	read _pid _junk < $_pidfile
 	if [ -z "$_pid" ]; then
-		debug "pid file {$_pidfile): no pid in file."
+		debug "pid file ($_pidfile): no pid in file."
 		return
 	fi
 	_find_processes $_procname ${_interpreter:-.} '-p '"$_pid"
 }

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: keramida 
State-Changed-When: Sun Jan 9 23:46:55 GMT 2005 
State-Changed-Why:  
Committed, thanks. 


Responsible-Changed-From-To: freebsd-bugs->keramida 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Sun Jan 9 23:46:55 GMT 2005 
Responsible-Changed-Why:  
I'll MFC this in a few days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75946 
State-Changed-From-To: patched->closed 
State-Changed-By: keramida 
State-Changed-When: Mon Jan 17 11:53:35 GMT 2005 
State-Changed-Why:  
Committed to RELENG_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75946 
>Unformatted:
