From clkao@CirX.ORG  Fri Aug  7 07:56:08 1998
Received: from CirX.ORG (Joller.m6.ntu.edu.tw [140.112.247.129])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA17491
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 7 Aug 1998 07:55:56 -0700 (PDT)
          (envelope-from clkao@CirX.ORG)
Received: (from root@localhost)
	by CirX.ORG (8.8.8/8.8.8) id XAA07463;
	Fri, 7 Aug 1998 23:01:24 GMT
	(envelope-from clkao)
Message-Id: <199808072301.XAA07463@CirX.ORG>
Date: Fri, 7 Aug 1998 23:01:24 GMT
From: clkao@CirX.ORG
Reply-To: clkao@CirX.ORG
To: FreeBSD-gnats-submit@freebsd.org
Subject: finger(1) i18n support broken
X-Send-Pr-Version: 3.2

>Number:         7519
>Category:       bin
>Synopsis:       finger(1) i18n support broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug  7 08:00:01 PDT 1998
>Closed-Date:    Fri Aug 7 09:22:34 PDT 1998
>Last-Modified:  Tue Nov 27 19:25:51 PST 2001
>Originator:     Chia-liang Kao
>Release:        FreeBSD 2.2.7-STABLE i386
>Organization:
CirX
>Environment:

FreeBSD genius.cirx.org 2.2.7-STABLE FreeBSD 2.2.7-STABLE #0: Sat Aug  1 14:28:41 GMT 1998     clkao@genius.cirx.org:/usr/local/src-2.2/sys/compile/GENIUS  i386

>Description:

the function vputc, which is determining if a charater is printable(by isprint)
is taking int parameter, while isprint only works properly with unsigned char
(or int). I haven't taken a look if vputc should take int or char.

also, the following patch kills a warning in -Wall

>How-To-Repeat:

>Fix:
	
--- lprint.c.orig	Fri Aug  7 22:53:46 1998
+++ lprint.c	Fri Aug  7 22:59:35 1998
@@ -297,7 +297,7 @@
 	struct stat sb;
 	register FILE *fp;
 	register int ch, cnt, lastc;
-	register char *p;
+	register u_char *p;
 	int fd, nr;
 
 	(void)snprintf(tbuf, sizeof(tbuf), "%s/%s", directory, file_name);
@@ -353,7 +353,7 @@
 		meta = 1;
 	} else
 		meta = 0;
-	if (isprint(ch) || !meta && (ch == ' ' || ch == '\t' || ch == '\n'))
+	if (isprint(ch) || (!meta && (ch == ' ' || ch == '\t' || ch == '\n')))
 		(void)putchar(ch);
 	else {
 		(void)putchar('^');
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ache 
State-Changed-When: Fri Aug 7 09:22:34 PDT 1998 
State-Changed-Why:  
fixed differently in lprint.c v1.9 
>Unformatted:
