From nobody@FreeBSD.org  Fri Nov 26 10:52:30 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 39DFB16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Nov 2004 10:52:30 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2A01D43D2D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Nov 2004 10:52:30 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iAQAqUgs066872
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Nov 2004 10:52:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iAQAqTYd066871;
	Fri, 26 Nov 2004 10:52:29 GMT
	(envelope-from nobody)
Message-Id: <200411261052.iAQAqTYd066871@www.freebsd.org>
Date: Fri, 26 Nov 2004 10:52:29 GMT
From: Michael Bax <bax3@bigfoot.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysinstall accepts but discards media options for DHCP network setup
X-Send-Pr-Version: www-2.3

>Number:         74406
>Category:       bin
>Synopsis:       [sysinstall] sysinstall accepts but discards media options for DHCP network setup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ceri
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 26 11:00:46 GMT 2004
>Closed-Date:    Tue Jan 24 18:45:01 GMT 2006
>Last-Modified:  Tue Jan 24 18:45:01 GMT 2006
>Originator:     Michael Bax
>Release:        5.3-RELEASE
>Organization:
>Environment:
FreeBSD igl-hp1.stanford.edu 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov  5 04:19:18 UTC 2004     root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
      /sbin/sysinstall allows the option of using DHCP to configure a
network interface.  The following dialog provides a field for additional
options such as media or mediaopt.  If DHCP has been chosen, however,
these options are silently discarded and are not saved to /etc/rc.conf.
>How-To-Repeat:
      See description.
>Fix:
      
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->freebsd-qa 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Apr 12 00:32:09 GMT 2005 
Responsible-Changed-Why:  
Over to sysinstall maintainers. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 
Responsible-Changed-From-To: freebsd-qa->ceri 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Thu Dec 29 22:48:03 UTC 2005 
Responsible-Changed-Why:  
I'll deal with this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 

From: Ceri Davies <ceri@FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: bin/74406: [sysinstall] sysinstall accepts but discards media options for DHCP network setup
Date: Thu, 29 Dec 2005 22:51:04 +0000

 The attached patch should deal with this PR.  Testing is pending on the
 download of a snapshot yet.
 
 Index: tcpip.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/tcpip.c,v
 retrieving revision 1.132
 diff -u -r1.132 tcpip.c
 --- tcpip.c	11 Jul 2005 03:57:04 -0000	1.132
 +++ tcpip.c	29 Dec 2005 22:47:57 -0000
 @@ -597,7 +597,7 @@
  	if (ipv4_enable) {
  	    sprintf(ifn, "%s%s", VAR_IFCONFIG, devp->name);
  	    if (use_dhcp)
 -		sprintf(temp, "DHCP");
 +		sprintf(temp, "DHCP %s", extras);
  	    else
  		sprintf(temp, "inet %s %s netmask %s",
  			ipaddr, extras, netmask);
 

From: Ceri Davies <ceri@submonkey.net>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: bin/74406: [sysinstall] sysinstall accepts but discards media options for DHCP network setup
Date: Fri, 30 Dec 2005 13:50:22 +0000

 The patch quoted above is correct.
 
State-Changed-From-To: open->patched 
State-Changed-By: ceri 
State-Changed-When: Sun Jan 15 22:58:15 UTC 2006 
State-Changed-Why:  
Patched in -HEAD, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 
State-Changed-From-To: patched->closed 
State-Changed-By: ceri 
State-Changed-When: Mon Jan 23 14:08:23 UTC 2006 
State-Changed-Why:  
Pulled back to RELENG5 and 6 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 
State-Changed-From-To: closed->patched 
State-Changed-By: ceri 
State-Changed-When: Mon Jan 23 14:17:43 UTC 2006 
State-Changed-Why:  
Whoops, this hasn't gone to RELENG_5 yet. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 
State-Changed-From-To: patched->closed 
State-Changed-By: ceri 
State-Changed-When: Tue Jan 24 18:44:17 UTC 2006 
State-Changed-Why:  
Does not apply to RELENG_5 (or at least, the fix would be more intrusive 
than an EOL'd branch deserves). 

Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74406 
>Unformatted:
