From root@mail.alpha-tierchen.de  Tue Nov 23 05:47:30 2004
Return-Path: <root@mail.alpha-tierchen.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0084916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Nov 2004 05:47:30 +0000 (GMT)
Received: from mail.efacilitas.de (efacilitas.de [213.133.110.227])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2A0C043D58
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Nov 2004 05:47:27 +0000 (GMT)
	(envelope-from root@mail.alpha-tierchen.de)
Received: from mail.alpha-tierchen.de (port-212-202-169-228.dynamic.qsc.de [212.202.169.228])
	by mail.efacilitas.de (Postfix) with ESMTP id E7D18123961
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Nov 2004 06:45:48 +0100 (CET)
Received: from localhost (localhost.local [127.0.0.1])
	by mail.alpha-tierchen.de (Postfix) with ESMTP id 02008624D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Nov 2004 06:47:19 +0100 (CET)
Received: from mail.alpha-tierchen.de ([127.0.0.1])
 by localhost (mail.efacilitas.de [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 56413-08 for <FreeBSD-gnats-submit@freebsd.org>;
 Tue, 23 Nov 2004 06:47:17 +0100 (CET)
Received: by mail.alpha-tierchen.de (Postfix, from userid 0)
	id 0532C623C; Tue, 23 Nov 2004 06:47:16 +0100 (CET)
Message-Id: <20041123054716.0532C623C@mail.alpha-tierchen.de>
Date: Tue, 23 Nov 2004 06:47:16 +0100 (CET)
From: Bjrn Knig <bkoenig@cs.tu-berlin.de>
Reply-To: Bjrn Knig <bkoenig@cs.tu-berlin.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: leading zero for tcsh's %P prompt 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         74282
>Category:       bin
>Synopsis:       [patch] leading zero for tcsh's %P prompt
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 23 05:50:12 GMT 2004
>Closed-Date:    Sat Jun 18 21:49:08 GMT 2005
>Last-Modified:  Sat Jun 18 21:49:08 GMT 2005
>Originator:     Bjrn Knig
>Release:        not relevant
>Organization:
>Environment:
not relevant
>Description:
If you use %P in tcsh's prompt you may get a time format "1:44:39".
"01:44:39" looks more proper to me.
>How-To-Repeat:
for example:
set prompt = "%P %#"
>Fix:
--- src/contrib/tcsh/tc.prompt.c.orig   Sun Jul 11 04:17:51 2004
+++ src/contrib/tcsh/tc.prompt.c        Tue Nov 23 06:35:42 2004
@@ -271,7 +271,7 @@ tprintf(what, buf, fmt, siz, str, tim, i
                        what != FMT_PROMPT || adrof(STRnoding)) {
                        if (t->tm_min)
                            print_prompt_did_ding = 0;
-                       p = Itoa(hr, p, 0, attributes);
+                       p = Itoa(hr, p, 2, attributes);
                        *p++ = attributes | ':';
                        p = Itoa(t->tm_min, p, 2, attributes);
                        if (*cp == 'p' || *cp == 'P') {
>Release-Note:
>Audit-Trail:

From: Giorgos Keramidas <keramida@freebsd.org>
To: =?iso-8859-7?Q?Bj=F6rn_K=F6nig?= <bkoenig@cs.tu-berlin.de>
Cc: bug-followup@freebsd.org
Subject: Re: bin/74282: leading zero for tcsh's %P prompt
Date: Tue, 23 Nov 2004 18:25:23 +0200

 On 2004-11-23 06:47, Bjrn Knig <bkoenig@cs.tu-berlin.de> wrote:
 > If you use %P in tcsh's prompt you may get a time format "1:44:39".
 > "01:44:39" looks more proper to me.
 
 > for example:
 > set prompt = "%P %#"
 
 > >Fix:
 > --- src/contrib/tcsh/tc.prompt.c.orig   Sun Jul 11 04:17:51 2004
 > +++ src/contrib/tcsh/tc.prompt.c        Tue Nov 23 06:35:42 2004
 > @@ -271,7 +271,7 @@ tprintf(what, buf, fmt, siz, str, tim, i
 >                         what != FMT_PROMPT || adrof(STRnoding)) {
 >                         if (t->tm_min)
 >                             print_prompt_did_ding = 0;
 > -                       p = Itoa(hr, p, 0, attributes);
 > +                       p = Itoa(hr, p, 2, attributes);
 >                         *p++ = attributes | ':';
 >                         p = Itoa(t->tm_min, p, 2, attributes);
 >                         if (*cp == 'p' || *cp == 'P') {
 
 The tcsh shell is maintained outside of the FreeBSD source tree by Christos
 Zoylas and other people -- who are very helpful and reasonably responsive
 to useful submissions.
 
 Can you post the diff to the maintainers of tcsh?  This way, if it's
 incorporated into their source tree we can pull the change back in FreeBSD's
 source without messing up the import of tcsh :-)
 
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Mon Nov 29 09:12:06 GMT 2004 
State-Changed-Why:  
Note that submitter has been asked for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74282 

From: =?ISO-8859-1?Q?Bj=F6rn_K=F6nig?= <bkoenig@cs.tu-berlin.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/74282: [patch] leading zero for tcsh's %P prompt
Date: Sat, 18 Jun 2005 23:20:18 +0200

 Please close this PR. The developers of tcsh didn't respond to my request.
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jun 18 21:48:42 GMT 2005 
State-Changed-Why:  
Closed at submitter's request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74282 
>Unformatted:
