From Nehal@shaw.ca  Tue Nov  9 00:41:44 2004
Return-Path: <Nehal@shaw.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0BC8716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Nov 2004 00:41:44 +0000 (GMT)
Received: from shaw.ca (S0106000ae6ceb225.vf.shawcable.net [70.68.12.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9FA6A43D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Nov 2004 00:41:41 +0000 (GMT)
	(envelope-from Nehal@shaw.ca)
Received: from Nehal.Home (somebody@localhost [127.0.0.1])
	by shaw.ca (8.13.1/8.13.1) with ESMTP id iA90fsqh001340
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 8 Nov 2004 16:41:54 -0800 (PST)
	(envelope-from Nehal@Nehal.Home)
Received: (from Nehal@localhost)
	by Nehal.Home (8.13.1/8.13.1/Submit) id iA90fsSh001339;
	Mon, 8 Nov 2004 16:41:54 -0800 (PST)
	(envelope-from Nehal)
Message-Id: <200411090041.iA90fsSh001339@Nehal.Home>
Date: Mon, 8 Nov 2004 16:41:54 -0800 (PST)
From: Nehal <nehalmistry@gmx.net>
Reply-To: Nehal <nehalmistry@gmx.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: exiting sysinstall appends text to rc.conf
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         73692
>Category:       bin
>Synopsis:       [sysinstall] exiting sysinstall appends text to rc.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    simon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 09 00:50:32 GMT 2004
>Closed-Date:    Thu Nov 25 22:55:37 GMT 2004
>Last-Modified:  Thu Nov 25 22:55:37 GMT 2004
>Originator:     Nehal Mistry
>Release:        FreeBSD 5.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD Nehal.Home 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov 5 04:19:18 UTC 2004 root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
every time i start and exit sysinstall, the following text 
is appended to /etc/rc.conf
--- start ---
# This file now contains just the overrides from /etc/defaults/rc.conf.
# Please make all changes to this file, not to /etc/defaults/rc.conf.

# Enable network daemons for user convenience.
# Created: Mon Nov  8 16:35:26 2004
--- end ----
(the time stamp obviously differs)

after running sysinstall many times, you will end up with a large
rc.conf file full of this text.
	
>How-To-Repeat:
start and then exit sysinstall.
	
>Fix:
this text should not be appended to rc.conf, or appended only once.
	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-qa 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Nov 9 01:29:04 GMT 2004 
Responsible-Changed-Why:  
sysinstall bug. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73692 

From: Olafur Osvaldsson <oli@isnic.is>
To: freebsd-gnats-submit@FreeBSD.org
Cc: nehalmistry@gmx.net
Subject: Re: bin/73692 [sysinstall] exiting sysinstall appends text to rc.conf
Date: Tue, 9 Nov 2004 22:31:58 +0000

 --r5Pyd7+fXNt84Ff3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Attached is a patch that fixes this bug.
 
 It was introduced by trhodes at Sat Jul 12 15:33:09 2003 UTC
 http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/sysinstall/config.c.diff?r1=1.210&r2=1.211
 
 /Oli
 
 -- 
 Olafur Osvaldsson
 Systems Administrator
 Internet a Islandi hf.
 Tel:   +354 525-5291
 Email: oli@isnic.is
 
 --r5Pyd7+fXNt84Ff3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="sysinstall.diff"
 
 --- usr.sbin/sysinstall/config.c.orig	Tue Nov  9 22:13:20 2004
 +++ usr.sbin/sysinstall/config.c	Tue Nov  9 22:24:44 2004
 @@ -428,7 +428,7 @@
  		fprintf(rcSite, "#REMOVED: %s", line);
  	}
  	fclose(rcOld);
 -    } else {
 +    } else if (write_header) {
  	fprintf(rcSite, "# This file now contains just the overrides from /etc/defaults/rc.conf.\n");
  	fprintf(rcSite, "# Please make all changes to this file, not to /etc/defaults/rc.conf.\n\n");
  	fprintf(rcSite, "# Enable network daemons for user convenience.\n");
 
 --r5Pyd7+fXNt84Ff3--
Responsible-Changed-From-To: freebsd-qa->simon 
Responsible-Changed-By: simon 
Responsible-Changed-When: Tue Nov 9 22:58:13 GMT 2004 
Responsible-Changed-Why:  
I did a lot of the original code so I will get this committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73692 
State-Changed-From-To: open->patched 
State-Changed-By: simon 
State-Changed-When: Tue Nov 16 22:00:05 GMT 2004 
State-Changed-Why:  
Fixed in -CURRENT, thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73692 
State-Changed-From-To: patched->closed 
State-Changed-By: simon 
State-Changed-When: Thu Nov 25 22:55:21 GMT 2004 
State-Changed-Why:  
Now MFC'ed to 4-STABLE and 5-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73692 
>Unformatted:
