From okor@ns.salut.ru  Thu Oct 14 13:54:32 2004
Return-Path: <okor@ns.salut.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C77516A4CE; Thu, 14 Oct 2004 13:54:32 +0000 (GMT)
Received: from ns.salut.ru (ns.salut.ru [194.67.150.71])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 86D0443D1D; Thu, 14 Oct 2004 13:54:31 +0000 (GMT)
	(envelope-from okor@ns.salut.ru)
Received: from ns.salut.ru (ns.salut.ru [194.67.150.71] (may be forged))
	by ns.salut.ru (8.12.11/8.12.11) with ESMTP id i9EDsUiB034668;
	Thu, 14 Oct 2004 17:54:30 +0400 (MSD)
	(envelope-from okor@ns.salut.ru)
Received: (from okor@localhost)
	by ns.salut.ru (8.12.11/8.12.11/Submit) id i9EDsSiH034666;
	Thu, 14 Oct 2004 17:54:29 +0400 (MSD)
	(envelope-from okor)
Message-Id: <200410141354.i9EDsSiH034666@ns.salut.ru>
Date: Thu, 14 Oct 2004 17:54:29 +0400 (MSD)
From: Oleg Koreshkov <freebsd-pr@zone.salut.ru>
Reply-To: Oleg Koreshkov <freebsd-pr@zone.salut.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: yar@freebsd.org
Subject: [PATCH] ftpd(8) logs to /var/log/ftpd incorrect size.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         72687
>Category:       bin
>Synopsis:       [PATCH] ftpd(8) logs to /var/log/ftpd incorrect size.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    yar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 14 14:00:49 GMT 2004
>Closed-Date:    Mon Nov 15 11:16:20 GMT 2004
>Last-Modified:  Mon Nov 15 11:16:20 GMT 2004
>Originator:     Oleg Koreshkov
>Release:        any
>Organization:
none
>Environment:
		FreeBSD 4.8 i386
>Description:
		ftpd(8) logs to /var/log/ftpd full file size instead of
		number of really transferred octets.
>How-To-Repeat:
		Run ftpd(8) with -S set (log all anonymous file downloads to
		/var/run/ftpd). Start transfer of file, issue ABOR command
		or simulate disconnect. ftpd(8) will log full file size
		instead of number really transferred octets.
>Fix:
--- ftpd.c
+++ ftpd.c

@@ -1675,8 +1675,8 @@
 	time(&start);
 	send_data(fin, dout, st.st_blksize, st.st_size,
 		  restart_point == 0 && cmd == 0 && S_ISREG(st.st_mode));
-	if (cmd == 0 && guest && stats)
-		logxfer(name, st.st_size, start);
+	if (cmd == 0 && guest && stats && byte_count > 0)
+		logxfer(name, byte_count, start);
 	(void) fclose(dout);
 	data = -1;
 	pdata = -1;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: yar 
State-Changed-When: Sun Oct 24 20:12:26 GMT 2004 
State-Changed-Why:  
Fixed in CURRENT.  A good point, thanks! 


Responsible-Changed-From-To: freebsd-bugs->yar 
Responsible-Changed-By: yar 
Responsible-Changed-When: Sun Oct 24 20:12:26 GMT 2004 
Responsible-Changed-Why:  
My area. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72687 
State-Changed-From-To: patched->closed 
State-Changed-By: yar 
State-Changed-When: Mon Nov 15 11:15:30 GMT 2004 
State-Changed-Why:  
Merged to 5-STABLE and 4-STABLE.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72687 
>Unformatted:
