From nobody@FreeBSD.org  Sun Sep 19 21:26:05 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 01C8816A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Sep 2004 21:26:05 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EAC4C43D1F
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Sep 2004 21:26:04 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i8JLQ4pG035388
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Sep 2004 21:26:04 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i8JLQ4Ab035386;
	Sun, 19 Sep 2004 21:26:04 GMT
	(envelope-from nobody)
Message-Id: <200409192126.i8JLQ4Ab035386@www.freebsd.org>
Date: Sun, 19 Sep 2004 21:26:04 GMT
From: Rostislav Krasny <rosti_bsd@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked
X-Send-Pr-Version: www-2.3

>Number:         71917
>Category:       bin
>Synopsis:       selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 19 21:30:28 GMT 2004
>Closed-Date:    Mon Sep 20 21:45:24 GMT 2004
>Last-Modified:  Mon Sep 20 21:45:24 GMT 2004
>Originator:     Rostislav Krasny
>Release:        5.3-BETA4
>Organization:
>Environment:
FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27 IDT 2004     root@localhost:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When one select "All" on some of the "Distributions" menus of
sysinstall(8) no distribution is marked but actually all of them are
selected for installation. It can confuse one during a new system
installation. Following patch fixes this problem.
>How-To-Repeat:
If you want test this patch or repeat the problem before that on already installed system try following scenario before and after applying the patch to your source:

1. run 'sysinstall' as a root
2. go to "Custom | Distributions" or to "Custom | Distributions | Custom" menu
3. select "All" on the menu and see what distributions are marked after that
>Fix:
--- dist.c.prev Sat Sep 18 17:37:01 2004
+++ dist.c      Sat Sep 18 17:38:06 2004
@@ -291,7 +291,7 @@
     XOrgDists = DIST_XORG_ALL;
     i = distMaybeSetPorts(self);
     distVerifyFlags();
-    return i;
+    return i | DITEM_REDRAW;
 }

 static int


P.S. If this patch is correct it should be commited to 5.3 before the
release, IMHO.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Mon Sep 20 21:44:48 GMT 2004 
State-Changed-Why:  
Patch is already committed to HEAD and will hopefully make it into 5.3. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71917 
>Unformatted:
