From dan@obluda.cz  Sun Sep 12 17:37:04 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B6F9916A4CF
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:37:04 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6277443D1F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:37:03 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHauut010924
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:37:01 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHaoV1010923
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:36:50 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121736.i8CHaoV1010923@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 19:36:50 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] cleanup of the usr.sbin/apmd code

>Number:         71671
>Category:       bin
>Synopsis:       [patch] cleanup of the usr.sbin/apmd code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:27 GMT 2004
>Closed-Date:    Tue Feb 22 17:57:09 UTC 2011
>Last-Modified:  Tue Feb 22 17:57:09 UTC 2011
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386
usr.sbin/apmd/apmdlex.l,v 1.3 2001/05/15 05:13:45 nsayer
usr.sbin/apmd/apmdparse.y,v 1.5 2003/06/16 14:57:07 maxim

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/apmd/apmdlex.l:453: warning: 'yyunput' defined but not used
y.tab.c:298: warning: implicit declaration of function `yylex'
y.tab.c:339: warning: implicit declaration of function `yyerror'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/apmd/apmdlex.l.ORIG	Tue May 15 07:13:45 2001
--- usr.sbin/apmd/apmdlex.l	Sun Sep 12 18:37:31 2004
***************
*** 30,35 ****
--- 30,37 ----
   * $FreeBSD: src/usr.sbin/apmd/apmdlex.l,v 1.3 2001/05/15 05:13:45 nsayer Exp $
   */
  
+ #define YY_NO_UNPUT 1
+ 
  #include <string.h>
  #include <syslog.h>
  #include <bitstring.h>
*** usr.sbin/apmd/apmdparse.y.ORIG	Tue Jul 15 22:47:04 2003
--- usr.sbin/apmd/apmdparse.y	Sun Sep 12 18:37:30 2004
***************
*** 40,45 ****
--- 40,48 ----
  #define YYDEBUG 1
  #endif
  
+ extern int      yylex();
+ void   yyerror(const char *);
+ 
  extern int first_time;
  
  %}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Feb 21 20:26:09 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71671 
State-Changed-From-To: open->closed 
State-Changed-By: brucec 
State-Changed-When: Tue Feb 22 17:56:36 UTC 2011 
State-Changed-Why:  
This has been fixed with various checkins recently. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71671 
>Unformatted:
