From dan@obluda.cz  Sun Sep 12 17:36:50 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2393716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:36:50 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 01C1043D49
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:36:49 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHald6010922
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:36:47 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHafpO010921
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:36:41 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121736.i8CHafpO010921@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 19:36:41 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] usr.sbin/asf may use uninialised variables

>Number:         71670
>Category:       bin
>Synopsis:       [PATCH] usr.sbin/asf may use uninialised variables
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:27 GMT 2004
>Closed-Date:    Sun Sep 12 18:21:48 GMT 2004
>Last-Modified:  Sun Sep 12 18:21:48 GMT 2004
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386
usr.sbin/asf/asf.c,v 1.6 2003/11/04 06:38:37 green

>Description:
usr.sbin/asf/asf.c:245: warning: 'textaddr' might be used uninitialized in this function
usr.sbin/asf/asf.c:246: warning: 'dataaddr' might be used uninitialized in this function
usr.sbin/asf/asf.c:247: warning: 'bssaddr' might be used uninitialized in this function

Those warnings are real bugs. When output of objdump doesn't contain
information about .text or .data or .bss section then corresponding variable
remain uninitialized, but used.

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/asf/asf.c.ORIG	Fri Nov 14 03:53:00 2003
--- usr.sbin/asf/asf.c	Sun Sep 12 17:33:13 2004
***************
*** 242,250 ****
  	if ((!(strstr(buf, "kernel")))
  	    && buf[0] != 'I') {
  	    quad_t base;
! 	    quad_t textaddr;
! 	    quad_t dataaddr;
! 	    quad_t bssaddr;
  
  	    tokens = tokenize(buf, token, MAXTOKEN);
  	    base = strtoll(token[2], NULL, 16);
--- 242,250 ----
  	if ((!(strstr(buf, "kernel")))
  	    && buf[0] != 'I') {
  	    quad_t base;
! 	    quad_t textaddr = 0;
! 	    quad_t dataaddr = 0;
! 	    quad_t bssaddr = 0;
  
  	    tokens = tokenize(buf, token, MAXTOKEN);
  	    base = strtoll(token[2], NULL, 16);
>Release-Note:
>Audit-Trail:

From: Dan Lukes <dan@obluda.cz>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/71670: [PATCH] usr.sbin/asf may use uninialised variables
Date: Sun, 12 Sep 2004 19:48:16 +0200

 	This PR has been send twice by accident.
 
 	Please close it as it is duplicate of bin/71653
 
 	Thank you
 
 						Dan Lukes
 
State-Changed-From-To: open->closed 
State-Changed-By: simon 
State-Changed-When: Sun Sep 12 18:21:32 GMT 2004 
State-Changed-Why:  
Duplicate of bin/71653. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71670 
>Unformatted:
