From dan@obluda.cz  Sun Sep 12 17:35:42 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CDD4916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:35:42 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AEFC643D41
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:35:41 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHZYBC010906
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:35:40 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHZSX4010905
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:35:28 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121735.i8CHZSX4010905@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 19:35:28 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/ifmcast code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71662
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/ifmcast code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:24 GMT 2004
>Closed-Date:    Mon Sep 13 08:34:02 GMT 2004
>Last-Modified:  Mon Sep 13 08:34:02 GMT 2004
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/ifmcstat/ifmcstat.c,v 1.11 2004/05/28 17:44:11 stefanf

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/ifmcstat/ifmcstat.c:151: warning: unused variable `ifnamebuf'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/ifmcstat/ifmcstat.c.ORIG	Sat May 29 22:26:12 2004
--- usr.sbin/ifmcstat/ifmcstat.c	Sun Sep 12 05:15:20 2004
***************
*** 148,154 ****
  {
  	static char buf[BUFSIZ];
  	struct ifnet ifnet;
- 	char ifnamebuf[IFNAMSIZ];
  
  	KREAD(ifp, &ifnet, struct ifnet);
  	strlcpy(buf, ifnet.if_xname, sizeof(buf));
--- 148,153 ----
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: dd 
State-Changed-When: Mon Sep 13 08:33:44 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

When you make changes like this, it's a good idea to see if you can 
clamp down the program to a higher WARNS level. In this case, the 
program compiles cleanly with WARNS=2 after your change, so I set 
that. Setting WARNS in the Makefile makes sure that future changes to 
the program don't cause more warnings. Since WARNS means that warnings 
will break the build, though, it's good to be able to test the change 
on more than one architecture to make sure you don't miss any 
platform-specific issues. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71662 
>Unformatted:
