From dan@obluda.cz  Sun Sep 12 17:35:28 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 16FAB16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:35:28 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 52D7243D5A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:35:24 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHZMXY010904
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:35:22 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHZLb4010903
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:35:21 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121735.i8CHZLb4010903@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 19:35:21 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/keyserv code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71661
>Category:       bin
>Synopsis:       [patch] cleanup of the usr.sbin/keyserv code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:24 GMT 2004
>Closed-Date:    Tue May 14 21:34:53 UTC 2013
>Last-Modified:  Tue May 14 21:34:53 UTC 2013
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/keyserv/keyserv.c,v 1.11 2003/02/18 01:35:58 kris

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/keyserv/keyserv.c:365: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:385: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:413: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:463: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:493: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:522: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:550: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:792: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:804: warning: long int format, uid_t arg (arg 3)
usr.sbin/keyserv/keyserv.c:804: warning: long int format, unsigned int arg (arg 4)

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/keyserv/keyserv.c.ORIG	Tue Feb 18 20:12:59 2003
--- usr.sbin/keyserv/keyserv.c	Sun Sep 12 05:11:38 2004
***************
*** 361,367 ****
  	static keystatus status;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "set(%ld, %.*s) = ", uid,
  				(int) sizeof (keybuf), key);
  	}
  	status = pk_setkey(uid, key);
--- 361,367 ----
  	static keystatus status;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "set(%ld, %.*s) = ", (long)uid,
  				(int) sizeof (keybuf), key);
  	}
  	status = pk_setkey(uid, key);
***************
*** 380,386 ****
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "encrypt(%ld, %s, %08x%08x) = ", uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
--- 380,386 ----
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "encrypt(%ld, %s, %08x%08x) = ", (long)uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
***************
*** 408,414 ****
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "decrypt(%ld, %s, %08x%08x) = ", uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
--- 408,414 ----
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "decrypt(%ld, %s, %08x%08x) = ", (long)uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
***************
*** 460,466 ****
  	static key_netstres keynetname;
  
  	if (debugging)
! 		(void) fprintf(stderr, "net_get(%ld) = ", uid);
  
  	keynetname.status = pk_netget(uid, &keynetname.key_netstres_u.knet);
  	if (debugging) {
--- 460,466 ----
  	static key_netstres keynetname;
  
  	if (debugging)
! 		(void) fprintf(stderr, "net_get(%ld) = ", (long)uid);
  
  	keynetname.status = pk_netget(uid, &keynetname.key_netstres_u.knet);
  	if (debugging) {
***************
*** 489,495 ****
  	static cryptkeyres  res;
  
  	if (debugging)
! 		(void) fprintf(stderr, "get_conv(%ld, %.*s) = ", uid,
  			(int)sizeof (arg), arg);
  
  
--- 489,495 ----
  	static cryptkeyres  res;
  
  	if (debugging)
! 		(void) fprintf(stderr, "get_conv(%ld, %.*s) = ", (long)uid,
  			(int)sizeof (arg), arg);
  
  
***************
*** 517,523 ****
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "encrypt(%ld, %s, %08x%08x) = ", uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
--- 517,523 ----
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "encrypt(%ld, %s, %08x%08x) = ", (long)uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
***************
*** 545,551 ****
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "decrypt(%ld, %s, %08x%08x) = ", uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
--- 545,551 ----
  	static cryptkeyres res;
  
  	if (debugging) {
! 		(void) fprintf(stderr, "decrypt(%ld, %s, %08x%08x) = ", (long)uid,
  				arg->remotename, arg->deskey.key.high,
  				arg->deskey.key.low);
  	}
***************
*** 789,795 ****
  	}
  
  	if (debugging)
! 		fprintf(stderr, "local_uid  %ld\n", uid);
  	if (uid == 0)
  		return (1);
  	if (rqstp->rq_cred.oa_flavor == AUTH_SYS) {
--- 789,795 ----
  	}
  
  	if (debugging)
! 		fprintf(stderr, "local_uid  %ld\n", (long)uid);
  	if (uid == 0)
  		return (1);
  	if (rqstp->rq_cred.oa_flavor == AUTH_SYS) {
***************
*** 800,807 ****
  		} else {
  			if (debugging)
  				fprintf(stderr,
! 			"local_uid  %ld mismatches auth %ld\n", uid,
! ((uid_t) ((struct authunix_parms *)rqstp->rq_clntcred)->aup_uid));
  			return (0);
  		}
  	} else {
--- 800,807 ----
  		} else {
  			if (debugging)
  				fprintf(stderr,
! 			"local_uid  %ld mismatches auth %ld\n", (long)uid,
! (long)((uid_t) ((struct authunix_parms *)rqstp->rq_clntcred)->aup_uid));
  			return (0);
  		}
  	} else {
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: antoine 
State-Changed-When: Tue May 14 21:33:14 UTC 2013 
State-Changed-Why:  
Close: those warnings were fixed by dim in December 2011 
See: 
http://svnweb.freebsd.org/base/head/usr.sbin/keyserv/keyserv.c?view=patch&r1=228662&r2=228661&pathrev=228662 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71661 
>Unformatted:
