From dan@obluda.cz  Sun Sep 12 17:34:41 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BDDF16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:34:41 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D1A8B43D55
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:34:39 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHYRrK010897
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:34:28 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHYQK1010896
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:34:26 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121734.i8CHYQK1010896@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 19:34:26 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/mount_portalfs code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71659
>Category:       bin
>Synopsis:       [patch] cleanup of the usr.sbin/mount_portalfs code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:40:23 GMT 2004
>Closed-Date:    Fri Sep 18 11:27:33 UTC 2009
>Last-Modified:  Fri Sep 18 11:27:33 UTC 2009
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/mount_portalfs/pt_tcplisten.c,v 1.4 2004/08/07 04:27:50 imp

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/mount_portalfs/pt_tcplisten.c:83: warning: 'ipp' might be used uninitialized in this function

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/mount_portalfs/pt_tcplisten.c.ORIG	Sun Aug  8 21:13:25 2004
--- usr.sbin/mount_portalfs/pt_tcplisten.c	Sun Sep 12 04:49:09 2004
***************
*** 80,86 ****
         char *q;
         struct hostent *hp;
         struct servent *sp;
!        struct in_addr **ipp;
         struct in_addr *ip[2];
         struct in_addr ina;
         u_short s_port;
--- 80,86 ----
         char *q;
         struct hostent *hp;
         struct servent *sp;
!        struct in_addr **ipp = ipp; /* "init" to avoid "might be used uninitialised" warning */
         struct in_addr *ip[2];
         struct in_addr ina;
         u_short s_port;
>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/71659: commit references a PR
Date: Sat, 20 Jan 2007 21:35:29 +0000 (UTC)

 rodrigc     2007-01-20 21:35:12 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.sbin/mount_portalfs Makefile activate.c conf.c 
                             mount_portalfs.c portald.h pt_exec.c 
                             pt_file.c pt_pipe.c pt_tcp.c 
                             pt_tcplisten.c 
   Log:
   Clean up compilation warnings.  Set WARNS=6 in Makefile.
   
   PR:     71659
   Submitted by:   Dan Lukes <dan obluda cz>
   
   Revision  Changes    Path
   1.20      +1 -1      src/usr.sbin/mount_portalfs/Makefile
   1.12      +6 -19     src/usr.sbin/mount_portalfs/activate.c
   1.11      +10 -26    src/usr.sbin/mount_portalfs/conf.c
   1.24      +4 -9      src/usr.sbin/mount_portalfs/mount_portalfs.c
   1.11      +1 -1      src/usr.sbin/mount_portalfs/portald.h
   1.8       +2 -6      src/usr.sbin/mount_portalfs/pt_exec.c
   1.13      +2 -6      src/usr.sbin/mount_portalfs/pt_file.c
   1.3       +2 -6      src/usr.sbin/mount_portalfs/pt_pipe.c
   1.13      +3 -7      src/usr.sbin/mount_portalfs/pt_tcp.c
   1.5       +4 -8      src/usr.sbin/mount_portalfs/pt_tcplisten.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: linimon 
State-Changed-When: Fri Jun 15 11:32:33 UTC 2007 
State-Changed-Why:  
Fixed in HEAD; needs to be MFCed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71659 

From: Dan Lukes <dan@obluda.cz>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/71659: [PATCH] cleanup of the usr.sbin/mount_portalfs code
Date: Fri, 15 Jun 2007 14:56:10 +0200

 After years, I reconsidered things.
 
 struct in_addr **ipp = ipp;
 
 ... is not nice trick but dirty gcc-centric hack instead.
 
 
 
 
 struct in_addr **ipp = NULL;
 
 seems to be better construct ...
 
 The final decision is committer's sovereignty.
 
 					Dan
 
 

From: Dan Lukes <dan@obluda.cz>
To: bug-followup@FreeBSD.org, dan@obluda.cz
Cc:  
Subject: Re: bin/71659: [patch] cleanup of the usr.sbin/mount_portalfs code
Date: Sun, 30 Aug 2009 22:15:33 +0200

 I assume it's already MFCed. It seems such PR should be closed ...
 
 					Dan
State-Changed-From-To: patched->closed 
State-Changed-By: pav 
State-Changed-When: Fri Sep 18 11:20:04 UTC 2009 
State-Changed-Why:  
This was never MFCed but it's present in 7.0 and up. We probably don't care 
anymore about 6-STABLE, so close 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71659 
>Unformatted:
