From dan@obluda.cz  Sun Sep 12 15:38:53 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 23E5716A570
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 15:38:53 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9079C43D53
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 15:38:51 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CFcnv3010420
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:38:49 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CFcmp2010419
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 17:38:48 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409121538.i8CFcmp2010419@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 17:38:48 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] usr.sbin/asf may use uninialised variables

>Number:         71653
>Category:       bin
>Synopsis:       [PATCH] usr.sbin/asf may use uninialised variables
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 15:40:19 GMT 2004
>Closed-Date:    Wed Sep 21 08:24:20 GMT 2005
>Last-Modified:  Mon Feb 20 18:30:07 GMT 2006
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386
usr.sbin/asf/asf.c,v 1.6 2003/11/04 06:38:37 green

>Description:
usr.sbin/asf/asf.c:245: warning: 'textaddr' might be used uninitialized in this function
usr.sbin/asf/asf.c:246: warning: 'dataaddr' might be used uninitialized in this function
usr.sbin/asf/asf.c:247: warning: 'bssaddr' might be used uninitialized in this function

Those warnings are real bugs. When output of objdump doesn't contain
information about .text or .data or .bss section then corresponding variable
remain uninitialized, but used.

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/asf/asf.c.ORIG	Fri Nov 14 03:53:00 2003
--- usr.sbin/asf/asf.c	Sun Sep 12 17:33:13 2004
***************
*** 242,250 ****
  	if ((!(strstr(buf, "kernel")))
  	    && buf[0] != 'I') {
  	    quad_t base;
! 	    quad_t textaddr;
! 	    quad_t dataaddr;
! 	    quad_t bssaddr;
  
  	    tokens = tokenize(buf, token, MAXTOKEN);
  	    base = strtoll(token[2], NULL, 16);
--- 242,250 ----
  	if ((!(strstr(buf, "kernel")))
  	    && buf[0] != 'I') {
  	    quad_t base;
! 	    quad_t textaddr = 0;
! 	    quad_t dataaddr = 0;
! 	    quad_t bssaddr = 0;
  
  	    tokens = tokenize(buf, token, MAXTOKEN);
  	    base = strtoll(token[2], NULL, 16);
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Wed Sep 21 08:23:46 GMT 2005 
State-Changed-Why:  
Closed by grog on 2005-09-21 05:33:46 UTC in asf.c. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71653 

From: Dan Lukes <dan@obluda.cz>
To: bug-followup@FreeBSD.org
Cc: linimon@FreeBSD.org
Subject: Re: bin/71653: [PATCH] usr.sbin/asf may use uninialised variables
Date: Wed, 21 Sep 2005 17:38:41 +0200

      Thank you for reviewing and commiting the patch.
 
      I see no notice about MFC.
 
      Is there a reason not to MFC the changes into 6.x branch (after re@
 approval, of course) ?
 
      Or all future 6.?-RELEASES remain vulnerable to errors ?
 
                          Dan
 
 
 
 

From: Yar Tikhiy <yar@comp.chem.msu.su>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/71653: [PATCH] usr.sbin/asf may use uninialised variables
Date: Mon, 20 Feb 2006 21:20:21 +0300

 grog@ fixed this bug in RELENG_6, too,
 which hasn't been mentioned in the audit trail yet.
 
 -- 
 Yar
>Unformatted:
