From dan@obluda.cz  Sun Sep 12 02:38:48 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3DE7416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:48 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 500A043D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:47 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2cjMc007125
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 04:38:46 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2cj9S007124
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:38:45 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409120238.i8C2cj9S007124@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 04:38:45 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/ndp code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71632
>Category:       bin
>Synopsis:       [patch] cleanup of the usr.sbin/ndp code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:32 GMT 2004
>Closed-Date:    Sun Jan 03 15:12:02 UTC 2010
>Last-Modified:  Sun Jan 03 15:12:02 UTC 2010
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/ndp/ndp.c,v 1.16 2004/08/07 04:27:51 imp
>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/ndp/ndp.c:1000: warning: 'rbuf' might be used uninitialized in this function
>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/ndp/ndp.c.ORIG	Sun Aug  8 21:13:32 2004
--- usr.sbin/ndp/ndp.c	Sun Sep 12 00:30:09 2004
***************
*** 1013,1018 ****
--- 1013,1021 ----
  				printf("\nRandom ID:      ");
  				rbuf = ND.randomid;
  				break;
+ 			default:
+ 				rbuf = NULL;
+ 				break;
  			}
  			for (j = 0; j < 8; j++)
  				printf("%02x", rbuf[j]);
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: gavin 
State-Changed-When: Sun Jan 3 15:11:08 UTC 2010 
State-Changed-Why:  
This was fixed differently is ndp.c 1.18.  Thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71632 
>Unformatted:
