From dan@obluda.cz  Sun Sep 12 02:38:20 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 562B816A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:20 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3048C43D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:19 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2cHYL007111
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 04:38:17 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2cHb0007110
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:38:17 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409120238.i8C2cHb0007110@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 04:38:17 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/rpc.ypupdated code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71625
>Category:       bin
>Synopsis:       [patch] [nis] cleanup of the usr.sbin/rpc.ypupdated code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:27 GMT 2004
>Closed-Date:    Tue Sep 11 18:11:12 UTC 2012
>Last-Modified:  Tue Sep 11 18:11:12 UTC 2012
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
$FreeBSD: src/usr.sbin/rpc.ypupdated/yp_dbupdate.c,v 1.8 2004/05/24 13:21:24 stefanf

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/rpc.ypupdated/yp_dbupdate.c:134: warning: long unsigned int format, time_t arg (arg 4)

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/rpc.ypupdated/yp_dbupdate.c.ORIG	Fri May 28 19:23:11 2004
--- usr.sbin/rpc.ypupdated/yp_dbupdate.c	Tue Sep  7 21:47:12 2004
***************
*** 131,137 ****
  		return(rval);
  	}
  
! 	snprintf(yplastbuf, sizeof(yplastbuf), "%lu", time(NULL));
  	key.data = yp_last;
  	key.size = strlen(yp_last);
  	data.data = (char *)&yplastbuf;
--- 131,137 ----
  		return(rval);
  	}
  
! 	snprintf(yplastbuf, sizeof(yplastbuf), "%lu", (unsigned long)time(NULL));
  	key.data = yp_last;
  	key.size = strlen(yp_last);
  	data.data = (char *)&yplastbuf;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pfg 
State-Changed-When: Tue Sep 11 18:09:59 UTC 2012 
State-Changed-Why:  
Fixed in r228678 by casting to intmax_t. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=71625 
>Unformatted:
