From dan@obluda.cz  Sun Sep 12 02:38:17 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8927D16A4CF
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:16 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6054843D39
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:38:15 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2cDUP007109
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 04:38:14 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2cD9P007108
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:38:13 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409120238.i8C2cD9P007108@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 04:38:13 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/rtadvd code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71624
>Category:       bin
>Synopsis:       [PATCH] rtadvd(8): cleanup of the usr.sbin/rtadvd code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:27 GMT 2004
>Closed-Date:    Fri Feb 29 12:12:42 UTC 2008
>Last-Modified:  Fri Feb 29 12:12:42 UTC 2008
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
$FreeBSD: src/usr.sbin/rtadvd/config.c,v 1.23 2003/08/15 19:13:53 ume
$FreeBSD: src/usr.sbin/rtadvd/timer.c,v 1.8 2003/08/11 15:51:54 ume

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/rtadvd/config.c:294: warning: implicit declaration of function `insque'
usr.sbin/rtadvd/config.c:728: warning: implicit declaration of function `remque'
usr.sbin/rtadvd/timer.c:85: warning: implicit declaration of function `insque'
usr.sbin/rtadvd/timer.c:93: warning: implicit declaration of function `remque'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/rtadvd/config.c.ORIG	Sun Aug 17 21:29:19 2003
--- usr.sbin/rtadvd/config.c	Tue Sep  7 20:06:24 2004
***************
*** 53,58 ****
--- 53,59 ----
  #include <syslog.h>
  #include <errno.h>
  #include <string.h>
+ #include <search.h>
  #include <stdlib.h>
  #include <unistd.h>
  #include <ifaddrs.h>
*** usr.sbin/rtadvd/timer.c.ORIG	Thu Aug 14 19:17:42 2003
--- usr.sbin/rtadvd/timer.c	Tue Sep  7 20:06:26 2004
***************
*** 36,41 ****
--- 36,42 ----
  #include <syslog.h>
  #include <stdlib.h>
  #include <string.h>
+ #include <search.h>
  #include "timer.h"
  
  static struct rtadvd_timer timer_head;
>Release-Note:
>Audit-Trail:

From: bruce@cran.org.uk
To: bug-followup@freebsd.org, dan@obluda.cz
Cc:  
Subject: Re: bin/71624: [PATCH] rtadvd(8): cleanup of the usr.sbin/rtadvd code
Date: Fri, 29 Feb 2008 11:50:07 +0000

 This was fixed in rev 1.24 of config.c and 1.9 of timer.c, which were
 included in FreeBSD 6.0 and later.
 
 --
 Bruce
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Fri Feb 29 12:11:07 UTC 2008 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=71624 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Fri Feb 29 12:12:00 UTC 2008 
State-Changed-Why:  
Close this PR.  It's in 6.x, and is unlikely that this will be MFC'd 
back to 5.x 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71624 
>Unformatted:
