From dan@obluda.cz  Sun Sep 12 02:37:25 2004
Return-Path: <dan@obluda.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B838316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:37:25 +0000 (GMT)
Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A48D143D41
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 02:37:24 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1])
	by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bNSj007089
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 04:37:23 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bM7U007088
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:22 +0200 (CEST)
	(envelope-from dan@obluda.cz)
Message-Id: <200409120237.i8C2bM7U007088@kulesh.obluda.cz>
Date: Sun, 12 Sep 2004 04:37:22 +0200 (CEST)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cleanup of the usr.sbin/ugidfw code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71614
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/ugidfw code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:22 GMT 2004
>Closed-Date:    Sat Apr 23 18:29:50 GMT 2005
>Last-Modified:  Sat Apr 23 18:40:25 GMT 2005
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
$FreeBSD: src/usr.sbin/ugidfw/ugidfw.c,v 1.2 2004/02/25 03:59:56 rwatson
>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/ugidfw/ugidfw.c:67: warning: unused variable `value'
usr.sbin/ugidfw/ugidfw.c:69: warning: unused variable `endp'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/ugidfw/ugidfw.c.ORIG	Sun Sep  5 18:37:32 2004
--- usr.sbin/ugidfw/ugidfw.c	Sun Sep  5 18:38:10 2004
***************
*** 64,72 ****
  {
  	char errstr[BUFSIZ];
  	struct mac_bsdextended_rule rule;
- 	long value;
  	int error, rulenum;
- 	char *endp;
  
  	error = bsde_parse_rule(argc, argv, &rule, BUFSIZ, errstr);
  	if (error) {
--- 64,70 ----
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: trhodes 
State-Changed-When: Sat Apr 23 18:29:22 GMT 2005 
State-Changed-Why:  
Already fixed in RELENG_5 and CURRENT.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71614 
Responsible-Changed-From-To: freebsd-bugs->trhodes 
Responsible-Changed-By: trhodes 
Responsible-Changed-When: Sat Apr 23 18:40:08 GMT 2005 
Responsible-Changed-Why:  
Over to me. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71614 
>Unformatted:
