From dada@sbox.tugraz.at  Wed Aug 25 07:09:26 2004
Return-Path: <dada@sbox.tugraz.at>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1DB6816A4CE
	for <freebsd-gnats-submit@freebsd.org>; Wed, 25 Aug 2004 07:09:26 +0000 (GMT)
Received: from mailrelay02.tugraz.at (mailrelay.tu-graz.ac.at [129.27.3.7])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2381A43D45
	for <freebsd-gnats-submit@freebsd.org>; Wed, 25 Aug 2004 07:09:25 +0000 (GMT)
	(envelope-from dada@sbox.tugraz.at)
Received: from webmail.tugraz.at (webmail02.tu-graz.ac.at [129.27.3.144])
	by mailrelay02.tugraz.at (8.13.1/8.13.1) with ESMTP id i7P79MFX019051
	for <freebsd-gnats-submit@freebsd.org>; Wed, 25 Aug 2004 09:09:23 +0200 (CEST)
Received: from ARP410.kfunigraz.ac.at (ARP410.kfunigraz.ac.at
	[143.50.129.135]) by webmail.tugraz.at (Horde) with HTTP for <dada@sbox>;
	Wed, 25 Aug 2004 09:09:22 +0200
Message-Id: <20040825090922.gbcsg8g0kg8sk4s0@webmail.tugraz.at>
Date: Wed, 25 Aug 2004 09:09:22 +0200
From: dada@sbox.tugraz.at
To: FreeBSD problem reports <freebsd-gnats-submit@freebsd.org>
Subject: [patch] mpool(3): ignored function argument documented to work

>Number:         70929
>Category:       bin
>Synopsis:       mpool(3): ignored function argument documented to work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 25 07:10:35 GMT 2004
>Closed-Date:    Sun Feb 27 14:06:39 GMT 2005
>Last-Modified:  Sun Feb 27 14:06:39 GMT 2005
>Originator:     Martin Kammerhofer
>Release:        FreeBSD 4.10-RELEASE-p2 i386
>Organization:
Graz Uni
>Environment:
System: FreeBSD Martin.liebt.Susi 4.10-RELEASE-p2 FreeBSD 4.10-RELEASE-p2 #1: Mon Aug 16 14:26:52 CEST 2004 toor@Martin.liebt.Susi:/mnt/redhat/freebsd/usr/src/sys/compile/GEIDORF4 i386
>Description:
The mpool(3) manpage explains an unimplemented feature of
mpool_open(). The `key' argument is unused by the code.  BTW, the
mpool(3) interface has been dropped in later versions of db(3);
i.e. Berkeley DB >= 2.0 does not have it any more. See also the last
sentence of the dbopen(3) manpage.
>How-To-Repeat:
gcc -W -Wunused /usr/src/lib/libc/db/mpool/mpool.c 2>&1 | grep key
>Fix:
--- /usr/src/lib/libc/db/man/mpool.3.orig	Sun Feb 23 20:45:52 2003
+++ /usr/src/lib/libc/db/man/mpool.3	Sun Aug 22 17:18:36 2004
@@ -65,32 +65,16 @@
 .Nm mpool
 library interface is intended to provide page oriented buffer management
 of files.
-The buffers may be shared between processes.
 .Pp
 The
 .Fn mpool_open
 function initializes a memory pool.
 The
 .Fa key
-argument is the byte string used to negotiate between multiple
-processes wishing to share buffers.
-If the file buffers are mapped in shared memory, all processes using
-the same key will share the buffers.
-If
-.Fa key
-is
-.Dv NULL ,
-the buffers are mapped into private memory.
+argument is currently ignored.
 The
 .Fa fd
 argument is a file descriptor for the underlying file, which must be seekable.
-If
-.Fa key
-is
-.No non\- Ns Dv NULL
-and matches a file already being mapped, the
-.Fa fd
-argument is ignored.
 .Pp
 The
 .Fa pagesize

--=_2ubyz9a36hwk--

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: blackend 
Responsible-Changed-When: Wed Aug 25 07:16:13 GMT 2004 
Responsible-Changed-Why:  
It's a doc issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70929 

From: Peter Pentchev <roam@ringlet.net>
To: Martin Kammerhofer <dada@sbox.tugraz.at>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/70929: mpool(3): ignored function argument documented to work
Date: Wed, 25 Aug 2004 12:04:43 +0300

 --J2SCkAp4GZ/dPZZf
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 The patch looks okay.  I have just one concern: I'm not exactly sure
 on the status of src/lib/libc/db/ - is it treated as contributed code,
 or is it 'ours' to do with as we wish?
 
 G'luck,
 Peter
 
 --=20
 Peter Pentchev	roam@ringlet.net    roam@cnsys.bg    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 =2Esiht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI
 
 --J2SCkAp4GZ/dPZZf
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.5 (FreeBSD)
 
 iD8DBQFBLFYr7Ri2jRYZRVMRAhzAAKC1Plz3jd4OLuMBiKs34sxOP4CFAwCdEb4p
 60evWlJ9VlOXyhkd/kI1gF8=
 =o8MT
 -----END PGP SIGNATURE-----
 
 --J2SCkAp4GZ/dPZZf--

From: dada@sbox.tugraz.at
To: Peter Pentchev <roam@ringlet.net>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/70929: mpool(3): ignored function argument documented to
	work
Date: Wed, 25 Aug 2004 18:21:08 +0200

 Zitat von Peter Pentchev <roam@ringlet.net>:
 > The patch looks okay.  I have just one concern: I'm not exactly sure
 > on the status of src/lib/libc/db/ - is it treated as contributed code,
 > or is it 'ours' to do with as we wish?
 
 I am not a committer, so my answer is not authoritative. However the 
 Berkeley DB
 1.85 code has the BSD license and is afaik part of all the *BSD core systems.
 Later version from Sleepycat (Major >= 2) have a somewhat more restrictive
 license and are under /usr/ports/databases/db[2-4]*.
 In short: Matching the docs to the reality (as it stands for 8+ years) should
 not be a problem.
 
State-Changed-From-To: open->patched 
State-Changed-By: roam 
State-Changed-When: Fri Aug 27 14:51:26 GMT 2004 
State-Changed-Why:  
I've committed the patch to the HEAD CVS branch (which is currently 
known as 6.0-CURRENT).  With the permission of re@, I'll merge it 
into 5.3-BETA2 in three days, and into 4.x-STABLE a bit later. 
Thanks for noticing the inaccuracy and for the patch! 


Responsible-Changed-From-To: freebsd-doc->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Fri Aug 27 14:51:26 GMT 2004 
Responsible-Changed-Why:  
I'll take care of the MFC's. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70929 
State-Changed-From-To: patched->closed 
State-Changed-By: roam 
State-Changed-When: Sun Feb 27 13:58:58 GMT 2005 
State-Changed-Why:  
MFC'd to both RELENG_5 (quite some time ago) and RELENG_4. 
Thanks for repoting this! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70929 
>Unformatted:
 This message is in MIME format.
 
 --=_2ubyz9a36hwk
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: 7bit
 
 
 --=_2ubyz9a36hwk
 Content-Type: text/plain; charset=UTF-8; name="mpool.pr"
 Content-Disposition: inline; filename="mpool.pr"
 Content-Transfer-Encoding: 7bit
 
 
