From ga9@buffy.york.ac.uk  Tue Aug 10 21:20:04 2004
Return-Path: <ga9@buffy.york.ac.uk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5ABFF16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2004 21:20:04 +0000 (GMT)
Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BFF5143D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2004 21:20:03 +0000 (GMT)
	(envelope-from ga9@buffy.york.ac.uk)
Received: from buffy.york.ac.uk (buffy.york.ac.uk [144.32.226.160])
	by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id i7ALK2H6010170
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2004 22:20:02 +0100 (BST)
Received: from buffy.york.ac.uk (localhost [127.0.0.1])
	by buffy.york.ac.uk (8.12.11/8.12.11) with ESMTP id i7ALK1Qq002215
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2004 22:20:02 +0100 (BST)
	(envelope-from ga9@buffy.york.ac.uk)
Received: (from root@localhost)
	by buffy.york.ac.uk (8.12.11/8.12.11/Submit) id i7ALK1UX002214;
	Tue, 10 Aug 2004 22:20:01 +0100 (BST)
	(envelope-from ga9)
Message-Id: <200408102120.i7ALK1UX002214@buffy.york.ac.uk>
Date: Tue, 10 Aug 2004 22:20:01 +0100 (BST)
From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
Reply-To: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Sysinstall can no longer perform install from tape
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70279
>Category:       bin
>Synopsis:       Sysinstall can no longer perform install from tape
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bmah
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 10 21:20:24 GMT 2004
>Closed-Date:    Thu Sep 23 13:58:39 GMT 2004
>Last-Modified:  Thu Sep 23 13:58:39 GMT 2004
>Originator:     Gavin Atkinson
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD buffy.york.ac.uk 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Thu Jun 24 15:03:29 BST 2004 root@buffy.york.ac.uk:/usr/obj/usr/src/sys/GENERIC i386

>Description:

	Sysinstall has the ability to install FreeBSD from a set of distfiles stored on SCSI tape. Only it doesn't work - sysinstall cannot detect the fact a SCSI tape drive is installed.  This appears to have been broken back in May 2000 with the tape device renaming.  With the attached patch, sysinstall can happily install distributions from my SCSI (HP DDS-2) tape drive.

>How-To-Repeat:
	Select "Install from tape" when selecting media type on a machine with a SCSI tape drive recognised by the sa(4) driver.  Note sysinstall cannot find the tape drive.
>Fix:

	(Patch also at http://www.devrandom.co.uk/freebsd/sysinstrsa.diff )


Index: src/usr.sbin/sysinstall/devices.c
===================================================================
RCS file: /usr/cvs/src/usr.sbin/sysinstall/devices.c,v
retrieving revision 1.155
diff -u -r1.155 devices.c
--- src/usr.sbin/sysinstall/devices.c	2 Aug 2004 23:18:47 -0000	1.155
+++ src/usr.sbin/sysinstall/devices.c	10 Aug 2004 20:48:55 -0000
@@ -69,7 +69,7 @@
     { DEVICE_TYPE_CDROM,	"matcd%d",	"Matsushita CDROM ('sound blaster' type)", 46, 0, 8, 4 		},
 #endif
     { DEVICE_TYPE_CDROM,	"acd%d",	"ATAPI/IDE CDROM",	117, 0, 8, 4				},
-    { DEVICE_TYPE_TAPE, 	"rsa%d",	"SCSI tape drive",	14, 0, 16, 4				},
+    { DEVICE_TYPE_TAPE, 	"sa%d",		"SCSI tape drive",	14, 0, 16, 4				},
     { DEVICE_TYPE_TAPE, 	"rwt%d",	"Wangtek tape drive",	10, 0, 1, 4				},
     { DEVICE_TYPE_DISK, 	"da%d",		"SCSI disk device",	13, 65538, 8, 16			},
     { DEVICE_TYPE_DISK, 	"ad%d",		"ATA/IDE disk device",	116, 65538, 8, 16			},

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: bmah 
State-Changed-When: Mon Aug 16 03:13:25 GMT 2004 
State-Changed-Why:  
Committed as submitted...thanks! 



Responsible-Changed-From-To: freebsd-bugs->bmah 
Responsible-Changed-By: bmah 
Responsible-Changed-When: Mon Aug 16 03:13:25 GMT 2004 
Responsible-Changed-Why:  
Committed as submitted...thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70279 
State-Changed-From-To: closed->patched 
State-Changed-By: bmah 
State-Changed-When: Mon Aug 16 03:15:39 GMT 2004 
State-Changed-Why:  
I don't know why I didn't think of this earlier, but this is 
probably a reasonable MFC candidate for RELENG_4.  Re-open 
this PR...we can probably MFC this in a week or two. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70279 
State-Changed-From-To: patched->feedback 
State-Changed-By: bmah 
State-Changed-When: Sat Sep 11 21:29:11 GMT 2004 
State-Changed-Why:  
I was about to MFC this but I'm on the verge of changing my mind. 
Based on reading the code for MAKEDEV, we install compatibility links 
for the rsa* tape devices, so at least in theory, sysinstall should 
still be able to do installs from SCSI tape devices on 4.X without 
this change.  This eliminates the need for merging this change to 
RELENG_4, although there is still a cosmetic improvement in that after 
your change, sysinstall would be using officially supported device 
files.  I'm thinking that the improvement is negligible, so I'm kind of 
-0 on merging it. 

Any suggestions? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70279 

From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: bin/70279: Sysinstall can no longer perform install from tape
Date: Thu, 23 Sep 2004 12:17:03 +0100 (BST)

 I have just tested a tape install from a recent 4.10 snapstot and it works
 as expected without this change. Therefore I don't see any need to MFC.
 
 This PR can be closed.
 
 Gavin
State-Changed-From-To: feedback->closed 
State-Changed-By: bmah 
State-Changed-When: Thu Sep 23 13:57:56 GMT 2004 
State-Changed-Why:  
Great, thanks for testing the install! 
Closed as agreed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70279 
>Unformatted:
