From sec@42.org  Tue Jul 13 10:11:38 2004
Return-Path: <sec@42.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BA08116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Jul 2004 10:11:38 +0000 (GMT)
Received: from ice.42.org (ice.42.org [194.77.3.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 27C2043D49
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Jul 2004 10:11:38 +0000 (GMT)
	(envelope-from sec@42.org)
Received: by ice.42.org (Postfix, from userid 1000)
	id D06B51C8C5; Tue, 13 Jul 2004 12:11:36 +0200 (CEST)
Message-Id: <20040713101136.D06B51C8C5@ice.42.org>
Date: Tue, 13 Jul 2004 12:11:36 +0200 (CEST)
From: Stefan `Sec` Zehl <sec@42.org>
Reply-To: Stefan `Sec` Zehl <sec@42.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: unlogic jot behaviour.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         68981
>Category:       bin
>Synopsis:       unlogic jot behaviour.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dds
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 13 10:20:17 GMT 2004
>Closed-Date:    Mon Nov 27 09:06:16 GMT 2006
>Last-Modified:  Mon Nov 27 09:06:16 GMT 2006
>Originator:     Stefan `Sec` Zehl
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD ice 4.9-STABLE FreeBSD 4.9-STABLE #11: Sun Jan 25 15:43:27 CET 2004 root@ice:/export/obj/export/src/sys/ICE i386


	
>Description:

If you want to generate a simple integer sequence with jot, it behaves
illogical.

jot 10 1
and
jot 10 - 10 

work as expected (generating 1-10), but

jot - 1 10

generates each number a few times. From reading the source && manual,
I realize this is because it forces reps=100.

This behaviour seems unlogic to me, and it certainly isn't usefull to
anybody, thus I have created a patch to force s=1 in these cases.

I also default s=-1 in case the start is bigger than the end, otherwise
you would just get an "impossible stepsize" error.

I would be happy if this could be included :)
	
>How-To-Repeat:
	
>Fix:

	

--- jot.c.org	Sun Dec 30 20:37:27 2001
+++ jot.c	Tue Jul 13 11:56:19 2004
@@ -198,8 +198,8 @@
 			mask = 015;
 			break;
 		case 006:
-			reps = REPS_DEF;
-			mask = 016;
+			s = ender>begin?1:-1;
+			mask = 007;
 			break;
 		case 007:
 			if (randomize) {
--- jot.1.org	Tue Jul 16 13:52:09 2002
+++ jot.1	Tue Jul 13 11:59:04 2004
@@ -114,7 +114,7 @@
 If fewer than three are specified, defaults are assigned
 left to right, except for
 .Ar s ,
-which assumes its default unless both
+which assumes a default of 1 or -1 if both
 .Ar begin
 and
 .Ar end



>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/68981: commit references a PR
Date: Mon,  6 Nov 2006 15:00:59 +0000 (UTC)

 dds         2006-11-06 15:00:37 UTC
 
   FreeBSD src repository
 
   Modified files:
     tools/regression/usr.bin/jot regress.dhhd.out 
                                  regress.dhhd2.out 
   Log:
   Updated results for bin/68981
   
   PR:             bin/68981
   
   Revision  Changes    Path
   1.2       +1 -0      src/tools/regression/usr.bin/jot/regress.dhhd.out
   1.2       +41 -0     src/tools/regression/usr.bin/jot/regress.dhhd2.out
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: dds 
State-Changed-When: Mon Nov 6 15:12:06 UTC 2006 
State-Changed-Why:  
Applied patch. 


Responsible-Changed-From-To: freebsd-bugs->dds 
Responsible-Changed-By: dds 
Responsible-Changed-When: Mon Nov 6 15:12:06 UTC 2006 
Responsible-Changed-Why:  
Applied patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68981 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/68981: commit references a PR
Date: Mon,  6 Nov 2006 15:13:11 +0000 (UTC)

 dds         2006-11-06 15:11:51 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/jot          jot.1 jot.c 
   Log:
   Use a more sensible default of 1 or -1 when only the start and
   end values are specified.
   
   PR:             bin/68981
   Submitted by:   Stefan `Sec` Zehl
   MFC after:      2 weeks
   
   Revision  Changes    Path
   1.23      +5 -1      src/usr.bin/jot/jot.1
   1.33      +4 -1      src/usr.bin/jot/jot.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: dds 
State-Changed-When: Mon Nov 27 09:05:58 UTC 2006 
State-Changed-Why:  
MFCd changes to RELENG_6. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68981 
>Unformatted:
