From Mark_Andrews@isc.org  Sat Jul 10 00:31:51 2004
Return-Path: <Mark_Andrews@isc.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 47B0D16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jul 2004 00:31:51 +0000 (GMT)
Received: from farside.isc.org (farside.isc.org [204.152.187.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3941C43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jul 2004 00:31:51 +0000 (GMT)
	(envelope-from Mark_Andrews@isc.org)
Received: from drugs.dv.isc.org (localhost [IPv6:::1])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by farside.isc.org (Postfix) with ESMTP id 6C57CA863
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jul 2004 00:31:50 +0000 (UTC)
	(envelope-from marka@isc.org)
Received: from drugs.dv.isc.org (localhost [127.0.0.1])
	by drugs.dv.isc.org (8.12.11/8.12.11) with ESMTP id i6A0Vla0038671
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jul 2004 10:31:47 +1000 (EST)
	(envelope-from marka@drugs.dv.isc.org)
Received: (from marka@localhost)
	by drugs.dv.isc.org (8.12.11/8.12.11/Submit) id i6A0Vlt7038670;
	Sat, 10 Jul 2004 10:31:47 +1000 (EST)
	(envelope-from marka)
Message-Id: <200407100031.i6A0Vlt7038670@drugs.dv.isc.org>
Date: Sat, 10 Jul 2004 10:31:47 +1000 (EST)
From: Mark Andrews <Mark_Andrews@isc.org>
Reply-To: Mark Andrews <Mark_Andrews@isc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Fetch corrupts passwords with spaces.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         68881
>Category:       bin
>Synopsis:       Fetch corrupts passwords with spaces.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 10 00:40:14 GMT 2004
>Closed-Date:    Tue Aug 10 01:09:59 GMT 2004
>Last-Modified:  Tue Aug 10 01:09:59 GMT 2004
>Originator:     Mark Andrews
>Release:        FreeBSD 4.10-PRERELEASE i386
>Organization:
ISC
>Environment:
System: FreeBSD drugs.dv.isc.org 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #17: Fri May 14 00:38:53 EST 2004 marka@drugs.dv.isc.org:/usr/obj/usr/src/sys/DRUGS i386


>Description:

	Fetch corrupts passwords with spaces.

>How-To-Repeat:
	
	Create a account with a password that contains one or
	more spaces.  Try to use fetch to document that requires
	the use of that password.

>Fix:

Index: fetch.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/fetch/fetch.c,v
retrieving revision 1.10.2.23
diff -u -r1.10.2.23 fetch.c
--- fetch.c	12 Apr 2004 19:52:44 -0000	1.10.2.23
+++ fetch.c	10 Jul 2004 00:14:40 -0000
@@ -296,7 +296,7 @@
 		return -1;
 
 	for (i = 0; URL->pwd[i]; ++i)
-		if (isspace(URL->pwd[i]))
+		if (isspace(URL->pwd[i]) && URL->pwd[i] != ' ')
 			URL->pwd[i] = '\0';
 	return 0;
 }
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: simon 
Responsible-Changed-When: Sat Jul 10 11:27:24 GMT 2004 
Responsible-Changed-Why:  
Over to fetch author. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68881 
State-Changed-From-To: open->patched 
State-Changed-By: des 
State-Changed-When: Sat Aug 7 21:12:12 GMT 2004 
State-Changed-Why:  
Fixed in HEAD, awaiting MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68881 
State-Changed-From-To: patched->closed 
State-Changed-By: des 
State-Changed-When: Tue Aug 10 01:09:58 GMT 2004 
State-Changed-Why:  
MFCed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68881 
>Unformatted:
