From delphij@frontfree.net  Mon Jul  5 09:26:43 2004
Return-Path: <delphij@frontfree.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B1BF16A4CF
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Jul 2004 09:26:43 +0000 (GMT)
Received: from mail.FreeBSD.org.cn (dns3.freebsd.org.cn [61.129.66.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F43243D39
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Jul 2004 09:26:42 +0000 (GMT)
	(envelope-from delphij@frontfree.net)
Received: (qmail 79947 invoked by uid 0); 5 Jul 2004 09:25:04 -0000
Received: from unknown (HELO beastie.frontfree.net) (218.107.145.7)
  by mail.FreeBSD.org.cn with AES256-SHA encrypted SMTP; 5 Jul 2004 09:25:04 -0000
Received: from localhost (localhost.frontfree.net [127.0.0.1])
	by beastie.frontfree.net (Postfix) with ESMTP id BF6EF11785
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Jul 2004 17:26:09 +0800 (CST)
Received: from beastie.frontfree.net ([127.0.0.1])
 by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 04071-07 for <FreeBSD-gnats-submit@freebsd.org>;
 Mon,  5 Jul 2004 17:26:09 +0800 (CST)
Received: by beastie.frontfree.net (Postfix, from userid 1001)
	id BD33C1148A; Mon,  5 Jul 2004 17:26:08 +0800 (CST)
Message-Id: <20040705092608.BD33C1148A@beastie.frontfree.net>
Date: Mon,  5 Jul 2004 17:26:08 +0800 (CST)
From: Xin LI <delphij@frontfree.net>
Reply-To: Xin LI <delphij@frontfree.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] cron: Fix parsing of '0' and non-alphanumerics in steps
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         68683
>Category:       bin
>Synopsis:       [PATCH] cron: Fix parsing of '0' and non-alphanumerics in steps
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 05 09:30:13 GMT 2004
>Closed-Date:    Tue Feb 22 02:49:40 GMT 2005
>Last-Modified:  Tue Feb 22 02:49:40 GMT 2005
>Originator:     Xin LI
>Release:        FreeBSD 5.2-delphij i386
>Organization:
The FreeBSD Simplified Chinese Project
>Environment:
System: FreeBSD beastie.frontfree.net 5.2-delphij FreeBSD 5.2-delphij #80: Thu Jun 24 17:30:33 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386

>Description:
	Having an entry with stepping value of zero, say, */0, is currently
permitted by cron(5) however that will lead to a 100% CPU load. This should
be either documented in crontab(5), or be handled properly (preferred).
	The attached patch brings OpenBSD src/usr.sbin/cron/entry.c,v 1.17's
changes to FreeBSD, which will solve the issue.
>How-To-Repeat:
	Have a similiar line like this, in /etc/crontab
*/0    *       *       *       *       operator /usr/local/bin/test
>Fix:

--- patch-cron begins here ---
Index: entry.c
===================================================================
RCS file: /home/fcvs/src/usr.sbin/cron/lib/entry.c,v
retrieving revision 1.15
diff -u -r1.15 entry.c
--- entry.c	16 Aug 2001 14:23:59 -0000	1.15
+++ entry.c	5 Jul 2004 09:17:45 -0000
@@ -543,7 +543,7 @@
 		 * sent as a 0 since there is no offset either.
 		 */
 		ch = get_number(&num3, 0, PPC_NULL, ch, file);
-		if (ch == EOF)
+		if (ch == EOF || num3 == 0)
 			return EOF;
 	} else {
 		/* no step.  default==1.
@@ -592,6 +592,8 @@
 		ch = get_char(file);
 	}
 	*pc = '\0';
+	if (len == 0)
+	    return (EOF);
 
 	/* try to find the name in the name list
 	 */
--- patch-cron ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Fri Sep 17 08:35:25 GMT 2004 
Responsible-Changed-Why:  
Grab my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68683 
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Mon Feb 14 14:09:59 GMT 2005 
State-Changed-Why:  
MFC Reminder 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68683 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Tue Feb 22 02:49:20 GMT 2005 
State-Changed-Why:  
MFC'ed to RELENG_5 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68683 
>Unformatted:
