From nobody@FreeBSD.org  Sat May 15 17:11:54 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4336916A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 May 2004 17:11:54 -0700 (PDT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BDDF843D1F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 May 2004 17:11:53 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i4G0Br3S050521
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 May 2004 17:11:53 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i4G0Brlk050520;
	Sat, 15 May 2004 17:11:53 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200405160011.i4G0Brlk050520@www.freebsd.org>
Date: Sat, 15 May 2004 17:11:53 -0700 (PDT)
From: Dmitry Kazarov <kazarov@willcom.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mv incorrectly copies somedir/.. to ./.. when it crossing devices.
X-Send-Pr-Version: www-2.3

>Number:         66677
>Category:       bin
>Synopsis:       mv(1) incorrectly copies somedir/.. to ./.. when it crossing devices.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 15 17:20:14 PDT 2004
>Closed-Date:    
>Last-Modified:  Sat May 24 19:27:18 UTC 2008
>Originator:     Dmitry Kazarov
>Release:        FreeBSD 4.9 STABLE
>Organization:
MIDIKON
>Environment:
FreeBSD serv.willcom.ru 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Thu May  6 12:04:39 MSD 2004     root@serv.willcom.ru:/var/obj/usr/src/sys/SERV  i386
>Description:
When moving dirs across devices it does not check for moving some/dir/.. over ./.. dir (or more generally it allows moving a dir over contents of existing dir).
rename(2) disallows moving some/dir/.. over ./.. (but it works withing a filesystem).
>How-To-Repeat:
[697]$ cd
[698]$ df . /var/tmp
Filesystem      1K-blocks    Used   Avail Capacity  Mounted on
/dev/vinum/home   3949805 2850542  783279    78%    /home
/dev/vinum/var    9290542 3212148 5335152    38%    /var
[699]$ mkdir -p /var/tmp/1/1
[700]$ touch /var/tmp/1/11 /var/tmp/1/12;
[701]$ mkdir -p 2/2; cd 2/2
[702]$ ls
[703]$ ls ..
2
[704]$ mv /var/tmp/1/1/.. .
mv: "." and ".." may not be removed
mv: /bin/rm: terminated with 1 (non-zero) status: Cross-device link
[705]$ ls ..
1       11      12      2

BUT

[710]$ cd
[711]$ mkdir -p 1/1; touch 1/11 1/12
[712]$ mkdir -p 2/2
[713]$ cd 2/2
[714]$ mv ../../1/1/.. .
mv: rename ../../1/1/.. to ./..: Invalid argument


>Fix:
--- mv.c.orig   Sun May 16 04:04:29 2004
+++ mv.c        Sun May 16 04:11:04 2004
@@ -145,6 +145,9 @@
                if ((baselen + (len = strlen(p))) >= PATH_MAX) {
                        warnx("%s: destination pathname too long", *argv);
                        rval = 1;
+               } else if( strcmp("..",p) == 0 ) {
+                       warnx("moving '..' is not allowed");
+                       rval = 1;
                } else {
                        memmove(endp, p, (size_t)len + 1);
                        if (do_move(*argv, path))
 
>Release-Note:
>Audit-Trail:
>Unformatted:
