From sajd@telia.com  Tue Apr 13 08:48:29 2004
Return-Path: <sajd@telia.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AF25416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Apr 2004 08:48:29 -0700 (PDT)
Received: from av1-2-sn3.vrr.skanova.net (av1-2-sn3.vrr.skanova.net [81.228.9.106])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 73BCA43D48
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Apr 2004 08:48:29 -0700 (PDT)
	(envelope-from sajd@telia.com)
Received: by av1-2-sn3.vrr.skanova.net (Postfix, from userid 502)
	id 9796237E97; Tue, 13 Apr 2004 17:48:28 +0200 (CEST)
Received: from smtp1-2-sn3.vrr.skanova.net (smtp1-2-sn3.vrr.skanova.net [81.228.9.178])
	by av1-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 897F037E5D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Apr 2004 17:48:28 +0200 (CEST)
Received: from h204n2fls35o895.telia.com (h204n2fls35o895.telia.com [217.211.109.204])
	by smtp1-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 682D438023
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Apr 2004 17:48:28 +0200 (CEST)
Received: from lucifer.sed1.root4.net (localhost [127.0.0.1])
	by h204n2fls35o895.telia.com (8.12.11/8.12.11) with ESMTP id i3DFmRF8002996
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Apr 2004 17:48:27 +0200 (MEST)
	(envelope-from root@lucifer.sed1.root4.net)
Received: (from root@localhost)
	by lucifer.sed1.root4.net (8.12.11/8.12.11/Submit) id i3DFmRZQ002995;
	Tue, 13 Apr 2004 17:48:27 +0200 (MEST)
	(envelope-from root)
Message-Id: <200404131548.i3DFmRZQ002995@lucifer.sed1.root4.net>
Date: Tue, 13 Apr 2004 17:48:27 +0200 (MEST)
From: Pawel Worach <sajd@telia.com>
Reply-To: Pawel Worach <sajd@telia.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] make traceroute compile with gcc 3.4
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65492
>Category:       bin
>Synopsis:       [patch] make traceroute compile with gcc 3.4
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 13 08:50:18 PDT 2004
>Closed-Date:    Wed Jun 30 20:49:56 GMT 2004
>Last-Modified:  Wed Jun 30 20:49:56 GMT 2004
>Originator:     Pawel Worach
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 5.2-CURRENT #0: Fri Apr 9 05:08:50 MEST 2004


>Description:
	traceroute does not compile with stock FSF gcc 3.4 prerelease.
	error: label at end of compound statement

>How-To-Repeat:
	cd src/usr.sbin/traceroute && make CC="mygcc34"
>Fix:

	add break after empty default: label

--- patch begins here ---
Index: contrib/traceroute/findsaddr-socket.c
===================================================================
RCS file: /export/ctm/cvs/src/contrib/traceroute/findsaddr-socket.c,v
retrieving revision 1.2
diff -u -r1.2 findsaddr-socket.c
--- contrib/traceroute/findsaddr-socket.c	30 Jul 2002 04:49:13 -0000	1.2
+++ contrib/traceroute/findsaddr-socket.c	13 Apr 2004 15:28:35 -0000
@@ -192,6 +192,7 @@
 
 			default:
 				/* empty */
+				break;
 			}
 
 			if (SALEN(sa) == 0)
--- patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->kan 
Responsible-Changed-By: kris 
Responsible-Changed-When: Fri Apr 16 01:52:35 PDT 2004 
Responsible-Changed-Why:  
kan is working on the gcc 3.4 import 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65492 
State-Changed-From-To: open->closed 
State-Changed-By: kan 
State-Changed-When: Wed Jun 30 20:46:55 GMT 2004 
State-Changed-Why:  
tracerute is contributed source and the problem should be addressed upstream. 
Patching it in FreeBSD repo will serve no purpose but increase maintanance 
load on whoever will be updating traceroute next. 

I downgraded WARNS level for traceroute meanwhile. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65492 
>Unformatted:
