From olgeni@colby.it  Thu Mar 11 05:19:44 2004
Return-Path: <olgeni@colby.it>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2782D16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 05:19:44 -0800 (PST)
Received: from server.localdomain.net (unknown [81.208.57.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4AB9243D45
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 05:19:43 -0800 (PST)
	(envelope-from olgeni@colby.it)
Received: from server.localdomain.net (localhost [127.0.0.1])
	by server.localdomain.net (8.12.9p2/8.12.8) with ESMTP id i2BDJfgN037116
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 2004 14:19:41 +0100 (CET)
	(envelope-from olgeni@server.localdomain.net)
Received: (from olgeni@localhost)
	by server.localdomain.net (8.12.9p2/8.12.9/Submit) id i2BDJfDn037105;
	Thu, 11 Mar 2004 14:19:41 +0100 (CET)
	(envelope-from olgeni)
Message-Id: <200403111319.i2BDJfDn037105@server.localdomain.net>
Date: Thu, 11 Mar 2004 14:19:41 +0100 (CET)
From: g.olgeni@colby.it
Reply-To: g.olgeni@colby.it
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Sysinstall ignores srescue distribution
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64104
>Category:       bin
>Synopsis:       [sysinstall] sysinstall ignores srescue distribution
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    jhb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 11 05:20:25 PST 2004
>Closed-Date:    Fri Jan 07 21:05:00 GMT 2005
>Last-Modified:  Fri Jan 07 21:05:00 GMT 2005
>Originator:     Jimmy Olgeni
>Release:        FreeBSD 5.2.1-RELEASE i386
>Organization:
Colby
>Environment:

5.2-RELEASE, 5.2.1-RELEASE, -CURRENT.

>Description:

Sysinstall is not able to install the srescue source distribution, even if
it is located on the installation media. Files in /usr/src/rescue will not
be created, therefore buildworld cannot complete without running CVSUP.

Full buildworlds after applying patches from security advisories may fail
due to this unrelated issue.

>How-To-Repeat:

Install 5.2-RELEASE / 5.2.1-RELEASE, run make buildworld, see it fail. Run
cvsup on the same branch and see src/rescue/Makefile, src/rescue/REASME,
src/rescue/librescue/Makefile and src/rescue/rescue/Makefile pop up in
place.

>Fix:

In src/usr.sbin/sysinstall/dist.c, a record for "srescue" should be added
to SrcDistTable:

  DTE_TARBALL("srescue",   &SrcDists, SRC_RESCUE,   "/usr/src"),

The corresponding SRC_RESCUE constant should be added to dist.h, but all
the bits in DIST_SRC_ALL are already used and using more than 16 bits may
trigger side effects.
>Release-Note:
>Audit-Trail:

From: Jimmy Olgeni <g.olgeni@colby.it>
To: freebsd-gnats-submit@FreeBSD.org, g.olgeni@colby.it
Cc:  
Subject: Re: bin/64104: Sysinstall ignores srescue distribution
Date: Fri, 12 Mar 2004 14:13:13 +0100

 This may also help :-)
 
 --- src-install.sh.orig	Fri Mar 12 14:06:55 2004
 +++ src-install.sh	Fri Mar 12 14:07:30 2004
 @@ -19,7 +19,7 @@
   fi
 
   if [ "$1" = "all" ]; then
 -	dists="base bin contrib etc games gnu include lib libexec release sbin 
 share sys tools ubin usbin"
 +	dists="base bin contrib etc games gnu include lib libexec release 
 rescue sbin share sys tools ubin usbin"
   else
   	dists="$*"
   fi

Responsible-Changed-From-To: freebsd-bugs->freebsd-qa 
Responsible-Changed-By: kris 
Responsible-Changed-When: Mon Mar 15 16:32:43 PST 2004 
Responsible-Changed-Why:  
Assign to QA team for investigation 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64104 
Responsible-Changed-From-To: freebsd-qa->jhb 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Tue Mar 16 07:41:08 PST 2004 
Responsible-Changed-Why:  
I'll take this one.  Adding the extra bit for DIST_SRC_RELEASE should be fine 
and is required, btw. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64104 
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Fri Jan 7 21:04:37 GMT 2005 
State-Changed-Why:  
Colin Percival committed a fix for this prior to 5.3. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64104 
>Unformatted:
