From gavin@leeloo.york.ac.uk  Fri Feb  6 15:48:54 2004
Return-Path: <gavin@leeloo.york.ac.uk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D54C816A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Feb 2004 15:48:54 -0800 (PST)
Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0EA3543D41
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Feb 2004 15:48:53 -0800 (PST)
	(envelope-from gavin@leeloo.york.ac.uk)
Received: from leeloo.york.ac.uk (leeloo.york.ac.uk [144.32.226.154])
	by mail-gw0.york.ac.uk (8.12.10/8.12.10) with ESMTP id i16NmohT018494
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 6 Feb 2004 23:48:50 GMT
Received: from leeloo.york.ac.uk (localhost [127.0.0.1])
	by leeloo.york.ac.uk (8.12.10/8.12.10) with ESMTP id i16NfnaC035763
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 6 Feb 2004 23:41:53 GMT
	(envelope-from gavin@leeloo.york.ac.uk)
Received: (from root@localhost)
	by leeloo.york.ac.uk (8.12.10/8.12.10/Submit) id i16Ne1Iw035736;
	Fri, 6 Feb 2004 23:40:01 GMT
	(envelope-from gavin)
Message-Id: <200402062340.i16Ne1Iw035736@leeloo.york.ac.uk>
Date: Fri, 6 Feb 2004 23:40:01 GMT
From: Gavin Atkinson <gavin@ury.york.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: WARNS fixes for games/pom and games/caesar
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62456
>Category:       bin
>Synopsis:       WARNS fixes for games/pom and games/caesar
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    johan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 06 15:50:17 PST 2004
>Closed-Date:    Tue May 03 15:53:14 GMT 2005
>Last-Modified:  Tue May 03 15:53:14 GMT 2005
>Originator:     Gavin Atkinson <gavin@ury.york.ac.uk>
>Release:        FreeBSD 5.2-CURRENT sparc64
>Organization:
>Environment:
System: FreeBSD leeloo.york.ac.uk 5.2-CURRENT FreeBSD 5.2-CURRENT #3: Mon Jan 26 13:04:27 GMT 2004 root@leeloo.york.ac.uk:/usr/obj/usr/src/sys/GENERIC sparc64

>Description:

Fix games/pom and games/caesar to compile with WARNS=6

>How-To-Repeat:

Increase WARNS in games/[pom|caesar]/Makefile and attempt to compile

>Fix:

Patch below. Tested on i386 and sparc64.

(also available at:)
http://www.devrandom.co.uk/freebsd/caesar.diff
http://www.devrandom.co.uk/freebsd/pom.diff

--- games/caesar/Makefile.old	Fri Jun 22 22:38:27 2001
+++ games/caesar/Makefile	Mon Nov 24 23:09:29 2003
@@ -8,6 +8,6 @@
 MAN=	caesar.6
 MLINKS=	caesar.6 rot13.6
 
-WARNS?=	2
+WARNS?=	6
 
 .include <bsd.prog.mk>
--- games/caesar/caesar.c.old	Mon May  5 10:52:25 2003
+++ games/caesar/caesar.c	Mon Nov 24 23:10:03 2003
@@ -80,9 +80,7 @@
 void printit(char *);
 
 int
-main(argc, argv)
-	int argc;
-	char **argv;
+main(int argc, char **argv)
 {
 	int ch, dot, i, nread, winnerdot = 0;
 	char *inbuf;


--- games/pom/Makefile.old	Fri Jun 22 22:38:27 2001
+++ games/pom/Makefile	Mon Nov 24 23:08:47 2003
@@ -6,6 +6,6 @@
 DPADD=	${LIBM}
 LDADD=	-lm
 
-WARNS?=	2
+WARNS?=	6
 
 .include <bsd.prog.mk>
--- games/pom/pom.c.old	Mon May  5 10:52:25 2003
+++ games/pom/pom.c	Mon Nov 24 23:08:33 2003
@@ -78,7 +78,7 @@
 static double	potm(double);
 
 int
-main()
+main(void)
 {
 	time_t tt;
 	struct tm *GMT;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->johan 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sat Feb 7 15:18:20 PST 2004 
Responsible-Changed-Why:  
I will take care of this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62456 
State-Changed-From-To: open->patched 
State-Changed-By: stefanf 
State-Changed-When: Sun May 1 19:35:11 GMT 2005 
State-Changed-Why:  
Committed to -current, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62456 
State-Changed-From-To: patched->closed 
State-Changed-By: stefanf 
State-Changed-When: Tue May 3 15:50:21 GMT 2005 
State-Changed-Why:  
Close this PR, I don't think it's necessary to MFC this style change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62456 
>Unformatted:
