From edwin@mavetju.org  Wed Feb  4 00:58:22 2004
Return-Path: <edwin@mavetju.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2874A16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Feb 2004 00:58:22 -0800 (PST)
Received: from mailout2.barnet.com.au (mailout2.barnet.com.au [218.185.88.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C617343D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Feb 2004 00:58:20 -0800 (PST)
	(envelope-from edwin@mavetju.org)
Received: by mailout2.barnet.com.au (Postfix, from userid 27)
	id 0B953AA61D6; Wed,  4 Feb 2004 19:58:19 +1100 (EST)
Received: from extmail-auth.barnet.com.au (localhost [127.0.0.1])
	by extmail.barnet.com.au (Postfix) with ESMTP id AD43CB29D1C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Feb 2004 19:58:17 +1100 (EST)
Received: from k7.mavetju (edwin.adsl.barnet.com.au [203.111.122.2])
	by extmail-auth.barnet.com.au (Postfix) with ESMTP id 44CFD19379
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Feb 2004 19:58:13 +1100 (EST)
Received: by k7.mavetju (Postfix, from userid 1001)
	id EB9376A7101; Wed,  4 Feb 2004 19:58:12 +1100 (EST)
Message-Id: <20040204085812.EB9376A7101@k7.mavetju>
Date: Wed,  4 Feb 2004 19:58:12 +1100 (EST)
From: Edwin Groothuis <edwin@mavetju.org>
Reply-To: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: vipw doesn't see changes if re-edit for the second time
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62334
>Category:       bin
>Synopsis:       vipw doesn't see changes if re-edit for the second time
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    matteo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 04 01:00:35 PST 2004
>Closed-Date:    Sat Mar 04 10:23:05 GMT 2006
>Last-Modified:  Sat Mar 04 10:23:05 GMT 2006
>Originator:     Edwin Groothuis
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
>Environment:
System: FreeBSD k7.mavetju 4.8-RELEASE FreeBSD 4.8-RELEASE #1: Mon Jan 5 18:59:31 EST 2004 edwin@k7.mavetju:/usr/src/sys/compile/k7 i386

Also seen on -current of January 26th 2004

>Description:

If you run "vipw", make a change but make a mistake, and quit the
editor, you are warned about the mistake and are send back to the
editor. If you then don't save the file, but just quit, vipw will
say "no changes" and not update the old /etc/passwd but just quit.

>How-To-Repeat:

	vipw
	edit an entry but make a mistake (remove a : too much)
	:wq
	choose to re-edit
	:q!

vipw now says "vipw: no changes made", which is true with regarding
to the broken version of passwd which was just edited, but not with
regarding to the original version of passwd which was edited. I
expected to get thrown back into vi to fix the passwd file, or at
least get the option of aborting or going on.

>Fix:

-
>Release-Note:
>Audit-Trail:

From: Matteo Riondato <rionda@gufi.org>
To: bug-followup@FreeBSD.org, edwin@mavetju.org
Cc:  
Subject: Re: bin/62334: vipw doesn't see changes if re-edit for the second time
Date: Tue, 7 Jun 2005 21:40:52 +0200

 I don't think it's a bug:
 with ":q!" you choose not to save changes and changes are effectively not saved.
 If you make a mistake, then ":wq", then choose to reedit, then ":q!", the master.passwd
 file is not update and do not contain the mistake. 
 I don't see anything strange in this behaviour and think this PR can be closed.
 Best Regards
 -- 
 Rionda aka Matteo Riondato
 G.U.F.I. Staff Member (http://www.gufi.org)
 FreeSBIE Developer (http://www.freesbie.org)
State-Changed-From-To: open->closed 
State-Changed-By: matteo 
State-Changed-When: Sat Mar 4 10:21:20 UTC 2006 
State-Changed-Why:  
Not a bug 


Responsible-Changed-From-To: freebsd-bugs->matteo 
Responsible-Changed-By: matteo 
Responsible-Changed-When: Sat Mar 4 10:21:20 UTC 2006 
Responsible-Changed-Why:  
grab this, just in case.. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62334 
>Unformatted:
